[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Brandt Bucher added the comment: New changeset 27f9dafc2ba51864a9bc2fe5d6293eb4fd887bce by Brandt Bucher in branch 'master': bpo-40636: Remove overly-strict zip pickling tests (GH-24109) https://github.com/python/cpython/commit/27f9dafc2ba51864a9bc2fe5d6293eb4fd887bce --

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Change by Brandt Bucher : -- pull_requests: +22938 pull_request: https://github.com/python/cpython/pull/24109 ___ Python tracker ___

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Brandt Bucher added the comment: Yep, fine by me. I can remove them later today (unless Serhiy beats me to it). -- ___ Python tracker ___

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Guido van Rossum added the comment: Sounds good, go for it. I assume @brandtbucher won't mind. -- ___ Python tracker ___ ___

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Serhiy Storchaka added the comment: For other types we do not have such strict tests. We just test that pickling roundtrips (it is already tested for zip() in other tests). There are few tests that unpickling some exact byte strings produces the expected value, but these tests are in

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Guido van Rossum added the comment: That's fair. How do other builtins validate their pickling implementation? Since the pickling goes through __reduce__/__reduce_ex__ we could instead test that those methods return the expected results, that pickling roundtrips, and that unpickling those

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Serhiy Storchaka added the comment: Tests test_zip_pickle_stability and test_zip_pickle_strict_stability look excessively strict. Why did we need them if there are other pickle tests? They prevent implementing optimizations like in issue36694. -- nosy: +serhiy.storchaka

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Ram Rachum added the comment: I'll fix that typo. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

SilentGhost added the comment: Ram, please fix the typo pointed out on github https://github.com/python/cpython/commit/59cf853332a82ce92875ea3dd6bba08e1305a288#r40044022 -- nosy: +SilentGhost ___ Python tracker

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Change by Brandt Bucher : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Guido van Rossum added the comment: New changeset 59cf853332a82ce92875ea3dd6bba08e1305a288 by Ram Rachum in branch 'master': bpo-40636: Documentation for zip-strict (#20961) https://github.com/python/cpython/commit/59cf853332a82ce92875ea3dd6bba08e1305a288 --

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

STINNER Victor added the comment: New changeset 310f6aa7db8dd48952ed718111ce0f016b1c8ef9 by Guido van Rossum in branch 'master': bpo-40636: PEP 618: add strict parameter to zip() (GH-20921) https://github.com/python/cpython/commit/310f6aa7db8dd48952ed718111ce0f016b1c8ef9 -- nosy:

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Change by Ram Rachum : -- pull_requests: +20140 pull_request: https://github.com/python/cpython/pull/20961 ___ Python tracker ___

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Change by Guido van Rossum : -- nosy: +gvanrossum nosy_count: 5.0 -> 6.0 pull_requests: +20120 pull_request: https://github.com/python/cpython/pull/20921 ___ Python tracker

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Change by Brandt Bucher : -- assignee: -> brandtbucher components: +Interpreter Core nosy: +cool-RR versions: +Python 3.10 -Python 3.9 ___ Python tracker ___

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

miss-islington added the comment: New changeset c3d025a86a60348f19551bd9921304c5db322531 by Miss Islington (bot) in branch '3.8': bpo-40636: Clarify the zip built-in docstring. (GH-20118) https://github.com/python/cpython/commit/c3d025a86a60348f19551bd9921304c5db322531 --

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +19429 pull_request: https://github.com/python/cpython/pull/20124 ___ Python tracker

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Gregory P. Smith added the comment: New changeset 6a5d3ff67644af42b1a781be2eacb2e82913441c by Gregory P. Smith in branch 'master': bpo-40636: Clarify the zip built-in docstring. (GH-20118) https://github.com/python/cpython/commit/6a5d3ff67644af42b1a781be2eacb2e82913441c --

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

New submission from Gregory P. Smith : PEP 618 https://www.python.org/dev/peps/pep-0618 discussions are still on going. This issue is being filed to track an implementation, assuming the PEP is accepted and one is decided upon. I'm filing it now, as I can at least use the issue for

[issue40636] Provide a strict form of zip (PEP-618) requiring same length inputs

Change by Gregory P. Smith : -- keywords: +patch pull_requests: +19422 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/20118 ___ Python tracker