[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Ned Deily added the comment: New changeset cfc7ff8d05f7a949a88b8a8dd506fb5c1c30d3e9 by Tapas Kundu in branch '3.6': [3.6] bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface (GH-21033) (GH-21232)

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Ned Deily added the comment: New changeset b98e7790c77a4378ec4b1c71b84138cb930b69b7 by Tapas Kundu in branch '3.7': [3.7] bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface (GH-21033) (GH-21231)

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Ned Deily added the comment: A legitimate CVE should certainly be backported to all applicable releases, so, yes. However, I think that it is important for the CVE to be mentioned in the NEWS blurbs for each commit. So please update the NEWS items in each open PR to include the CVE. For

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Dong-hee Na added the comment: > https://nvd.nist.gov/vuln/detail?vulnId=CVE-2020-14422 As Eric said, this issue is assigned a CVE-2020-14422. I re-open PRs for 3.5 - 3.7 and waiting for other core developers guide. I am +1 on merge this PRs as the security patch. -- nosy: +corona10

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by Dong-hee Na : -- status: closed -> open versions: +Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___ ___

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Eric V. Smith added the comment: Ned: what are your thoughts on backporting this as a security issue? https://nvd.nist.gov/vuln/detail?vulnId=CVE-2020-14422 -- nosy: +ned.deily ___ Python tracker

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by Tapas Kundu : -- pull_requests: +20387 pull_request: https://github.com/python/cpython/pull/21233 ___ Python tracker ___

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by Tapas Kundu : -- pull_requests: +20386 pull_request: https://github.com/python/cpython/pull/21232 ___ Python tracker ___

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by Tapas Kundu : -- nosy: +tapakund nosy_count: 7.0 -> 8.0 pull_requests: +20385 pull_request: https://github.com/python/cpython/pull/21231 ___ Python tracker ___

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by Eric V. Smith : -- assignee: -> eric.smith resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

miss-islington added the comment: New changeset 9a646aa82dfa62d70ca2a99ada901ee6cf9f82bd by Miss Islington (bot) in branch '3.9': bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface (GH-21033)

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

miss-islington added the comment: New changeset dc8ce8ead182de46584cc1ed8a8c51d48240cbd5 by Miss Islington (bot) in branch '3.8': bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface (GH-21033)

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by miss-islington : -- pull_requests: +20373 pull_request: https://github.com/python/cpython/pull/21221 ___ Python tracker ___

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by miss-islington : -- nosy: +miss-islington nosy_count: 6.0 -> 7.0 pull_requests: +20372 pull_request: https://github.com/python/cpython/pull/21220 ___ Python tracker

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Eric V. Smith added the comment: New changeset b30ee26e366bf509b7538d79bfec6c6d38d53f28 by Ravi Teja P in branch 'master': bpo-41004: Resolve hash collisions for IPv4Interface and IPv6Interface (GH-21033) https://github.com/python/cpython/commit/b30ee26e366bf509b7538d79bfec6c6d38d53f28

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Ravi Teja P added the comment: Hi My CLA has been approved. Can someone review the PR. -- ___ Python tracker ___ ___

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by Beuc : -- nosy: +Beuc ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Amir Mohamadi added the comment: No @rvteja92, you don't need open multiple PRs, only make your changes on master branch. for more informations read this: https://devguide.python.org/ And for the CLA sign it will take a while to be updated. --

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Ravi Teja P added the comment: Hi I have raised a PR for this. But my PLA is yet to be updated (I have singed it). But add the fix to the existing versions (3.8, 3.9 and 3.10), do I need to raise PR for each of those branches? -- ___ Python

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by Ravi Teja P : -- nosy: +rvteja92 nosy_count: 4.0 -> 5.0 pull_requests: +20204 pull_request: https://github.com/python/cpython/pull/21033 ___ Python tracker ___

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Eric V. Smith added the comment: Changing versions to where the fix would be applied. -- versions: -Python 3.5, Python 3.6, Python 3.7 ___ Python tracker ___

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

martin w added the comment: Absolutely, go ahead Amir -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by Sree Vaddi : -- keywords: +patch nosy: +svaddi nosy_count: 3.0 -> 4.0 pull_requests: +20137 stage: -> patch review pull_request: https://github.com/python/cpython/pull/20956 ___ Python tracker

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Amir Mohamadi added the comment: Can I make a PR for this? -- nosy: +Amir ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

martin w added the comment: Forgot to add, this applies to all versions, 3.10, 3.9, 3.8, 3.7, 3.6, 3.5 -- versions: +Python 3.5, Python 3.6, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by martin w : -- versions: +Python 3.10 -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by Eric V. Smith : -- keywords: +easy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Eric V. Smith added the comment: Good catch. Your approach seems like a good one. -- nosy: +eric.smith ___ Python tracker ___ ___

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

Change by martin w : -- type: -> security ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41004] Hash collisions in IPv4Interface and IPv6Interface

New submission from martin w : In the ipaddress library there exists two classes IPv4Interface, and IPv6Interface. These classes' hash functions will always return 32 and 64 respectively. If IPv4Interface or IPv6Interface objects then are put in a dictionary, on for example a server storing