[issue41093] BaseServer's server_forever() shutdown immediately when calling shutdown()

2020-06-24 Thread Ned Deily
Ned Deily added the comment: > By the way I have to ask, if I want this feature to be merged (this is my > first PR) Thank you for the PR and your contribution! Unless a PR is for a problem specific to a release, simply submit a PR against the master branch. If and when a core developer

[issue41093] BaseServer's server_forever() shutdown immediately when calling shutdown()

2020-06-23 Thread Tony
Change by Tony : -- pull_requests: +20260 pull_request: https://github.com/python/cpython/pull/21094 ___ Python tracker ___ ___

[issue41093] BaseServer's server_forever() shutdown immediately when calling shutdown()

2020-06-23 Thread Tony
Change by Tony : -- keywords: +patch pull_requests: +20259 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21093 ___ Python tracker ___

[issue41093] BaseServer's server_forever() shutdown immediately when calling shutdown()

2020-06-23 Thread Tony
Tony added the comment: By the way I have to ask, if I want this feature to be merged (this is my first PR) should I make a PR to 3.6/3.7/3.8/3.9 and master? Or should I create a PR to master only? thanks -- ___ Python tracker

[issue41093] BaseServer's server_forever() shutdown immediately when calling shutdown()

2020-06-23 Thread Tony
New submission from Tony : Currently calling BaseServer's shutdown() function will not make serve_forever() return immediately from it's select(). I suggest adding a new function called server_shutdown() that will make serve_forever() shutdown immediately. Then in TCPServer(BaseServer) all