[issue41317] sock_accept() does not remove server socket reader on cancellation

miss-islington added the comment: New changeset 4ff8e5ba4fef7f7d0fc1b1872ccb91bc3fd1294d by Miss Islington (bot) in branch '3.9': bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() (GH-21595)

[issue41317] sock_accept() does not remove server socket reader on cancellation

Yury Selivanov added the comment: New changeset 0dd98c2d00a75efbec19c2ed942923981bc06683 by Alex Grönholm in branch 'master': bpo-41317: Remove reader on cancellation in asyncio.loop.sock_accept() (#21595) https://github.com/python/cpython/commit/0dd98c2d00a75efbec19c2ed942923981bc06683

[issue41317] sock_accept() does not remove server socket reader on cancellation

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +20742 pull_request: https://github.com/python/cpython/pull/21603 ___ Python tracker

[issue41317] sock_accept() does not remove server socket reader on cancellation

Change by Alex Grönholm : -- keywords: +patch pull_requests: +20734 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21595 ___ Python tracker ___

[issue41317] sock_accept() does not remove server socket reader on cancellation

Alex Grönholm added the comment: Looks like they do – fantastic! -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41317] sock_accept() does not remove server socket reader on cancellation

Alex Grönholm added the comment: Sure, it should be a rather straightforward fix. I have to check if the tests for the related methods test for proper cancellation semantics. It should be even faster if they do. -- ___ Python tracker

[issue41317] sock_accept() does not remove server socket reader on cancellation

Yury Selivanov added the comment: Alex, do you want to submit a PR? -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41317] sock_accept() does not remove server socket reader on cancellation

Alex Grönholm added the comment: This bug is the same as https://bugs.python.org/issue30064 except for sock_accept(). -- ___ Python tracker ___

[issue41317] sock_accept() does not remove server socket reader on cancellation

New submission from Alex Grönholm : Unlike with all the other sock_* functions, sock_accept() only removes the reader on the server socket when the socket becomes available for reading (ie. when there's an incoming connection). If the operation is cancelled instead, the reader is not removed.