[issue41342] Convert int.__round__ to Argument Clinic

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41342] Convert int.__round__ to Argument Clinic

Serhiy Storchaka added the comment: New changeset 5a2bac7fe0e7a2b67fd57c7a9176a50feed0d7a0 by Serhiy Storchaka in branch 'master': bpo-41342: Convert int.__round__ to Argument Clinic (GH-21549) https://github.com/python/cpython/commit/5a2bac7fe0e7a2b67fd57c7a9176a50feed0d7a0 --

[issue41342] Convert int.__round__ to Argument Clinic

Serhiy Storchaka added the comment: Yes, you can do this without Argument Clinic, but Argument Clinic allows to hide the use of unstable private API and cumbersome code under macros and in generated files. > That said, it would be great if someone were to work on building-out AC to >

[issue41342] Convert int.__round__ to Argument Clinic

Raymond Hettinger added the comment: I don't have an opinion on the PR but want to point-out the Argument Clinic itself doesn't provide a performance benefit. Anything that it does can also be done directly by the code itself, including vectorcall logic. You should be able to optimize the

[issue41342] Convert int.__round__ to Argument Clinic

Change by Raymond Hettinger : -- Removed message: https://bugs.python.org/msg373973 ___ Python tracker ___ ___ Python-bugs-list

[issue41342] Convert int.__round__ to Argument Clinic

Raymond Hettinger added the comment: I don't have an opinion on the PR but want to point-out the Argument Clinic itself doesn't provide a performance benefit. Anything that it does can also be done directly by the code itself, including vectorcall logic. You should be able to optimize

[issue41342] Convert int.__round__ to Argument Clinic

Change by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41342] Convert int.__round__ to Argument Clinic

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +20691 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21549 ___ Python tracker

[issue41342] Convert int.__round__ to Argument Clinic

New submission from Serhiy Storchaka : int.__round__ was not converted to Argument Clinic because it is not impossible to express a correct signature for it in Python. But now we can at least make Argument Clinic not producing incorrect signature. And converting to Argument Clinic has a