[issue41524] PyOS_mystricmp advances pointers too far

Dong-hee Na added the comment: New changeset 85ca9c049c5a490d143d28933bbb02ab80394ed8 by Miss Islington (bot) in branch '3.8': bpo-41524: fix pointer bug in PyOS_mystr{n}icmp (GH-21845) (GH-22016) https://github.com/python/cpython/commit/85ca9c049c5a490d143d28933bbb02ab80394ed8 --

[issue41524] PyOS_mystricmp advances pointers too far

Dong-hee Na added the comment: Thanks William -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41524] PyOS_mystricmp advances pointers too far

Dong-hee Na added the comment: New changeset 901c2eae6e27ee7793e5a3c638664e01a3bf8de8 by Miss Islington (bot) in branch '3.9': bpo-41524: fix pointer bug in PyOS_mystr{n}icmp (GH-21845) (GH-21978) https://github.com/python/cpython/commit/901c2eae6e27ee7793e5a3c638664e01a3bf8de8 --

[issue41524] PyOS_mystricmp advances pointers too far

Change by miss-islington : -- pull_requests: +21116 pull_request: https://github.com/python/cpython/pull/22016 ___ Python tracker ___

[issue41524] PyOS_mystricmp advances pointers too far

Change by miss-islington : -- pull_requests: +21088 pull_request: https://github.com/python/cpython/pull/21979 ___ Python tracker ___

[issue41524] PyOS_mystricmp advances pointers too far

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +21087 pull_request: https://github.com/python/cpython/pull/21978 ___ Python tracker

[issue41524] PyOS_mystricmp advances pointers too far

Dong-hee Na added the comment: New changeset 97eaf2b5e5c826b9abe59896a363853bef55c5d9 by wmeehan in branch 'master': bpo-41524: fix pointer bug in PyOS_mystr{n}icmp (GH-21845) https://github.com/python/cpython/commit/97eaf2b5e5c826b9abe59896a363853bef55c5d9 -- nosy: +corona10

[issue41524] PyOS_mystricmp advances pointers too far

Change by William Meehan : -- keywords: +patch pull_requests: +20972 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/21845 ___ Python tracker

[issue41524] PyOS_mystricmp advances pointers too far

Serhiy Storchaka added the comment: Good catch! Do you mind to provide a PR for this William? -- keywords: +easy (C) nosy: +serhiy.storchaka stage: -> needs patch ___ Python tracker

[issue41524] PyOS_mystricmp advances pointers too far

New submission from William Meehan : The existing implementation of PyOS_mystricmp increments both pointers as long as the first string hasn't reached the end yet. If the second string ends first, then we increment past the null byte. If there is a difference in the middle of the two