[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Pablo Galindo Salgado added the comment: New changeset d64d78be20ced6ac9de58e91e69eaba184e36e9b by Miss Islington (bot) in branch '3.9': bpo-41531: Fix compilation of dict literals with more than 0x elements (GH-21850) (GH-22107)

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by miss-islington : -- pull_requests: +21192 pull_request: https://github.com/python/cpython/pull/22107 ___ Python tracker ___

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by miss-islington : -- pull_requests: +21190 pull_request: https://github.com/python/cpython/pull/22105 ___ Python tracker ___

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Karthikeyan Singaravelan added the comment: @hroncok said on Twitter it was reported at https://github.com/Storyyeller/enjarify/issues/17 -- ___ Python tracker ___

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Mark Shannon added the comment: @hroncok, How did you discover this issue? I'd like to clean up the code for creating dictionary literals and it might be helpful to know where such huge dictionary literals exist. I'm guessing that they are used as lookup tables for things like Unicode

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by miss-islington : -- nosy: +miss-islington nosy_count: 9.0 -> 10.0 pull_requests: +20980 pull_request: https://github.com/python/cpython/pull/21853 ___ Python tracker

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Mark Shannon added the comment: New changeset c51db0ea40ddabaf5f771ea633b37fcf4c90a495 by Pablo Galindo in branch 'master': bpo-41531: Fix compilation of dict literals with more than 0x elements (GH-21850) https://github.com/python/cpython/commit/c51db0ea40ddabaf5f771ea633b37fcf4c90a495

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by Batuhan Osman Taşkaya : -- nosy: +batuhanosmantaskaya ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by Pablo Galindo Salgado : -- keywords: +patch nosy: +pablogsal nosy_count: 7.0 -> 8.0 pull_requests: +20978 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21850 ___ Python tracker

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Matthew Barnett added the comment: I think what's happening is that in 'compiler_dict' (Python/compile.c), it's checking whether 'elements' has reached a maximum (0x). However, it's not doing this after incrementing; instead, it's checking before incrementing and resetting 'elements' to

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by Serhiy Storchaka : -- components: +Interpreter Core nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by Eric V. Smith : -- nosy: +eric.smith ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by STINNER Victor : -- priority: normal -> release blocker ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by STINNER Victor : -- keywords: +3.9regression ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by Miro Hrončok : -- versions: +Python 3.10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Zbyszek Jędrzejewski-Szmek added the comment: Bisect says 8a4cd700a7426341c2074a2b580306d2d60ec839 is the first bad commit. Considering that 0x appears a few times in that patch, that seems plausible ;) -- ___ Python tracker

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by Ammar Askar : -- nosy: +Mark.Shannon ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Miro Hrončok added the comment: It appears that the 65535 key is missing regardless of the LEN value. -- ___ Python tracker ___ ___

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

Zbyszek Jędrzejewski-Szmek added the comment: Also reproduces with today's git. -- nosy: +zbysz ___ Python tracker ___ ___

[issue41531] Python 3.9 regression: Literal dict with > 65535 items are one item shorter

New submission from Miro Hrončok : Consider this reproducer.py: import sys LEN = int(sys.argv[1]) with open('big_dict.py', 'w') as f: print('INTS = {', file=f) for i in range(LEN): print(f'{i}: None,', file=f) print('}', file=f) import big_dict assert