[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

STINNER Victor added the comment: You're welcome ;-) -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Ned Deily added the comment: Thanks for the fix, Victor. Sometime after filing this, I remembered that we had seen a similar problem some years ago and found bpo-21572 in which I had changed Lib/site.py to no longer use a release-dependent URL for the license file - which is why the check

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

miss-islington added the comment: New changeset 8b4642d3288e187faad24283c949ecf53fecad5b by Miss Skeleton (bot) in branch '3.8': bpo-41939: always enable test_site.test_license_exists_at_url (GH-22688) https://github.com/python/cpython/commit/8b4642d3288e187faad24283c949ecf53fecad5b

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

miss-islington added the comment: New changeset 881a13cad534cf3fe4474579c22235a15d3ba27b by Miss Skeleton (bot) in branch '3.9': bpo-41939: always enable test_site.test_license_exists_at_url (GH-22688) https://github.com/python/cpython/commit/881a13cad534cf3fe4474579c22235a15d3ba27b

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Change by miss-islington : -- pull_requests: +21660 pull_request: https://github.com/python/cpython/pull/22689 ___ Python tracker ___

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Change by miss-islington : -- pull_requests: +21661 pull_request: https://github.com/python/cpython/pull/22690 ___ Python tracker ___

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Ned Deily added the comment: New changeset 6a48518e8dac3521ff387ee67cdf33783114a257 by Ned Deily in branch 'master': bpo-41939: always enable test_site.test_license_exists_at_url (GH-22688) https://github.com/python/cpython/commit/6a48518e8dac3521ff387ee67cdf33783114a257 --

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Change by Ned Deily : -- pull_requests: +21658 pull_request: https://github.com/python/cpython/pull/22688 ___ Python tracker ___

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.8 ___ Python tracker ___

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

miss-islington added the comment: New changeset 78bddc7794a629614dc84e195b9117416ae97ed3 by Miss Skeleton (bot) in branch '3.8': bpo-41939: Fix test_site.test_license_exists_at_url() (GH-22559) https://github.com/python/cpython/commit/78bddc7794a629614dc84e195b9117416ae97ed3 --

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Change by miss-islington : -- pull_requests: +21569 pull_request: https://github.com/python/cpython/pull/22574 ___ Python tracker ___

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Łukasz Langa added the comment: New changeset 10b4136bfa5878c058753e1d1bd091e0f7e1ba40 by Miss Skeleton (bot) in branch '3.9': bpo-41939: Fix test_site.test_license_exists_at_url() (GH-22559) (#22567) https://github.com/python/cpython/commit/10b4136bfa5878c058753e1d1bd091e0f7e1ba40

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Change by miss-islington : -- nosy: +miss-islington nosy_count: 3.0 -> 4.0 pull_requests: +21563 pull_request: https://github.com/python/cpython/pull/22567 ___ Python tracker

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Łukasz Langa added the comment: New changeset 1fce240d6c4b2b2cc17a86e88c65169e15b9feeb by Victor Stinner in branch 'master': bpo-41939: Fix test_site.test_license_exists_at_url() (#22559) https://github.com/python/cpython/commit/1fce240d6c4b2b2cc17a86e88c65169e15b9feeb --

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

STINNER Victor added the comment: I proposed PR 22559 to fix the issue. See also bpo-37475: "What is urllib.request.urlcleanup() function?". -- ___ Python tracker ___

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

Change by STINNER Victor : -- keywords: +patch pull_requests: +21554 stage: -> patch review pull_request: https://github.com/python/cpython/pull/22559 ___ Python tracker ___

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

STINNER Victor added the comment: It's a minor issue in the test itself, not in urllib. Such bug should not block a release. -- ___ Python tracker ___

[issue41939] 3.9.0 test_site warning: "urllib.requests._opener was modified by test_site"

New submission from Ned Deily : For 3.9.0, test_site fails with an env changed warning: Warning -- urllib.requests._opener was modified by test_site Before: None After: test_site failed (env changed) == Tests result: SUCCESS == 1 test altered the execution environment: test_site