[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

Pablo Galindo Salgado added the comment: New changeset 3ba65cdcefcec7866be482138a5ea8aafbd07e59 by Miss Islington (bot) in branch '3.9': bpo-42588: Update the docs for the TopologicalSorter.static_order() method (GH-26834) (GH-26952)

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

miss-islington added the comment: New changeset d9fc4c3deb617beb1d0bbfdb4efc905a4192ff0a by Miss Islington (bot) in branch '3.10': bpo-42588: Update the docs for the TopologicalSorter.static_order() method (GH-26834)

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

Pablo Galindo Salgado added the comment: Thanks, Ran and Andrei for your contributions! :) -- nosy: -miss-islington resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

Change by miss-islington : -- nosy: +miss-islington nosy_count: 6.0 -> 7.0 pull_requests: +25519 pull_request: https://github.com/python/cpython/pull/26951 ___ Python tracker

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

Change by miss-islington : -- pull_requests: +25520 pull_request: https://github.com/python/cpython/pull/26952 ___ Python tracker ___

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

Pablo Galindo Salgado added the comment: New changeset 0d7f7975d55eff7e3dfcebd14e765fc6cd7d3e40 by andrei kulakov in branch 'main': bpo-42588: Update the docs for the TopologicalSorter.static_order() method (GH-26834)

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

Andrei Kulakov added the comment: I'm not sure it's worth it to complicate the logic by raising the error before iteration since iteration is normally done soon after method call. I agree the doc change is helpful, since the ticket was dormant for a ~month, I've put up a PR with this change

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

Change by Andrei Kulakov : -- keywords: +patch nosy: +andrei.avk nosy_count: 5.0 -> 6.0 pull_requests: +25415 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26834 ___ Python tracker

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

Pablo Galindo Salgado added the comment: Hi Ran, would you like to submit a pull request with the suggestion? -- ___ Python tracker ___

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

Change by Karthikeyan Singaravelan : -- nosy: +pablogsal, rhettinger, tim.peters ___ Python tracker ___ ___ Python-bugs-list

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

Ran Benita added the comment: Hmm I realize after the fact that since the equivalent code snippet (which is actually the implementation) is a generator, then it is actually correct that prepare() isn't called until it is iterated. So the documentation for this is not incorrect. Still, I

[issue42588] Improvements to graphlib.TopologicalSorter.static_order() documentation

New submission from Ran Benita : One issue and one suggestion. Issue: The documentation of prepare() says: > If any cycle is detected, CycleError will be raised which is what happens. The documentation of static_order() says that static_order() is equivalent to: def static_order(self):