[issue42655] Fix subprocess extra_groups gid conversion

Serhiy Storchaka added the comment: Thank you for your contribution Jakub. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue42655] Fix subprocess extra_groups gid conversion

miss-islington added the comment: New changeset 3966e2ea412a5f190dc8655d9aa7a15c08c4e280 by Miss Islington (bot) in branch '3.9': bpo-42655: Fix subprocess extra_groups gid conversion (GH-23762) https://github.com/python/cpython/commit/3966e2ea412a5f190dc8655d9aa7a15c08c4e280 --

[issue42655] Fix subprocess extra_groups gid conversion

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +22840 pull_request: https://github.com/python/cpython/pull/23997 ___ Python tracker

[issue42655] Fix subprocess extra_groups gid conversion

Serhiy Storchaka added the comment: New changeset 0159e5efeebd12b3cf365c8569ca000eac7cb03e by Jakub Kulík in branch 'master': bpo-42655: Fix subprocess extra_groups gid conversion (GH-23762) https://github.com/python/cpython/commit/0159e5efeebd12b3cf365c8569ca000eac7cb03e -- nosy:

[issue42655] Fix subprocess extra_groups gid conversion

Jakub Kulik added the comment: I checked and indeed there seems to be no reason as for why should we use `void *` rather than `gid_t *` and `uid_t *`. I changed that in the attached PR. -- ___ Python tracker

[issue42655] Fix subprocess extra_groups gid conversion

Alexey Izbyshev added the comment: This bug would have been caught at compile time if `_Py_Gid_Converter()` used `gid_t *` instead of `void *`. I couldn't find any call sites where `void *` would be needed, so probably `_Py_Gid_Converter()` should be fixed too (in a separate PR/issue?). The

[issue42655] Fix subprocess extra_groups gid conversion

Change by Jakub Kulik : -- keywords: +patch pull_requests: +22655 stage: -> patch review pull_request: https://github.com/python/cpython/pull/23762 ___ Python tracker ___

[issue42655] Fix subprocess extra_groups gid conversion

New submission from Jakub Kulik : C function `subprocess_fork_exec` incorrectly transforms gids from the `extra_groups` argument because it passes `unsigned long*` rather than `pid_t*` into the `_Py_Gid_Converter()`. Assuming that `gid_t` is 32 bit and `unsigned long` is 64 bit (which it