[issue42794] test_nntplib fails on CI

Change by Serhiy Storchaka : -- pull_requests: +22950 pull_request: https://github.com/python/cpython/pull/22632 ___ Python tracker ___

[issue42794] test_nntplib fails on CI

STINNER Victor added the comment: Thanks Dong-hee Na for the fix! We have many tests using external services, like test_ssl that Christian may know ;-) https://pythondev.readthedocs.io/infra.html#services-used-by-unit-tests -- resolution: -> fixed stage: -> resolved status: open

[issue42794] test_nntplib fails on CI

Ned Deily added the comment: New changeset 546baba63a446e261d0248338f9034e56eccfc46 by Miss Islington (bot) in branch '3.6': bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) (GH-24042)

[issue42794] test_nntplib fails on CI

Ned Deily added the comment: New changeset 8200ee66697601a8766f234d6eb8e4c8735216fd by Miss Islington (bot) in branch '3.7': bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) (GH-24041)

[issue42794] test_nntplib fails on CI

Marc-Andre Lemburg added the comment: Thanks for the patch, Dong-hee Na. Christian: Tests relying on external resources will always have such issues. This doesn't mean that the code which is being tested is outdated or broken. It's just an issue with the tests. Perhaps we ought to disable

[issue42794] test_nntplib fails on CI

Christian Heimes added the comment: > The test fails because it was relying on an external news server's > configuratoin. This doesn't mean the code itself is broken, just the > test, so clearly: no. Broken and unstable tests are one of two reasons why I listed nntplib in my PEP,

[issue42794] test_nntplib fails on CI

miss-islington added the comment: New changeset b20d5e5ce95248e0fa77c5d7bf8f6f5b1231fa53 by Miss Islington (bot) in branch '3.9': bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) https://github.com/python/cpython/commit/b20d5e5ce95248e0fa77c5d7bf8f6f5b1231fa53

[issue42794] test_nntplib fails on CI

miss-islington added the comment: New changeset 381f3e4bfd4b1c440f7cb3025972fe0acd0406fc by Miss Islington (bot) in branch '3.8': bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) https://github.com/python/cpython/commit/381f3e4bfd4b1c440f7cb3025972fe0acd0406fc

[issue42794] test_nntplib fails on CI

Change by miss-islington : -- pull_requests: +22883 pull_request: https://github.com/python/cpython/pull/24042 ___ Python tracker ___

[issue42794] test_nntplib fails on CI

Change by miss-islington : -- pull_requests: +22882 pull_request: https://github.com/python/cpython/pull/24041 ___ Python tracker ___

[issue42794] test_nntplib fails on CI

Change by miss-islington : -- pull_requests: +22881 pull_request: https://github.com/python/cpython/pull/24040 ___ Python tracker ___

[issue42794] test_nntplib fails on CI

Change by miss-islington : -- nosy: +miss-islington nosy_count: 7.0 -> 8.0 pull_requests: +22880 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24039 ___ Python tracker

[issue42794] test_nntplib fails on CI

Dong-hee Na added the comment: New changeset ec3165320e81ac87edcb85c86c452528ddbaec1c by Dong-hee Na in branch 'master': bpo-42794: Update test_nntplib to use offical group name for testing (GH-24037) https://github.com/python/cpython/commit/ec3165320e81ac87edcb85c86c452528ddbaec1c

[issue42794] test_nntplib fails on CI

Marc-Andre Lemburg added the comment: On 01.01.2021 13:57, Christian Heimes wrote: > > Does this issue mean that I should include nntplib in PEP 594 again? The test fails because it was relying on an external news server's configuratoin. This doesn't mean the code itself is broken, just the

[issue42794] test_nntplib fails on CI

Christian Heimes added the comment: Does this issue mean that I should include nntplib in PEP 594 again? -- nosy: +christian.heimes ___ Python tracker ___

[issue42794] test_nntplib fails on CI

Dong-hee Na added the comment: > For tests with the external environment, How about skipping tests if servers are not available? Hmm, I change my mind this is not a good idea :( -- ___ Python tracker

[issue42794] test_nntplib fails on CI

Dong-hee Na added the comment: > How to handle similar breakage of external servers? For tests with the external environment, How about skipping tests if servers are not available? It is assumed that if there is a change related to NNTP, it is well checked in the CI and review. This is

[issue42794] test_nntplib fails on CI

Serhiy Storchaka added the comment: The test was passed on my computer because test.test_nntplib.NetworkedNNTP_SSLTests was skipped because of the configuration of SSL on Ubuntu 20.04 (see issue41561). After using custom openssl.cnf I get the same errors. $ OPENSSL_CONF=~/py/openssl.cnf

[issue42794] test_nntplib fails on CI

Dong-hee Na added the comment: I submit the patch to use group_name which is mentioned from https://news.aioe.org/manual/aioe-hierarchy/ IMHO, it will be not changed frequently than what we used before. -- stage: patch review -> ___ Python

[issue42794] test_nntplib fails on CI

Change by Dong-hee Na : -- keywords: +patch pull_requests: +22877 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24037 ___ Python tracker ___

[issue42794] test_nntplib fails on CI

Dong-hee Na added the comment: 4 ways / 2 ways -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42794] test_nntplib fails on CI

Dong-hee Na added the comment: == CPython 3.10.0a3+ (heads/master:c8a7b8fa1b, Jan 1 2021, 08:28:41) [GCC 7.5.0] == Linux-5.4.0-1031-azure-x86_64-with-glibc2.27 little-endian == cwd: /home/corona10/cpython/build/test_python_66899æ == CPU count: 2 == encodings: locale=UTF-8, FS=utf-8 0:00:00 load

[issue42794] test_nntplib fails on CI

Change by Dong-hee Na : -- nosy: +corona10 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue42794] test_nntplib fails on CI

Marc-Andre Lemburg added the comment: FWIW, I'm getting the same errors in PR https://github.com/python/cpython/pull/23140 Checking on the server that's being used, the newsgroup description is empty indeed: https://news.aioe.org/index.php?id=statistics-about-groups=comp.lang.python

[issue42794] test_nntplib fails on CI

Serhiy Storchaka added the comment: On my computer tests are passed. They are only failed on CI. -- ___ Python tracker ___ ___

[issue42794] test_nntplib fails on CI

STINNER Victor added the comment: Right now, it works for me: $ ./python -m test -u all test_nntplib -v -m test_descriptions ... test_descriptions (test.test_nntplib.NNTPv1Tests) ... ok test_descriptions (test.test_nntplib.NNTPv2Tests) ... ok test_descriptions

[issue42794] test_nntplib fails on CI

Ross Rhodes added the comment: Server is returning '215 Newsgroup descriptions in form "group description"', but an empty list of lines, so it's reaching the 'nothing' case in _getdescriptions: https://github.com/python/cpython/blob/master/Lib/nntplib.py#L660 -- nosy: +trrhodes

[issue42794] test_nntplib fails on CI

New submission from Serhiy Storchaka : Since yesterday ALL PRs are blocked by failing test_nntplib. For example https://github.com/python/cpython/runs/1629664606?check_suite_focus=true: == ERROR: test_descriptions