[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Change by Irit Katriel : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Guido van Rossum added the comment: New changeset b798ab06937f8bb24b444a49dd42e11fff15e654 by Irit Katriel in branch 'master': bpo-43146: fix None-handling in single-arg traceback.print_exception(None) (GH-24629)

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Irit Katriel added the comment: The new PR makes it print `NoneType: None`, which is at least consistent with what the same functions do without the Issue26389 shortcut. -- ___ Python tracker

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Change by Irit Katriel : -- pull_requests: +23414 pull_request: https://github.com/python/cpython/pull/24629 ___ Python tracker ___

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Irit Katriel added the comment: > So the remaining question is what to do for print_exception(None)? Yes. > Honestly the current (new) behavior of printing `NoneType: None` seems fine. That's not the current behaviour - I removed that fix from the PR till we agree what to do. Currently we

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Guido van Rossum added the comment: So the remaining question is what to do for print_exception(None)? Honestly the current (new) behavior of printing `NoneType: None` seems fine. -- ___ Python tracker

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Irit Katriel added the comment: The PR just merged fixes the issue that was reported by Florian (what I broke). That impacted pre-3.10 APIs so was an actual regression. The issue with traceback.print_exception(None) is new to 3.10, and was introduced in issue 26389. --

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Guido van Rossum added the comment: So the PR just merged fixes that, right? Color me confused. -- ___ Python tracker ___ ___

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Irit Katriel added the comment: The other thing is not related to the one reported here, but I found it while writing the test for this. We have a new API in 3.10, where you can do traceback.print_exception(ex) (so you don't need to give the whole type,val,tb triplet). But: >>>

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Guido van Rossum added the comment: Are you going to create a separate PR or a new issue for the other thing? (And what exactly *is* the other thing? Please summarize.) -- ___ Python tracker

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Guido van Rossum added the comment: New changeset 26f18b8540b49d592af66361f8df1a03953d1768 by Irit Katriel in branch 'master': bpo-43146: fix regression in traceback.print_exception(None) (GH-24463) https://github.com/python/cpython/commit/26f18b8540b49d592af66361f8df1a03953d1768

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Irit Katriel added the comment: Let's split the print_exception(None) case (new issue) from the regression. I've updated the PR to fix only the latter, which is not controversial. I don't know what print_exception(None) should do. -- ___ Python

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Change by Irit Katriel : -- keywords: +3.10regression ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Irit Katriel added the comment: > I wonder what the rationale was. It isn't because these functions never > raise. I think it's because sys.exc_info() can return None, None, None when there is no exceptions. -- ___ Python tracker

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Miro Hrončok added the comment: JFYI, there are 2 affected Fedora packages (that we know of): visidata fails to build with Python 3.10: AttributeError: 'NoneType' object has no attribute '__suppress_context__' https://bugzilla.redhat.com/show_bug.cgi?id=1928145 python-utils fails to build

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Irit Katriel added the comment: In 3.9 you had to give exc,val,tb. In 3.10 the shortcut was added. Issue 26389. -- ___ Python tracker ___

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Terry J. Reedy added the comment: It seems to me that print_exception(None), etc, *should* raise something. Printing "NoneType: None\n" makes no sense to me since NoneType is not an exception. In 3.9, it raised TypeError for # of arguments. I do note that in 3.9 >>>

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Irit Katriel added the comment: Marking as blocker because these are 3.10 regressions. -- priority: normal -> release blocker ___ Python tracker ___

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Change by Irit Katriel : -- keywords: +patch pull_requests: +23261 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24463 ___ Python tracker ___

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Change by Irit Katriel : -- nosy: +ZackerySpytz, pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Irit Katriel added the comment: There's another such issue due to PR 22610 // issue 26389: >>> traceback.format_exception(None) Traceback (most recent call last): File "", line 1, in File "C:\Users\User\src\cpython-dev\lib\traceback.py", line 128, in format_exception value, tb =

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

Irit Katriel added the comment: Thanks, I’ll add the None check. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue43146] 3.10a5 regression: AttributeError: 'NoneType' object has no attribute '__suppress_context__' in traceback.py

New submission from Florian Bruhin : After upgrading to 3.10a5, calling logging.exception("test") results in: --- Logging error --- Traceback (most recent call last): File "/usr/lib/python3.10/logging/__init__.py", line 1094, in emit msg = self.format(record) File