[issue43155] PyCMethod_New not defined in python3.lib

2021-02-17 Thread STINNER Victor
STINNER Victor added the comment: Thanks Barry for the bug report and thanks Zackery for the fix! It's now fixed. See bpo-43235 and bpo-43239 follow-up issues. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-17 Thread STINNER Victor
STINNER Victor added the comment: New changeset ebe20d9e7eb138c053958bc0a3058d34c6e1a679 by Zackery Spytz in branch '3.9': bpo-43155: Add PyCMethod_New to PC/python3.def (GH-24500) (GH-24554) https://github.com/python/cpython/commit/ebe20d9e7eb138c053958bc0a3058d34c6e1a679 --

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-16 Thread Zackery Spytz
Change by Zackery Spytz : -- pull_requests: +23336 pull_request: https://github.com/python/cpython/pull/24554 ___ Python tracker ___

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-15 Thread STINNER Victor
STINNER Victor added the comment: The symbol was exported on Unix since Python 3.9.0, but not on Windows. Is it ok to export it starting with Python 3.9.2? (backport the fix). IMO yes, it's ok. -- ___ Python tracker

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-15 Thread STINNER Victor
STINNER Victor added the comment: New changeset 8a8b5df93f379f561aab4f2fc5b2ad54f5009f7a by Zackery Spytz in branch 'master': bpo-43155: Add PyCMethod_New to PC/python3dll.c (GH-24500) https://github.com/python/cpython/commit/8a8b5df93f379f561aab4f2fc5b2ad54f5009f7a --

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-15 Thread STINNER Victor
STINNER Victor added the comment: > Is there a test suite that checks that the limited API functions can all be > linked against? Pablo Galindo wrote a new Tools/scripts/stable_abi.py for Unix, but this tool doesn't check PC/python3dll.c yet. The tool uses Doc/data/stable_abi.dat which

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-13 Thread Barry Alan Scott
Barry Alan Scott added the comment: Thanks Petr, I'll watch for the PEP. FYI: I work on the assumption that if I use Py_LIMITED_API and the header files provide an API guarded by an #if then its "offical". -- ___ Python tracker

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-12 Thread Petr Viktorin
Petr Viktorin added the comment: > Is there a test suite that checks that the limited API functions can all be > linked against? Not yet. There's not even consensus about exactly what functions are part of the limited API. I plan to address both issues in PEP 652 (currently in Draft

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-10 Thread Barry Alan Scott
Barry Alan Scott added the comment: Is there a test suite that checks that the limited API functions can all be linked against? -- ___ Python tracker ___

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-10 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch nosy: +ZackerySpytz nosy_count: 1.0 -> 2.0 pull_requests: +23289 stage: -> patch review pull_request: https://github.com/python/cpython/pull/24500 ___ Python tracker

[issue43155] PyCMethod_New not defined in python3.lib

2021-02-07 Thread Barry Alan Scott
New submission from Barry Alan Scott : When using the limited API PyCMethod_New is not defined in python3.lib. This leads to a link error. This error is in 3.9 and 3.10a5 Discovered when I improved the PyCXX test suite. Example output: Link obj\simple.pyd cl /nologo /W4 /LD /Zi /MT