[issue43413] tuple subclasses allow arbitrary kwargs

Serhiy Storchaka added the comment: New changeset ad4857884b4821fc2c9bd23b63d03f9570eb03d1 by Serhiy Storchaka in branch 'main': bpo-43413: Revert changes in set.__init__ (GH-28403) https://github.com/python/cpython/commit/ad4857884b4821fc2c9bd23b63d03f9570eb03d1 --

[issue43413] tuple subclasses allow arbitrary kwargs

Jason R. Coombs added the comment: Oh, and I see now Serhiy has proposed a change that looks reasonable. -- ___ Python tracker ___

[issue43413] tuple subclasses allow arbitrary kwargs

Jason R. Coombs added the comment: >> Subclass of set can now define > Is there any use case for this? Is your concern about a use-case for the general concept or for set specifically? I appreciate that Serhiy has taken the time to evaluate the specific concern I raised and extrapolate it

[issue43413] tuple subclasses allow arbitrary kwargs

Serhiy Storchaka added the comment: I do not have any particular use case. It was a side effect of unification code that uses _PyArg_NoKeywords(). -- ___ Python tracker ___

[issue43413] tuple subclasses allow arbitrary kwargs

Change by Serhiy Storchaka : -- pull_requests: +26815 pull_request: https://github.com/python/cpython/pull/28403 ___ Python tracker ___

[issue43413] tuple subclasses allow arbitrary kwargs

Raymond Hettinger added the comment: > Subclass of set can now define a __new__() method with > additional keyword parameters without overriding also __init__(). Is there any use case for this? Offhand, I can't think of any reason. The new code in set.__init__ is somewhat opaque and is

[issue43413] tuple subclasses allow arbitrary kwargs

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue43413] tuple subclasses allow arbitrary kwargs

Serhiy Storchaka added the comment: New changeset 92bf8691fb78f3484bf2daba836c416efedb1d8d by Serhiy Storchaka in branch 'main': bpo-43413: Fix handling keyword arguments in subclasses of some buitin classes (GH-26456)

[issue43413] tuple subclasses allow arbitrary kwargs

Change by Serhiy Storchaka : -- nosy: +rhettinger ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43413] tuple subclasses allow arbitrary kwargs

Serhiy Storchaka added the comment: Surprisingly there were almost no tests for keyword arguments in subclasses. PR 26456 makes checks for some classes (like tuple, list, frozenset) more strict: if subclass does not define __init__ or __new__, it will reject arbitrary keyword arguments. It

[issue43413] tuple subclasses allow arbitrary kwargs

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +25052 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26456 ___ Python tracker

[issue43413] tuple subclasses allow arbitrary kwargs

Change by Serhiy Storchaka : -- assignee: -> serhiy.storchaka versions: +Python 3.11 -Python 3.10, Python 3.7, Python 3.8, Python 3.9 ___ Python tracker ___

[issue43413] tuple subclasses allow arbitrary kwargs

Change by Brandt Bucher : -- nosy: +brandtbucher ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue43413] tuple subclasses allow arbitrary kwargs

Change by Jason R. Coombs : -- title: tuple subclasses allow kwargs -> tuple subclasses allow arbitrary kwargs ___ Python tracker ___