[issue44114] Incorrect function signatures in dictobject.c

Serhiy Storchaka added the comment: New changeset 925cb85e9e28d69be53db669527c0a1292f0fbfb by Miss Islington (bot) in branch '3.9': bpo-44114: Fix dictkeys_reversed and dictvalues_reversed function signatures (GH-26062) (GH-26093)

[issue44114] Incorrect function signatures in dictobject.c

Change by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44114] Incorrect function signatures in dictobject.c

miss-islington added the comment: New changeset c4c3beb5ad6b55c20b6dc7c6a92860f467afa75b by Miss Islington (bot) in branch '3.10': bpo-44114: Remove redundant cast. (GH-26098) https://github.com/python/cpython/commit/c4c3beb5ad6b55c20b6dc7c6a92860f467afa75b --

[issue44114] Incorrect function signatures in dictobject.c

miss-islington added the comment: New changeset 04c46101944777dd131bbfe8dbfef5f4d328860d by Miss Islington (bot) in branch '3.9': bpo-44114: Remove redundant cast. (GH-26098) https://github.com/python/cpython/commit/04c46101944777dd131bbfe8dbfef5f4d328860d --

[issue44114] Incorrect function signatures in dictobject.c

Change by Antoine Pitrou : -- versions: -Python 3.8 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44114] Incorrect function signatures in dictobject.c

Change by miss-islington : -- pull_requests: +24752 pull_request: https://github.com/python/cpython/pull/26108 ___ Python tracker ___

[issue44114] Incorrect function signatures in dictobject.c

Change by miss-islington : -- pull_requests: +24753 pull_request: https://github.com/python/cpython/pull/26109 ___ Python tracker ___

[issue44114] Incorrect function signatures in dictobject.c

Change by miss-islington : -- pull_requests: +24751 pull_request: https://github.com/python/cpython/pull/26107 ___ Python tracker ___

[issue44114] Incorrect function signatures in dictobject.c

Change by Inada Naoki : -- pull_requests: +24739 pull_request: https://github.com/python/cpython/pull/26098 ___ Python tracker ___

[issue44114] Incorrect function signatures in dictobject.c

miss-islington added the comment: New changeset 7cbe6ca63495d478a3164d6d26ef36cb611a by Miss Islington (bot) in branch '3.10': bpo-44114: Fix dictkeys_reversed and dictvalues_reversed function signatures (GH-26062)

[issue44114] Incorrect function signatures in dictobject.c

Change by Serhiy Storchaka : -- type: behavior -> crash versions: +Python 3.10, Python 3.11, Python 3.8, Python 3.9 ___ Python tracker ___

[issue44114] Incorrect function signatures in dictobject.c

Serhiy Storchaka added the comment: Good catch! The signature of dictkeys_reversed was already fixed (for purity reason), but the same bug in dictvalues_reversed and dictitems_reversed was missed. It is nice that such bugs can now be caught by tools. -- nosy: +serhiy.storchaka

[issue44114] Incorrect function signatures in dictobject.c

Change by miss-islington : -- pull_requests: +24734 pull_request: https://github.com/python/cpython/pull/26094 ___ Python tracker ___

[issue44114] Incorrect function signatures in dictobject.c

Change by miss-islington : -- pull_requests: +24733 pull_request: https://github.com/python/cpython/pull/26093 ___ Python tracker ___

[issue44114] Incorrect function signatures in dictobject.c

Change by miss-islington : -- nosy: +miss-islington nosy_count: 2.0 -> 3.0 pull_requests: +24732 pull_request: https://github.com/python/cpython/pull/26092 ___ Python tracker

[issue44114] Incorrect function signatures in dictobject.c

Change by Ma Lin : -- nosy: +methane ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44114] Incorrect function signatures in dictobject.c

Change by Joe Marshall : -- keywords: +patch pull_requests: +24703 stage: -> patch review pull_request: https://github.com/python/cpython/pull/26062 ___ Python tracker ___

[issue44114] Incorrect function signatures in dictobject.c

New submission from Joe Marshall : There's a couple of wrong function signatures in dictobject.c, dictkeys_reversed and dictitems_reversed are defined as single arg functions like so: PyObject *(PyObject *), and are then passed around and called as PyCFunctions, which should be PyObject