[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

STINNER Victor added the comment: Thanks Irit for making progress on this annoying old C API! -- nosy: +vstinner ___ Python tracker ___

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Łukasz Langa added the comment: Thanks for your input, Pablo. In this case this can safely be closed. Thank you Irit for finding this and providing the PR! ✨  ✨ -- ___ Python tracker

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Change by Łukasz Langa : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Pablo Galindo Salgado added the comment: I prefer to not backport this to 3.10 because technically we cannot introduce new deprecations in an rc and I don't want someone compiling with -Werror to crash between rcs. -- ___ Python tracker

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Łukasz Langa added the comment: This isn't closed yet because we need a decision whether to issue warnings about Py_TRASHCAN_SAFE_BEGIN/END usage in 3.10 as well. This was suggested by Petr here:

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Change by Irit Katriel : -- pull_requests: +26439 pull_request: https://github.com/python/cpython/pull/20104 ___ Python tracker ___

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Change by Jeroen Demeyer : -- nosy: +jdemeyer nosy_count: 4.0 -> 5.0 pull_requests: +26438 pull_request: https://github.com/python/cpython/pull/12607 ___ Python tracker ___

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Łukasz Langa added the comment: New changeset 31ee985db86c1339d00bd0d3cc1712019460670a by Irit Katriel in branch 'main': bpo-44874: deprecate Py_TRASHCAN_SAFE_BEGIN and Py_TRASHCAN_SAFE_END (GH-27693) https://github.com/python/cpython/commit/31ee985db86c1339d00bd0d3cc1712019460670a

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Irit Katriel added the comment: Link to python-dev thread: https://mail.python.org/archives/list/python-...@python.org/message/LWP6MOLP5UW2TH3MROZQK4N64SX35N2B/ -- ___ Python tracker

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Change by Irit Katriel : -- nosy: +petr.viktorin ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Irit Katriel added the comment: Following discussion on python-dev I added a compile-time deprecation warning. With this, and after reverting PR27683 I get the warning below. The build succeeds and the tests pass. % make -s -j2 Objects/frameobject.c:622:5: warning:

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Change by Irit Katriel : -- keywords: +patch pull_requests: +26179 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27693 ___ Python tracker ___

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

Change by Irit Katriel : -- nosy: +lukasz.langa, pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44874] Deprecate Py_TRASHCAN_SAFE_BEGIN/END

New submission from Irit Katriel : The old trashcan macros - Py_TRASHCAN_SAFE_BEGIN/END are unsafe (see Issue40608). They were removed from the limited C API in 3.9: https://github.com/python/cpython/blob/main/Doc/whatsnew/3.9.rst#removed-1 They should be removed altogether, in favour of