[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: Thanks for the PR! This is a good contribution, that wasn't trivial to do. It should be in Python 3.11 alpha 5, so please test it out and make sure it's behaving as you expect. -- resolution: -> fixed stage: patch review -> resolved status: open ->

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: New changeset c47c9e6589eb7a272cfe4d352eb87389eb20ec2f by bneuburg in branch 'main': bpo-44934: Add optional feature AppendPath to Windows MSI installer (GH-27889) https://github.com/python/cpython/commit/c47c9e6589eb7a272cfe4d352eb87389eb20ec2f --

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: Removing environment variables is "known" to be unreliable - another reason I don't like modifying them from an installer. It's meant to remove the item from the list based on value, so if anything has changed then it's not a huge surprise it will fail. I'm

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Bastian Neuburger added the comment: Update: .NET 3.5 installation worked out fine via VS 2019 installer, I also added the VS2017 build tools as a precaution since the VM builds take some time. Afterwards build.bat still failed during wix steps, complaining about missing python.exe in

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: I don't think we upload the artifact from the MSI builds, sorry. If Visual Studio has an option for the older version of .NET, then yeah, that'll do it. But because it was an OS component, you may have to do it through the OS dialog in the link I posted.

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Bastian Neuburger added the comment: Ah ok. Do you know if VS 2019 will do the job at all? I encountered a few (unrelated) projects on github that state they will only build with VS 2017. I will install .NET 3.5 via the VS 2019 installer (should do the trick, right?) and see how it turns

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: Oh I remember this one. The Wix toolset still requires .NET 3.5, which you have to install manually these days. Because it's being launched as a console app, the UI never gets triggered. I thought we had this in the devguide already... but maybe not (or not

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Bastian Neuburger added the comment: Attached is the full output of: - msbuild.exe -version - get_externals.bat - build.bat For the first few build tasks there are git related errors, which make sense since I ran the build from a downloaded zip release of the source instead of a git clone.

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: I kicked off the build on the PR so we can see what errors it finds. Nothing jumps out as obviously wrong in the changes, but it only takes one missing reference to a file to break it all. If you want to share the errors from your test machine, copy-pasting

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Bastian Neuburger added the comment: Steve, I signed the CLA and created the PR, I don't know how long it takes until the info that the CLA is signed is propagated to bpo or github. Regarding failed builds: I will try to build again tomorrow when back at the office and can copy the errors,

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Change by Bastian Neuburger : -- keywords: +patch pull_requests: +26343 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/27889 ___ Python tracker

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: That branch looks like you're on the right track. The build scripts in Tools/msi should Just Work, so I'd be interested to see the error you get. You can also submit it as a PR and the MSI will be built automatically. One thing I noticed is updating the name

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Bastian Neuburger added the comment: Previous URL got "fixed" by roundup, hopefully this one works: https://github.com/python/cpython/compare/16b9be4861e007ad483611ba0479feb2b90ea783...bneuburg:issue44934 -- ___ Python tracker

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Bastian Neuburger added the comment: Maybe this view better shows what I've actually done: https://github.com/python/cpython/compare/16b9be4861e007ad483611ba0479feb2b90ea783...bneuburg:issue44934?expand=1 -- ___ Python tracker

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Bastian Neuburger added the comment: Thanks for the rundown, after digging a little bit into the abyss that is the WIX toolset if you've never dealt with it before I already started going down that route. I pushed it to my fork of cpython:

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: The logic is probably simplest if you clone the Tools/msi/path project entirely as pathappend. That will technically allow people to both prepend and append if they set both flags, but I think it's okay to say "don't do that", especially if AppendPath is only

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Bastian Neuburger added the comment: Hi Steve, Of course there are various reasons for having multiple Python versions on a developer workstation but I would assume that the majority of Windows installer users simple want to run Python projects, at least this holds true for the majority of

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: > why is this confusion not written here >From https://docs.python.org/3/using/windows.html#configuring-python > While the installer provides an option to configure the PATH and PATHEXT > variables for you, this is only reliable for a single, system-wide >

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Sascha added the comment: hi, if you know that it will lead to confusion why is this confusion not written here: https://docs.python.org/3/using/windows.html If you do software deployment in a company you will only have one version so having more than one version is not the point. And if

[issue44934] Windows installer: Append Python to PATH instead of prepending it

Steve Dower added the comment: Prepending is used because it makes the most recently installed version of Python the "active" one. It also ensures that a deliberate install is going to override any applications that may have put their own copy on PATH (deliberately or otherwise). There's no

[issue44934] Windows installer: Append Python to PATH instead of prepending it

New submission from Bastian Neuburger : Hi there, in our organization Python 3.9 is installed on Windows with the PrependPath option; as expected the Install and Scripts directories are prepended to path. However if there are Python scripts with the same name as a system command (e.g. a