[issue45521] obmalloc radix tree typo in code

Change by Neil Schemenauer : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45521] obmalloc radix tree typo in code

Neil Schemenauer added the comment: New changeset 1cdac61065e72db60d26e03ef9286d2743d7000e by Miss Islington (bot) in branch '3.10': bpo-45521: Fix a bug in the obmalloc radix tree code. (GH-29051) (GH-29122) https://github.com/python/cpython/commit/1cdac61065e72db60d26e03ef9286d2743d7000e

[issue45521] obmalloc radix tree typo in code

Change by miss-islington : -- nosy: +miss-islington nosy_count: 2.0 -> 3.0 pull_requests: +27400 pull_request: https://github.com/python/cpython/pull/29122 ___ Python tracker

[issue45521] obmalloc radix tree typo in code

Neil Schemenauer added the comment: New changeset 311910b31a4bd94dc79298388b7cb65ca5546438 by Neil Schemenauer in branch 'main': bpo-45521: Fix a bug in the obmalloc radix tree code. (GH-29051) https://github.com/python/cpython/commit/311910b31a4bd94dc79298388b7cb65ca5546438 --

[issue45521] obmalloc radix tree typo in code

Neil Schemenauer added the comment: I have not yet been able to reproduce methane's crash. My guess it it's not related. An explanation of what I think the impact of this bug is: The radix tree is used to determine if memory is from obmalloc or from the system malloc (i.e return value

[issue45521] obmalloc radix tree typo in code

Change by Neil Schemenauer : -- keywords: +patch pull_requests: +27322 pull_request: https://github.com/python/cpython/pull/29051 ___ Python tracker ___

[issue45521] obmalloc radix tree typo in code

Inada Naoki added the comment: When I am trying to understand this issue, I see this segfault. https://gist.github.com/methane/1b83e2abc6739017e0490c5f70a27b52 I am not sure this segfault is caused by this issue or not. If this is unrelated, I will create another issue. --

[issue45521] obmalloc radix tree typo in code

New submission from Neil Schemenauer : There is a typo in the radix tree obmalloc code, spotted by Inada Naoki. -#define MAP_TOP_MASK (MAP_BOT_LENGTH - 1) +#define MAP_TOP_MASK (MAP_TOP_LENGTH - 1) This should be fixed both in the main branch and in 3.10.x. -- assignee: methane