[issue45571] Modules/makesetup uses wrong CFLAGS for *shared*

Change by Christian Heimes : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45571] Modules/makesetup uses wrong CFLAGS for *shared*

miss-islington added the comment: New changeset 269bf56e3d352c415ec38f93017ba8e291ddb18a by Miss Islington (bot) in branch '3.9': bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) https://github.com/python/cpython/commit/269bf56e3d352c415ec38f93017ba8e291ddb18a --

[issue45571] Modules/makesetup uses wrong CFLAGS for *shared*

miss-islington added the comment: New changeset 19903085c3ad7a17c8047e1556c700f2eb109931 by Miss Islington (bot) in branch '3.10': bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) https://github.com/python/cpython/commit/19903085c3ad7a17c8047e1556c700f2eb109931

[issue45571] Modules/makesetup uses wrong CFLAGS for *shared*

Christian Heimes added the comment: New changeset f6e8b80d20159596cf641305bad3a833bedd2f4f by Christian Heimes in branch 'main': bpo-45571: use PY_CFLAGS_NODIST for shared Modules/Setup (GH-29161) https://github.com/python/cpython/commit/f6e8b80d20159596cf641305bad3a833bedd2f4f --

[issue45571] Modules/makesetup uses wrong CFLAGS for *shared*

Change by miss-islington : -- nosy: +miss-islington nosy_count: 4.0 -> 5.0 pull_requests: +27441 pull_request: https://github.com/python/cpython/pull/29168 ___ Python tracker

[issue45571] Modules/makesetup uses wrong CFLAGS for *shared*

Change by miss-islington : -- pull_requests: +27442 pull_request: https://github.com/python/cpython/pull/29169 ___ Python tracker ___

[issue45571] Modules/makesetup uses wrong CFLAGS for *shared*

Change by Christian Heimes : -- keywords: +patch pull_requests: +27436 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29161 ___ Python tracker

[issue45571] Modules/makesetup uses wrong CFLAGS for *shared*

New submission from Christian Heimes : I think that makesetup uses the wrong CFLAGS variable for shared modules. The script uses PY_CFLAGS: no) cc="$cc \$(CCSHARED) \$(PY_CFLAGS) \$(PY_CPPFLAGS)";; while setup.py uses PY_CFLAGS_NODIST: set_compiler_flags('CFLAGS',