[issue45774] Detect SQLite in configure.ac

Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45774] Detect SQLite in configure.ac

Christian Heimes added the comment: New changeset f1606a5ba50bdc4e7d335d62297b4b4043a25e6e by Erlend Egeberg Aasland in branch 'main': bpo-45774: Harden SQLite detection (GH-30016) https://github.com/python/cpython/commit/f1606a5ba50bdc4e7d335d62297b4b4043a25e6e --

[issue45774] Detect SQLite in configure.ac

Change by Erlend E. Aasland : -- pull_requests: +28240 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/30016 ___ Python tracker ___

[issue45774] Detect SQLite in configure.ac

Erlend E. Aasland added the comment: Reopening: the current detection is a little bit weak; many SQLite API's may be disabled at SQLite compile time using SQLITE_OMIT_* defines. We must make sure we've got all vital functions in place before marking the sqlite3 module as present and usable.

[issue45774] Detect SQLite in configure.ac

Change by Erlend E. Aasland : -- resolution: -> fixed status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing

[issue45774] Detect SQLite in configure.ac

Christian Heimes added the comment: New changeset 6d430ef5ab62158a200b94dff31b89524a9576bb by Erlend Egeberg Aasland in branch 'main': bpo-45774: Fix SQLite load extension autodetection (GH-29659) https://github.com/python/cpython/commit/6d430ef5ab62158a200b94dff31b89524a9576bb --

[issue45774] Detect SQLite in configure.ac

Erlend E. Aasland added the comment: > Awesome work! Thanks to your tireless effort we know have a blue print how to > use pkg-config for other librariess. Thank you for reviewing, and thank you for paving the way with all these build system improvements :) --

[issue45774] Detect SQLite in configure.ac

Erlend E. Aasland added the comment: Needs amendment before closing. See GH-29659. -- resolution: fixed -> status: closed -> open ___ Python tracker ___

[issue45774] Detect SQLite in configure.ac

Change by Erlend E. Aasland : -- pull_requests: +27901 pull_request: https://github.com/python/cpython/pull/29659 ___ Python tracker ___

[issue45774] Detect SQLite in configure.ac

Christian Heimes added the comment: Awesome work! Thanks to your tireless effort we know have a blue print how to use pkg-config for other librariess. -- type: -> enhancement ___ Python tracker

[issue45774] Detect SQLite in configure.ac

Change by Erlend E. Aasland : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue45774] Detect SQLite in configure.ac

Christian Heimes added the comment: New changeset 29e5874d5a9205c488f783356d0cf3f115399327 by Erlend Egeberg Aasland in branch 'main': bpo-45774: Autoconfiscate SQLite detection (GH-29507) https://github.com/python/cpython/commit/29e5874d5a9205c488f783356d0cf3f115399327 --

[issue45774] Detect SQLite in configure.ac

Christian Heimes added the comment: I saw your message concerning sqlite3 on the FreeBSD buildbot. It's hard to tell why configure on FreeBSD doesn't find sqlite3.h without access to config.log or a shell. Maybe sqlite3 is installed in /usr/local ? ``configure`` does not use

[issue45774] Detect SQLite in configure.ac

Erlend E. Aasland added the comment: Nice. I think I'll steal some of your ideas tomorrow :) -- ___ Python tracker ___ ___

[issue45774] Detect SQLite in configure.ac

Christian Heimes added the comment: Your solution looks very similar to my WIP patch: AC_CHECK_HEADERS([sqlite3.h], [AC_SEARCH_LIBS([sqlite3_version], [sqlite3])] ) AS_VAR_IF([ac_cv_search_sqlite3_version], [no], [], [ # found a working sqlite3.h and sqlite3 library #

[issue45774] Detect SQLite in configure.ac

Change by Erlend E. Aasland : -- keywords: +patch pull_requests: +27758 stage: -> patch review pull_request: https://github.com/python/cpython/pull/29507 ___ Python tracker

[issue45774] Detect SQLite in configure.ac

New submission from Erlend E. Aasland : "Autoconfiscate" SQLite detection. Plan: - Detect header/library using AC_CHECK_HEADERS/AC_CHECK_LIB - Check required version using AC_COMPILE_IFELSE - Use AC_CHECK_LIB to check if sqlite3_load_extension is present, and if the result harmonises with