[issue46198] Duplicate and unused code in tests

Change by Alex Waygood : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___ ___

[issue46198] Duplicate and unused code in tests

Jelle Zijlstra added the comment: New changeset 4199b7ffbbaa5fe52a4c85c8672ac6773a75ba8f by Jelle Zijlstra in branch '3.10': [3.10] bpo-46198: rename duplicate tests and remove unused code (GH-30297) (GH-31796)

[issue46198] Duplicate and unused code in tests

Jelle Zijlstra added the comment: New changeset 4052dd2296da2ff304b1fa787b100befffa1c9ca by Alex Waygood in branch 'main': bpo-46198: Fix `test_asyncio.test_sslproto` (GH-31801) https://github.com/python/cpython/commit/4052dd2296da2ff304b1fa787b100befffa1c9ca --

[issue46198] Duplicate and unused code in tests

Jelle Zijlstra added the comment: New changeset f7f7838b41d45efa129a61f104136f8e12f3488a by Jelle Zijlstra in branch '3.9': [3.9] bpo-46198: rename duplicate tests and remove unused code (GH-30297) (GH-31797) https://github.com/python/cpython/commit/f7f7838b41d45efa129a61f104136f8e12f3488a

[issue46198] Duplicate and unused code in tests

Change by Alex Waygood : -- nosy: +AlexWaygood nosy_count: 3.0 -> 4.0 pull_requests: +29902 pull_request: https://github.com/python/cpython/pull/31801 ___ Python tracker ___

[issue46198] Duplicate and unused code in tests

Change by Jelle Zijlstra : -- pull_requests: +29900 pull_request: https://github.com/python/cpython/pull/31797 ___ Python tracker ___

[issue46198] Duplicate and unused code in tests

Change by Jelle Zijlstra : -- pull_requests: +29899 pull_request: https://github.com/python/cpython/pull/31796 ___ Python tracker ___

[issue46198] Duplicate and unused code in tests

Jelle Zijlstra added the comment: New changeset 6c83c8e6b56b57a8a794e7b6c07837be4ce3bb97 by Nikita Sobolev in branch 'main': bpo-46198: rename duplicate tests and remove unused code (GH-30297) https://github.com/python/cpython/commit/6c83c8e6b56b57a8a794e7b6c07837be4ce3bb97 --

[issue46198] Duplicate and unused code in tests

Nikita Sobolev added the comment: > I think most of these are false positives Yes, they are! Please, check out my PR: https://github.com/python/cpython/pull/30297 сб, 1 янв. 2022 г. в 21:52, Éric Araujo : > > Éric Araujo added the comment: > > I think most of these are false positives (it’s

[issue46198] Duplicate and unused code in tests

Éric Araujo added the comment: I think most of these are false positives (it’s fine if 10 different tests define a function `f`), so should not be changed just to appease a lint tool. Others are genuine! -- ___ Python tracker

[issue46198] Duplicate and unused code in tests

Nikita Sobolev added the comment: Thanks! I will also attach all `flake8`'s output if someone is going to need it: ``` » flake8 --select=F811 Lib/test Lib/test/test_descr.py:1165:13: F811 redefinition of unused 'C' from line 1158 Lib/test/test_descr.py:1172:13: F811 redefinition of unused 'C'