[issue46427] Correct MSBuild's configuration for _freeze_module.exe

2022-01-21 Thread Steve Dower
Steve Dower added the comment: Windows ARM64 devices all support x86 and x64 emulation, so while it's less than ideal performance-wise to use a non-native build for this step, it's hardly fatal. That step doesn't rely on the underlying architecture, just the current Python bytecode format

[issue46427] Correct MSBuild's configuration for _freeze_module.exe

2022-01-20 Thread neonene
neonene added the comment: > + This is bad if ARM64 machine takes the blank value as not "ARM64" but "ARM", as "ARM" tools are not necessary to install. Then, I agree with the proposal of the OP (PR28491) below: > Would it be acceptable if a new host platform property is added to >

[issue46427] Correct MSBuild's configuration for _freeze_module.exe

2022-01-20 Thread neonene
neonene added the comment: > When cross-compiling, tools that are executed as part of the build need to be > built for the tool platform, not the target platform. My PR does not against that at this point, as proposed codes are based on your PR28322

[issue46427] Correct MSBuild's configuration for _freeze_module.exe

2022-01-20 Thread Steve Dower
Steve Dower added the comment: This configuration is intentional. When cross-compiling, tools that are executed as part of the build need to be built for the tool platform, not the target platform. -- nosy: +steve.dower resolution: -> not a bug stage: patch review -> resolved

[issue46427] Correct MSBuild's configuration for _freeze_module.exe

2022-01-18 Thread neonene
neonene added the comment: Defenition in general_advanced.xml These options above are corresponded to the following folders in my case: Microsoft Visual Studio\.\VC\Tools\MSVC\\bin\Hostx86 Microsoft Visual Studio\.\VC\Tools\MSVC\\bin\Hostx64 And

[issue46427] Correct MSBuild's configuration for _freeze_module.exe

2022-01-18 Thread neonene
neonene added the comment: >This also rolls _freeze_module.exe's architecture back to x64 Correcting: from x86 back to x64 In my recognition, only Win32 _freeze_module.exe is built currently and run on non-ARM machines to generate the code for Win32/x64/ARM/ARM64 targets. --

[issue46427] Correct MSBuild's configuration for _freeze_module.exe

2022-01-18 Thread neonene
Change by neonene : -- keywords: +patch pull_requests: +28873 stage: -> patch review pull_request: https://github.com/python/cpython/pull/30673 ___ Python tracker ___

[issue46427] Correct MSBuild's configuration for _freeze_module.exe

2022-01-18 Thread neonene
New submission from neonene : In pcbuild.proj, "PreferredToolArchitecture" property looks misused, which I think is useful giving us two selections of a compiler (32bit or 64bit) for any target architecture (Win32/x64/ARM/ARM64). I think the property can be unused there. This means a partial