[issue46712] Share global string identifiers in deepfreeze

Change by Kumar Aditya : -- pull_requests: +30230 pull_request: https://github.com/python/cpython/pull/32152 ___ Python tracker ___

[issue46712] Share global string identifiers in deepfreeze

Eric Snow added the comment: New changeset febf54bcf3fdc45ad84b4073e24bbaaee0ac8b2a by Eric Snow in branch 'main': bpo-46712: Do not Regen Deep-Frozen Modules before Generating Global Objects (gh-32061) https://github.com/python/cpython/commit/febf54bcf3fdc45ad84b4073e24bbaaee0ac8b2a

[issue46712] Share global string identifiers in deepfreeze

Change by Eric Snow : -- pull_requests: +30151 pull_request: https://github.com/python/cpython/pull/32061 ___ Python tracker ___

[issue46712] Share global string identifiers in deepfreeze

Eric Snow added the comment: > After a new `&_Py_ID(__orig_class__)` is added to > Objects/genericaliasobject.c, running `make regen-global-objects` starts > > gcc -pthread -c [snipped] -DPy_BUILD_CORE -o Objects/genericaliasobject.o > Objects/genericaliasobject.c > > which fails with a

[issue46712] Share global string identifiers in deepfreeze

Dennis Sweeney added the comment: In bpo-47067, there was concern about the addition of the makefile target from PR 31637: regen-global-objects: regen-deepfreeze After a new `&_Py_ID(__orig_class__)` is added to Objects/genericaliasobject.c, running `make regen-global-objects` starts

[issue46712] Share global string identifiers in deepfreeze

Eric Snow added the comment: New changeset 21099fc064c61d59c936a2f6a0db3e07cd5c8de5 by Eric Snow in branch 'main': bpo-46712: Let generate_global_objects.py Run on Earlier Python Versions (gh-31637) https://github.com/python/cpython/commit/21099fc064c61d59c936a2f6a0db3e07cd5c8de5

[issue46712] Share global string identifiers in deepfreeze

Change by Eric Snow : -- pull_requests: +29759 pull_request: https://github.com/python/cpython/pull/31637 ___ Python tracker ___

[issue46712] Share global string identifiers in deepfreeze

Change by Kumar Aditya : -- pull_requests: +29718 pull_request: https://github.com/python/cpython/pull/31596 ___ Python tracker ___

[issue46712] Share global string identifiers in deepfreeze

Change by Guido van Rossum : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> resource usage ___ Python tracker ___

[issue46712] Share global string identifiers in deepfreeze

Guido van Rossum added the comment: New changeset eb002dbe0da9622245a355db5f0cd5aa2fc70b40 by Kumar Aditya in branch 'main': bpo-46712: Share global string identifiers in deepfreeze (GH-31261) https://github.com/python/cpython/commit/eb002dbe0da9622245a355db5f0cd5aa2fc70b40 --

[issue46712] Share global string identifiers in deepfreeze

Change by Kumar Aditya : -- keywords: +patch pull_requests: +29427 stage: -> patch review pull_request: https://github.com/python/cpython/pull/31261 ___ Python tracker ___

[issue46712] Share global string identifiers in deepfreeze

Kumar Aditya added the comment: I have refactored generate_global_objects.py, and now instead of hard-coding every identifier manually, it now scans *.c files extracts the identifiers used in it and then generate the header file. This has multiple advantages: - No need to manually add

[issue46712] Share global string identifiers in deepfreeze

New submission from Kumar Aditya : Since bpo-46541, the global strings are statically allocated so they can now be referenced by deep-frozen modules just like any other singleton. Sharing identifiers with deepfreeze will reduce the duplicated strings hence it would save space. See