Mattelaer olivier.mattel...@uclouvain.be added the comment:
Thanks a lot for the fix.
On 02-août-10, at 01:58, R. David Murray wrote:
R. David Murray rdmur...@bitdance.com added the comment:
Thanks, Éric. Fixed.
--
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
Universal newline mode helps when reading from stdin, but what I had in mind
was actually Enter in cmd.exe putting CRLF. Re-reading the original report, I
see this is not a concern, since the bug is about cmd used with a file only,
not
Éric Araujo mer...@netwok.org added the comment:
If “l” sorts after “a”, you’ve misplaced Catherine in ACKS. Funny how often
this happens :)
(Cheers for the Teach Me session by the way Catherine!)
--
___
Python tracker rep...@bugs.python.org
R. David Murray rdmur...@bitdance.com added the comment:
Thanks, Éric. Fixed.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8620
___
___
Changes by R. David Murray rdmur...@bitdance.com:
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8620
___
___
Python-bugs-list mailing list
R. David Murray rdmur...@bitdance.com added the comment:
Here is a unit test that demonstrates the problem (against py3k trunk). I'm
not convinced that fixing this would be backward incompatible.
--
___
Python tracker rep...@bugs.python.org
Catherine Devlin fredv8vi...@liquidid.net added the comment:
Patch created live during PyOhio 2010 Teach Me Python Bugfixing session!
--
nosy: +catherine
Added file: http://bugs.python.org/file18294/cmd-noeol-test.fix.patch
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
Test runs okay on posix (linux2). Does the fix need to work with '\r\n' too?
Aside: Your patch has trailing spaces, you can spot them with good editor
settings.
--
___
Python tracker
Éric Araujo mer...@netwok.org added the comment:
Sorry, RDM is the actual culprit ;)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8620
___
___
Catherine Devlin fredv8vi...@liquidid.net added the comment:
same patch, stripped of trailing spaces
--
Added file: http://bugs.python.org/file18297/cmd-noeol-test.fix.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8620
R. David Murray rdmur...@bitdance.com added the comment:
Éric: thanks for spotting the whitespace before I got smacked by the commit
hook. As for \r\n, our thought was that would be a feature (universal newline
support), but upon reflection the current fix could actually break working code
R. David Murray rdmur...@bitdance.com added the comment:
Here is a unit test that demonstrates the problem (against py3k trunk). I'm
not convinced that fixing this would be backward incompatible.
(NB: please no one patch this bug, I'm expecting the patch to get created
tomorrow during
Changes by R. David Murray rdmur...@bitdance.com:
Removed file: http://bugs.python.org/file18280/cmd-noeol-test.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8620
___
Changes by R. David Murray rdmur...@bitdance.com:
Added file: http://bugs.python.org/file18281/cmd-noeol-test.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue8620
___
Éric Araujo mer...@netwok.org added the comment:
Setting version to 3.2, since this change would not be backward compatible and
2.7 is already in beta.
--
components: +Library (Lib) -None
nosy: +merwok
title: wrong truncation of line in Cmd.cmd - wrong truncation of last line in
15 matches
Mail list logo