Roundup Robot added the comment:
New changeset 6db349fac3ec by Terry Jan Reedy in branch 'default':
Issue #9232: Escape rst markup char in NEWS entry to avoid Sphinx warning.
https://hg.python.org/cpython/rev/6db349fac3ec
--
___
Python tracker
Guido van Rossum added the comment:
To be explicit, yes, I want to allow trailing comma even after *args or **kwds.
And that's what the patch does.
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
Larry Hastings added the comment:
With PEP 448, we can now have
fronkulate(**kwargs, **kwargs2)
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
Adam Bartoš added the comment:
Some remarks:
• A trailing comma after a non-empty argument list is allowed in every call
form, including class statement and optional call in decorator syntax. In the
grammar, this correponds to `arglist`.
• In function definition, trailing comma is allowed
Guido van Rossum added the comment:
I'm +1 on adding this. I don't believe it requires a PEP. A trailing comma in
definitions is already supported in some places, so I don't buy the argument
that it catches errors. During the moratorium we were perhaps too strict.
--
nosy: +gvanrossum
Robert Collins added the comment:
The patch had some conflicts in the reference docs, I think I resolved it
correctly: if someone wanted to cross check my work that would be great.
However I was feeling (perhaps wrongly :)) confident so I have committed it
as-is.
--
resolution: -
Adam Bartoš added the comment:
Do we want to allow a trailing comma after *args or **kwargs in a function
definition? Unlike in a call, **kwargs is always the last thing in the list and
nothing can be added after that. Just asking.
--
___
Python
Roundup Robot added the comment:
New changeset 419ceb531bab by Robert Collins in branch 'default':
Issue #9232: Support trailing commas in function declarations.
https://hg.python.org/cpython/rev/419ceb531bab
--
nosy: +python-dev
___
Python tracker
Robert Collins added the comment:
FWIW I would like to see this, but I think it does need a PEP given the
contention so far. For that, we need a BDFL delegate AIUI.
--
nosy: +rbcollins
versions: +Python 3.6 -Python 3.5
___
Python tracker
Adam Bartoš added the comment:
Reposting from from my newest duplicate of this issue (Issue 24677), which is
now closed:
I think that a trailing comma in function definition should be allowed also
after *.
Current situation with definitions:
def f(*args, ): pass # SyntaxError
def f(*, ):
Grégory Starck added the comment:
Have also been confronted to this bug (imo) and this happen from time to time
to me :
I often like to ends my (big) functions defs and calls (those that span over
multiple lines thus..) with that extra comma,
so that when/if I add another argument (on a
Martin Panter added the comment:
Actual post by Raymond:
https://mail.python.org/pipermail/python-dev/2010-December/106790.html
Just noticed there are some arguments for trailing commas in the FAQ:
Alexander Belopolsky added the comment:
.. and a couple more -1's on the tracker:
msg123851 - Martin v. Löwis
msg123848 - Brett Cannon
It looks like a round on python-ideas is needed before this can move forward.
--
___
Python tracker
Alexander Belopolsky added the comment:
It looks like if it was not for Raymond's mild dissent, [1], we would
have a consensus last time this was raised on python-dev, [2-7].
[1] -? Raymond Hettinger
https://mail.python.org/pipermail/python-dev/2010-December/106782.html
[2] +0 Guido van Rossum
Martin Panter added the comment:
See also Issue 22942 about existing problems with the language documentation.
I would like to see trailing commas supported consistently, especially in
function calls. (I think the patch here only does function definitions?) I like
to use them when writing
Larry Hastings added the comment:
Moratorium's long over. Will this patch rise from the dead?
--
nosy: +larry
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
Mark Dickinson added the comment:
Will this patch rise from the dead?
It's really down to getting consensus that it's a good idea. That might
require another python-dev discussion.
--
___
Python tracker rep...@bugs.python.org
Changes by Phil Connell pconn...@gmail.com:
--
nosy: +pconnell
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
___
Python-bugs-list mailing
Changes by Martin Panter vadmium...@gmail.com:
--
nosy: +vadmium
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
___
Python-bugs-list
Changes by Yury Selivanov yselivanov...@gmail.com:
--
versions: +Python 3.5 -Python 3.3
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
___
Changes by Mark Dickinson dicki...@gmail.com:
--
assignee: mark.dickinson -
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
___
Changes by Jan Kaliszewski z...@chopin.edu.pl:
--
nosy: +zuo
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
___
Python-bugs-list mailing
Alexander Belopolsky belopol...@users.sourceforge.net added the comment:
In #10682, several committers indicated that they would prefer
not to change this.
Issue #10682 has been open for less than 24 hours before it was rejected. In
contrast, this issue was open after an almost week-long
Martin v. Löwis mar...@v.loewis.de added the comment:
I stand by my evaluation: there is clearly no consensus about this change, so
it certainly requires more discussion, potentially leading to proponents being
asked to write a PEP.
--
___
Python
Nick Coghlan ncogh...@gmail.com added the comment:
An open issue more accurately reflects the lack of consensus than a closed one,
though. We just won't commit it until there *is* consensus that it is a better
option than the status quo.
--
keywords: +after moratorium -patch
Nick Coghlan ncogh...@gmail.com added the comment:
From 10682: the grammar is also inconsistent as to when trailing commas are
allowed in function calls, not just definitions.
--
___
Python tracker rep...@bugs.python.org
Changes by Eric Smith e...@trueblade.com:
--
nosy: +eric.smith
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
___
Python-bugs-list mailing
Jan Kaliszewski z...@chopin.edu.pl added the comment:
From 10682: The patch proposed in this (#9232) issue does not fix call syntax
but def sytax only. I think it should fix call sytax as well (see code
examples in #10682).
--
___
Python tracker
Jan Kaliszewski z...@chopin.edu.pl added the comment:
python-dev discussion continuation:
http://mail.python.org/pipermail/python-dev/2010-December/106770.html
--
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
Changes by Andreas Stührk andy-pyt...@hammerhartes.de:
--
nosy: +Trundle
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
___
Changes by Nick Coghlan ncogh...@gmail.com:
--
stage: needs patch - commit review
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
___
Martin v. Löwis mar...@v.loewis.de added the comment:
In #10682, several committers indicated that they would prefer not to change
this. So I'm closing this as rejected. Per convention, it would probably
require a PEP to modify Python in this aspect (as there is no clear consensus).
Martin v. Löwis mar...@v.loewis.de added the comment:
Retargetting, as this falls under the moratorium, and also because 3.2b1 has
been released.
--
nosy: +loewis
versions: +Python 3.3 -Python 3.2
___
Python tracker rep...@bugs.python.org
Mark Dickinson dicki...@gmail.com added the comment:
There was one place that needed to be changed in ast.c: namely, the check to
make sure that there are keyword-only arguments following a bare star.
Here's a new patch, that fixes that issue, updates the grammar in the ast.c
comment to
Changes by Mark Dickinson dicki...@gmail.com:
Added file: http://bugs.python.org/file18129/trailing_commas2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
Changes by Mark Dickinson dicki...@gmail.com:
Removed file: http://bugs.python.org/file18127/trailing_commas2.patch
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
Changes by Mark Dickinson dicki...@gmail.com:
--
assignee: - mark.dickinson
___
Python tracker rep...@bugs.python.org
http://bugs.python.org/issue9232
___
___
Mark Dickinson dicki...@gmail.com added the comment:
No, I'm not sure. :) I'll double check.
So I'm looking at ast_for_arguments and handle_keywordonly_args in ast.c. As
far as I can tell, that's the only relevant bit; is there anywhere else I
should be checking?
--
New submission from Mark Dickinson dicki...@gmail.com:
Python's current grammar allows a trailing comma after the argument list in:
def f(a, b,):
pass
but not in
def f(*, a, b,):
pass
I propose allowing trailing commas in both situations.
See python-dev discussion starting at
Mark Dickinson dicki...@gmail.com added the comment:
Here's a patch. I've checked with PEP 306, but besides changing Grammar,
test_grammar.py and the parser module (which there's a separate issue open
for), I don't think any other changes are required.
--
keywords: +patch
Added file:
Nick Coghlan ncogh...@gmail.com added the comment:
I take it the AST generation just throws the extra comma away? You're sure this
doesn't upset any of the node counts in that stage of the compiler?
--
nosy: +ncoghlan
___
Python tracker
41 matches
Mail list logo
