[issue20021] "modernize" makeopcodetargets.py

2016-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Thank you Victor. -- resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker ___

[issue26644] SSLSocket.recv(-1) triggers SystemError

2016-03-26 Thread Martin Panter
New submission from Martin Panter: SystemError indicates an internal error that is not supposed to be triggerable from Python code. We should probably raise ValueError like plain sockets instead. >>> s = create_connection(("python.org", 443)) >>> s.recv(-1) Traceback (most recent call last):

[issue25911] Regression: os.walk now using os.scandir() breaks bytes filenames on windows

2016-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Some tests were failed on Windows 8 even in 3.4 (issue23808). -- ___ Python tracker ___

[issue11245] Implementation of IMAP IDLE in imaplib?

2016-03-26 Thread Rob la Lau
Changes by Rob la Lau : -- nosy: +ohreally ___ Python tracker ___ ___

[issue19829] _pyio.BufferedReader and _pyio.TextIOWrapper destructor don't emit ResourceWarning if the file is not closed

2016-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Serhiy: why did you add 2.7 to this bug? For 2.7, I don’t think anything > should be done. There is no ResourceWarning in 2.7. Just for the case. Not calling close() in __del__() is one option, and it looks attractive. But there are possible hidden

[issue26644] SSLSocket.recv(-1) triggers SystemError

2016-03-26 Thread Martin Panter
Martin Panter added the comment: Proposed patch -- keywords: +patch stage: -> patch review Added file: http://bugs.python.org/file42295/ssl-negative.patch ___ Python tracker

[issue25987] collections.abc.Reversible

2016-03-26 Thread Ivan Levkivskyi
Changes by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker ___ ___

[issue26643] regrtest: rework libregrtest.save_env submodule

2016-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > I replaced get_sys_path()/restore_sys_path() (2 methods) with > ModuleAttr.get()+ModuleAttrList.encode_value() / > ModuleAttr.restore()+ModuleAttrList.restore_attr() (4 methods). I need to examine all other methods scattered around just to conclude that

[issue26645] argparse prints help messages to stdout instead of stderr by default

2016-03-26 Thread SilentGhost
Changes by SilentGhost : -- nosy: +bethard versions: +Python 3.6 -Python 3.5 ___ Python tracker ___

[issue26645] argparse prints help messages to stdout instead of stderr by default

2016-03-26 Thread Alexey Muranov
New submission from Alexey Muranov: I believe that printing help and usage messages to stdout is a design error. In stdout i expect to find the output of my program, not help or diagnostic messages. It is strange to see nothing printed on the screen (where stderr usually goes), and then to

[issue26645] argparse prints help messages to stdout instead of stderr by default

2016-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: `grep --help` outputs to stdout. `grep -h` outputs to stderr, because this is error, there is no the `-h` flag. The same for git and most other command line tools. argparse follows this behavior. There is no bug. -- nosy: +serhiy.storchaka

[issue26646] Allow built-in module in package

2016-03-26 Thread Daniel Shaulov
New submission from Daniel Shaulov: Hi, I was trying to build a python interpreter that has the cpp part of msgpack as a built-in module. I thought that I could just copy the msgpack folder to the Modules folder and add this 2 lines to Modules/Setup.local: msgpack._packer msgpack/_packer.cpp

[issue26646] Allow built-in module in package

2016-03-26 Thread Daniel Shaulov
Changes by Daniel Shaulov : Added file: http://bugs.python.org/file42298/importlib_h.patch ___ Python tracker ___

[issue26645] argparse prints help messages to stdout instead of stderr by default

2016-03-26 Thread Alexey Muranov
Alexey Muranov added the comment: Thanks for the explanation, this makes sense. I did not notice that argparse outputs to stderr if command line arguments are wrong, i was probably wrong when said it prints error messages to stdout. I did not notice indeed that there were no `-h` option in

[issue26644] SSLSocket.recv(-1) triggers SystemError

2016-03-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: Is this what other file-like objects do with negatives sizes? -- nosy: +benjamin.peterson ___ Python tracker ___

[issue26644] SSLSocket.recv(-1) triggers SystemError

2016-03-26 Thread Martin Panter
Martin Panter added the comment: Thanks for the reviews. Here is a patch that avoids breaking read(-1, buffer). -- Added file: http://bugs.python.org/file42299/ssl-negative.v2.patch ___ Python tracker

[issue26644] SSLSocket.recv(-1) triggers SystemError

2016-03-26 Thread Martin Panter
Martin Panter added the comment: Socket objects aren’t exactly file-like. Plain non-SSL sockets don’t even have read() methods. I think giving a meaning to recv(-1) would be an (unwanted) new feature, rather than a bug fix. If you want a file-like object linked to a socket, I would suggest

[issue26647] Wordcode

2016-03-26 Thread Demur Rumed
New submission from Demur Rumed: Originally started @ https://github.com/abarnert/cpython/tree/wpy This patch is based off of https://github.com/serprex/cpython/tree/wpy It omits importlib.h & importlib_external.h as those are generated It omits

[issue26644] SSLSocket.recv(-1) triggers SystemError

2016-03-26 Thread Benjamin Peterson
Benjamin Peterson added the comment: Thanks for the explanation. Your patch lgtm. On Sat, Mar 26, 2016, at 15:01, Martin Panter wrote: > > Martin Panter added the comment: > > Socket objects aren’t exactly file-like. Plain non-SSL sockets don’t even > have read() methods. > > I think giving

[issue22898] segfault during shutdown attempting to log ResourceWarning

2016-03-26 Thread Xavier de Gaye
Xavier de Gaye added the comment: Victor, With warn_5.patch *filename is not set when globals is NULL: setup_context() returns 0, and so do_warn() returns NULL without calling warn_explicit(). This is different from your initial warn.patch where setup_context() returns 1 in that case and an

[issue26587] Possible duplicate entries in sys.path if .pth files are used with zip's

2016-03-26 Thread Wolfgang Langner
Wolfgang Langner added the comment: Ok, I implemented point 3. Check if it is a dir or file and makepath only in this case. All other entries are added unmodified to the set. Added a test case also for an URL path. I think duplicate detection is now improved and it should break nothing.

[issue26587] Possible duplicate entries in sys.path if .pth files are used with zip's

2016-03-26 Thread Brett Cannon
Changes by Brett Cannon : -- assignee: -> brett.cannon ___ Python tracker ___ ___

[issue26644] SSLSocket.recv(-1) triggers SystemError

2016-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- assignee: -> martin.panter nosy: +serhiy.storchaka stage: patch review -> commit review ___ Python tracker

[issue22854] Documentation/implementation out of sync for IO

2016-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- assignee: -> martin.panter stage: patch review -> commit review ___ Python tracker ___

[issue25940] SSL tests failed due to expired svn.python.org SSL certificate

2016-03-26 Thread Martin Panter
Martin Panter added the comment: Okay so for the record, the maintainence branches were changed over from svn.python.org to self-signed.pythontest.net, and just now I changed the 3.6 branch to use a local server for most tests. -- resolution: -> fixed stage: patch review -> resolved

[issue22854] Documentation/implementation out of sync for IO

2016-03-26 Thread Martin Panter
Martin Panter added the comment: Okay let’s document fileno(), read, write and seek operations in the base classes as raising OSError then. This effectively rejects the OP (Stanislaw’s) view that the exception should be more specific. In patch v3, I changed everything over to say OSError is

[issue26648] csv.reader Error message indicates to use deprecated

2016-03-26 Thread Philip Martin
New submission from Philip Martin: Currently, the error message: _csv.Error: new-line character seen in unquoted field - do you need to open the file in universal-newline mode? is cryptic in that universal line mode has been deprecated, and will not run in Python 3.5., i.e.:

[issue25940] SSL tests failed due to expired svn.python.org SSL certificate

2016-03-26 Thread Roundup Robot
Roundup Robot added the comment: New changeset 3da812602881 by Martin Panter in branch 'default': Issue #25940: Use internal local server more in test_ssl https://hg.python.org/cpython/rev/3da812602881 -- ___ Python tracker

[issue23735] Readline not adjusting width after resize with 6.3

2016-03-26 Thread Eric Price
Eric Price added the comment: Well, I could piggyback on the existing flags if I just wanted to support readline -- there are already two flags for readline 4.0 -- but if our real goal is to be compatible with editline, we probably need another flag. I think you're right that it should

[issue26645] argparse prints help messages to stdout instead of stderr by default

2016-03-26 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Does FreeBSD grep support the `--help` option? Long options is GNU extension, classical UNIX commands supported only short options. -- ___ Python tracker

[issue26649] Fail update installation: 'utf-8' codec can't decode

2016-03-26 Thread q20611...@163.com
New submission from q20611...@163.com: This error occureed on the gns3 ; give you the errorlog files . -- files: gns3-errorlog messages: 262510 nosy: shanzhengcheng priority: normal severity: normal status: open title: Fail update installation: 'utf-8' codec can't decode versions: