[issue32657] Mutable Objects in SMTP send_message Signature

Chason Chaffin added the comment: I'm writing a PR for this right now. Is it worth it to write a test to make sure that mail_options isn't being mutated or is it enough just to update the code to use non-mutable defaults? Interesting side effect of looking into this is

[issue32640] Python 2.7 str.join documentation is incorrect

Mariatta Wijaya added the comment: GH-5333 clarifies that str.join can return a Unicode object if iterable contains a Unicode object, and that it will raise TypeError if there is any non string or non unicode object. --

[issue32640] Python 2.7 str.join documentation is incorrect

Change by Mariatta Wijaya : -- keywords: +patch pull_requests: +5179 stage: needs patch -> patch review ___ Python tracker

[issue32672] .then execution of actions following a future's completion

R. David Murray added the comment: I think this requires a discussion on the python-ideas mailing list, since API changes to Future need consideration in the asyncio context as well. -- components: +Library (Lib) -Interpreter Core nosy: +r.david.murray type: ->

[issue29237] Create enum for pstats sorting options

Ethan Furman added the comment: New changeset 863b1e4d0e95036bca4e97c1b8b2ca72c19790fb by Ethan Furman (mwidjaja) in branch 'master': bpo-29237: Create enum for pstats sorting options (GH-5103)

[issue32673] update tutorial dict part to reflect dict is ordered

New submission from Xiang Zhang : Ordered builtin dict is the rule in 3.7, the tutorial part about dict[1] needs updating. [1] https://docs.python.org/3.7/tutorial/datastructures.html#dictionaries -- assignee: docs@python components: Documentation messages: 310737

[issue27931] Email parse IndexError <""@wiarcom.com>

Change by Xiang Zhang : -- type: -> behavior versions: +Python 3.7 -Python 3.5 ___ Python tracker ___

[issue32674] minor documentation fix for '__import__'

Stéphane Wirtel added the comment: minor documentation? I don't understand, the documentation of __import__ is well done, could you explain ? https://docs.python.org/3/library/functions.html#__import__ thank you -- nosy: +matrixise

[issue32571] Speed up and clean up getting optional attributes in C code

INADA Naoki added the comment: New changeset e76daebc0c8afa3981a4c5a8b54537f756e805de by INADA Naoki in branch 'master': bpo-32571: Fix reading uninitialized memory (GH-5332) https://github.com/python/cpython/commit/e76daebc0c8afa3981a4c5a8b54537f756e805de --

[issue32673] update tutorial dict part to reflect dict is ordered

Xiang Zhang added the comment: Thanks for reminding, Martin. -- resolution: -> duplicate stage: needs patch -> resolved status: open -> closed superseder: -> Dict order is now guaranteed, so add tests and doc for it ___ Python

[issue23078] unittest.mock patch autospec doesn't work on staticmethods

Dean Liao added the comment: I planned to upgrade Chromium OS's mock module to 2.0.0. I also encountered the issue that classmethod cannot be patched as callable mock. Reviewers, can we start the review process? -- nosy: +deanliao

[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

Nathaniel Smith added the comment: Right, I *knew* I should be nervous about calling into Python from a C-level destructor... what's happening is: - Somehow, that coroutine object is managing to survive until the very, very end of the shutdown sequence (PyImport_Cleanup). I'm

[issue32674] minor documentation fix for '__import__'

Qian Yun added the comment: Sorry, a typo, it's "minor documentation fix". See https://github.com/python/cpython/pull/5339 diff --git a/Python/bltinmodule.c b/Python/bltinmodule.c index d8971bef2a..80b4f9447c 100644 --- a/Python/bltinmodule.c +++ b/Python/bltinmodule.c @@

[issue32304] Upload failed (400): Digests do not match on .tar.gz ending with x0d binary code

Change by bbayles : -- pull_requests: +5175 ___ Python tracker ___ ___ Python-bugs-list

[issue31972] Inherited docstrings for pathlib classes are confusing

Change by Chason Chaffin : -- nosy: +chason ___ Python tracker ___ ___ Python-bugs-list

[issue2793] Dictionary fails to index when adding list when in a deeply nested loop

Change by Jay Yin : -- pull_requests: +5177 ___ Python tracker ___ ___

[issue32674] minor documentation fix for '__import__'

New submission from Qian Yun : This is a minor documentation for builtin function '__import__'. -- assignee: docs@python components: Documentation messages: 310741 nosy: Qian Yun, docs@python priority: normal severity: normal status: open title: minor documentation

[issue32674] minor documentation fix for '__import__'

Stéphane Wirtel added the comment: Don't worry, but in fact, I did not understand because when you post your issue, there was no associated PR. Now, I do understand. Thank you -- ___ Python tracker

[issue27931] Email parse IndexError <""@wiarcom.com>

Change by Jay Yin : -- pull_requests: +5174 stage: commit review -> patch review ___ Python tracker ___

[issue32304] Upload failed (400): Digests do not match on .tar.gz ending with x0d binary code

Change by bbayles : -- pull_requests: +5176 ___ Python tracker ___ ___ Python-bugs-list

[issue32672] .then execution of actions following a future's completion

Change by dancollins34 : -- keywords: +patch pull_requests: +5182 stage: -> patch review ___ Python tracker ___

[issue32657] Mutable Objects in SMTP send_message Signature

Chason Chaffin added the comment: > It's probably enough to fix it. I fear that if we also change them in > sendmail we'll break someone's code, but maybe we should do that anyway, for > 3.7 only. Should I make a separate issue for that, or attach it to this PR?

[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

Guido van Rossum added the comment: Maybe it's better to roll this back and take a deep breath. The feature freeze should not be treated as an excuse to cram in things at the last minute. Before this week I had never heard of this proposal. And the sarcasm is a bad start of

[issue32662] Implement Server.serve_forever and corresponding APIs

Yury Selivanov added the comment: New changeset 4112c5b97d9c1c7b034653d0e017ffa894a45c74 by Yury Selivanov in branch 'master': bpo-32662: Try making test_asyncio.test_server more reliable (#5338)

[issue32596] Lazy import concurrent.futures.process and thread

INADA Naoki added the comment: New changeset 4666ec597c38eea06a22bcfb4157d92a0abf891c by INADA Naoki in branch 'master': bpo-32596: Make lazy-load portable (GH-5316) https://github.com/python/cpython/commit/4666ec597c38eea06a22bcfb4157d92a0abf891c --

[issue29237] Create enum for pstats sorting options

Change by Ethan Furman : -- pull_requests: +5183 ___ Python tracker ___ ___

[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

Change by Yury Selivanov : -- resolution: fixed -> status: closed -> open ___ Python tracker ___

[issue32657] Mutable Objects in SMTP send_message Signature

Change by Chason Chaffin : -- keywords: +patch pull_requests: +5180 stage: -> patch review ___ Python tracker ___

[issue32672] .then execution of actions following a future's completion

New submission from dancollins34 : To my knowledge, python currently has no capability to chain future execution, requiring another future to begin executing with the result from the first. I have submitted a pr to enable this functionality with a .then(self, fn)

[issue32672] .then execution of actions following a future's completion

dancollins34 added the comment: Okay, I'll post something. -- ___ Python tracker ___

[issue32674] minor documentation fix for '__import__'

Change by Qian Yun : -- keywords: +patch pull_requests: +5186 stage: -> patch review ___ Python tracker ___

[issue32673] update tutorial dict part to reflect dict is ordered

Martin Panter added the comment: See Issue 32337 -- nosy: +martin.panter ___ Python tracker ___

[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

Yury Selivanov added the comment: The following snippet crashes with SIGABRT: import asyncio async def f(): pass asyncio.gather(f()) llvm tells that the crash is in _PyGen_Finalize/_PyErr_WarnUnawaitedCoroutine --

[issue32571] Speed up and clean up getting optional attributes in C code

Change by INADA Naoki : -- pull_requests: +5178 ___ Python tracker ___ ___

[issue32657] Mutable Objects in SMTP send_message Signature

R. David Murray added the comment: It's probably enough to fix it. I fear that if we also change them in sendmail we'll break someone's code, but maybe we should do that anyway, for 3.7 only. -- versions: -Python 2.7, Python 3.4, Python 3.5, Python 3.8

[issue32591] Deprecate sys.set_coroutine_wrapper and replace it with more focused API(s)

Change by Nathaniel Smith : -- pull_requests: +5184 stage: resolved -> patch review ___ Python tracker ___

[issue32662] Implement Server.serve_forever and corresponding APIs

Change by Yury Selivanov : -- pull_requests: +5185 ___ Python tracker ___ ___

[issue32673] update tutorial dict part to reflect dict is ordered

Change by Chason Chaffin : -- nosy: +chason ___ Python tracker ___ ___ Python-bugs-list

[issue32630] Migrate decimal to use PEP 567 context variables

Guido van Rossum added the comment: You guys both need to calm down. Stefan, what's your objection against this, assuming the crash is fixed? -- ___ Python tracker

[issue32571] Speed up and clean up getting optional attributes in C code

INADA Naoki added the comment: New changeset f320be77ffb73e3b9e7fc98c37b8df3975d84b40 by INADA Naoki (Serhiy Storchaka) in branch 'master': bpo-32571: Avoid raising unneeded AttributeError and silencing it in C code (GH-5222)

[issue29708] support reproducible Python builds

Alexandru Ardelean added the comment: Hey, Sorry, if I'm a bit late to the party with this. The road to reproducible builds has a few more steps. The way I validate whether Python is reproducible is with this link:

[issue10381] Add timezone support to datetime C API

STINNER Victor added the comment: Hunting reference leaks with "./python -m test -R 3:3 test_datetime" crashs since the commit 04af5b1ba9eb546a29735fac6cb5298159069b53. *** vstinner@apu$ ./python -m test -R 3:3 test_datetime Run tests sequentially 0:00:00 load avg:

[issue32652] test_distutils: BuildRpmTestCase tests fail on RHEL buildbots

STINNER Victor added the comment: New changeset 2b822a0bb1de2612c85d8f75e3ce89eda2ac9f68 by Victor Stinner in branch 'master': bpo-32652: Defer pymain_set_global_config() call (#5303) https://github.com/python/cpython/commit/2b822a0bb1de2612c85d8f75e3ce89eda2ac9f68

[issue32663] SMTPUTF8SimTests are not actually being run

New submission from Chason Chaffin : In the tests for smtplib, the suite of tests for SMTPUTF8SimTests (added by issue 24218) are not actually being run. This is troublesome in particular, because the test test_send_message_error_on_non_ascii_addrs_if_no_smtputf8 calls

[issue32664] Connector "|" missing between ImportError and LookupError

New submission from Richard Neumann : In the documentation of the built-in exceptions hierarchy, there is a "|" missing connecting ImportError and LookupError. https://docs.python.org/3/library/exceptions.html#exception-hierarchy >From LookupError.__mro__ we can tell,

[issue27505] Missing documentation for setting module __class__ attribute

Change by Cheryl Sabella : -- keywords: +patch pull_requests: +5165 stage: needs patch -> patch review ___ Python tracker ___

[issue32668] deepcopy() fails on ArgumentParser instances

New submission from Martin Kolman : We (the Anaconda OS intaller team) are in the process of switching to a new version of a library (Pykickstart), which among other things switched from using optparse to argparse. And during this endeavour we found that it's apparently

[issue32657] Mutable Objects in SMTP send_message Signature

Steven D'Aprano added the comment: On Thu, Jan 25, 2018 at 02:28:17PM +, R. David Murray wrote: > obviously I missed that mutation of the value > in the code review of the patch that added those lines :( The docstring for send_message does say If the

[issue27505] Missing documentation for setting module __class__ attribute

Change by Cheryl Sabella : -- pull_requests: +5166 ___ Python tracker ___ ___

[issue32654] Fixes Python for Android API 19

STINNER Victor added the comment: I wrote PR 5305 for Paul Peny who uses cheap devices (less than 50$, maybe less 20$? I'm not sure) for development, but these devices use old Android versions. It seems like some people are exchanging patches, in private or in

[issue32654] Fixes Python for Android API 19

Ned Deily added the comment: I don't think we should be adding this platform-version-specific code unless we are going to fully support that particular platform and version. That means at a minimum adding a buildbot for it and then having a core developer signed up to

[issue10381] Add timezone support to datetime C API

STINNER Victor added the comment: Oh, PR 5317 title mentionned this bpo number, but the merged change omits the bpo number and so wasn't mentioned on this issue. PR 5317 added: commit 58dc03c737a71de93edef7723c9f6186116288ef (upstream/master, master) Author: Paul

[issue32654] Fixes Python for Android API 19

pmpp added the comment: Thanks ! I tested your PR it just built out of the box with the help of a one line change to Xavier de Gaye's android build support tool ( configure-android script + Android folder from bpo-30386 ). I'll forward to you the result of testsuite on a

[issue32640] Python 2.7 str.join documentation is incorrect

Mariatta Wijaya added the comment: Oops. Thanks, I will work on reverting the change later today. -- assignee: docs@python -> Mariatta ___ Python tracker

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

STINNER Victor added the comment: I discussed with Jay Yin on IRC and we understood the issue on his setup: the last entry of his PATH environment variable is a path to an existing *file*, not a directory. In this case, subprocess.Popen() fails with ENOTDIR if the

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

Change by STINNER Victor : -- keywords: +patch pull_requests: +5167 stage: -> patch review ___ Python tracker ___

[issue32654] Fixes Python for Android API 19

Chih-Hsuan Yen added the comment: Agree with Ned Deily here. If CPython is going to be support android-19, it's better to fully support it. I'm optimistic here - I believe there won't be many android-19-specific patches beyond locale-related ones. Once android-24 is done,

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

STINNER Victor added the comment: Attached PR 5322 fixes the issue. Example to reproduce the bug: $ touch file $ PATH=$PATH:$PWD/file ./python -m test test_subprocess -m test_invalid_args -v (...) ==

[issue32654] Fixes Python for Android API 19

STINNER Victor added the comment: Ned Deily: "I don't think we should be adding this platform-version-specific code unless we are going to fully support that particular platform and version." I know the theory and I know the practice :-) I started to list platforms

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

STINNER Victor added the comment: New changeset b31206a223955d614d7769f95fb979d60f77bf87 by Victor Stinner in branch 'master': bpo-32667: Fix tests when $PATH contains a file (#5322) https://github.com/python/cpython/commit/b31206a223955d614d7769f95fb979d60f77bf87

[issue32654] Fixes Python for Android API 19

STINNER Victor added the comment: Another example of platform with best effort support is AIX. Until very recently, ctypes.util.find_library() didn't work on AIX which causes many tests failure. The AIX buildbot is red as far as I can remember. *Many* tests are

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

Change by Roundup Robot : -- pull_requests: +5168 ___ Python tracker ___

[issue32654] Fixes Python for Android API 19

STINNER Victor added the comment: By the way, I started to take notes on Python on Android, since the topic is wide and complex: http://vstinner.readthedocs.io/python_android.html -- ___ Python tracker

[issue32630] Migrate decimal to use PEP 567 context variables

Stefan Krah added the comment: I realize that you had to fight massive mailing list distractions during the PEP discussions, but this is very close to the beta ... Let's start here: >>> from decimal import * ==18887== Invalid read of size 8 ==18887==at 0x5324E0:

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

Change by STINNER Victor : -- pull_requests: +5169 ___ Python tracker ___ ___

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: > I realize that you had to fight massive mailing list distractions > during the PEP discussions, but this is very close to the beta ... Oh thanks, but I see no reason for you to be condescending here. I cannot reproduce this on Mac OS /

[issue32583] Crash during decoding using UTF-16/32 and custom error handler

Change by Xiang Zhang : -- pull_requests: +5170 ___ Python tracker ___ ___

[issue32436] Implement PEP 567

Change by Yury Selivanov : -- pull_requests: +5171 ___ Python tracker ___ ___

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: (Just in case I rebased my patch onto the latest master) -- ___ Python tracker ___

[issue29708] support reproducible Python builds

Change by Brett Cannon : -- resolution: fixed -> status: closed -> open ___ Python tracker ___

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: I think I found what cause this, but I have no idea why it has surfaced only now :) https://github.com/python/cpython/pull/5326/files (see the added PyType_IS_GC(Py_TYPE(name)) check) I'll merge that PR and rebase the decimal patch

[issue32669] cgitb file to print OSError exceptions

New submission from steven Michalske : With the source ``` import cgitb import sys try: f = open('non_exitant_file_path.foo') except Exception as e: cgitb.text(sys.exc_info()) ``` we get the output ``` Traceback (most recent call last): File "foo.py", line 22,

[issue32436] Implement PEP 567

Yury Selivanov added the comment: New changeset 6ab62920c87930dedc31fe633ecda3e51d3d7503 by Yury Selivanov in branch 'master': bpo-32436: Fix a refleak; var GC tracking; a GCC warning (#5326)

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: I pushed a fix (already in the master branch) and rebased the patch once again. I expect it to work now :) -- ___ Python tracker

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

Change by Jay Yin : -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

Change by Jay Yin : -- resolution: -> fixed ___ Python tracker ___ ___

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

Change by Jay Yin : -- versions: +Python 3.6 ___ Python tracker ___ ___

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

Change by Jay Yin : -- versions: +Python 2.7 ___ Python tracker ___ ___

[issue32630] Migrate decimal to use PEP 567 context variables

Change by Mark Dickinson : -- nosy: +mark.dickinson ___ Python tracker ___ ___

[issue29302] add contextlib.AsyncExitStack

Yury Selivanov added the comment: New changeset 1aa094f74039cd20fdc7df56c68f6848c18ce4dd by Yury Selivanov (Ilya Kulakov) in branch 'master': bpo-29302: Implement contextlib.AsyncExitStack. (#4790)

[issue29302] add contextlib.AsyncExitStack

Yury Selivanov added the comment: Thank you Alexander and Ilya! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue32669] cgitb file to print OSError exceptions

R. David Murray added the comment: Yep, this one might get closed as "as designed", too ;) cgitb has to cope with something going wrong with trying to print out values, because there are a number of ways to break that in Python, not just the one you are pointing to.

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

STINNER Victor added the comment: New changeset 6996f284d4d90aa05c46d9fe6f38d1030454b224 by Victor Stinner in branch '2.7': bpo-32667: Fix tests when $PATH contains a file (#5324) https://github.com/python/cpython/commit/6996f284d4d90aa05c46d9fe6f38d1030454b224

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

STINNER Victor added the comment: Thank you Jay Yin for your bug report. I fixed the bug in Python 2.7, 3.6 and master. -- ___ Python tracker

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

STINNER Victor added the comment: New changeset 255dbd2102d5dec5ffbd0b94084377e98c3b56c4 by Victor Stinner (Miss Islington (bot)) in branch '3.6': bpo-32667: Fix tests when $PATH contains a file (GH-5322) (#5323)

[issue32667] test_subprocess and test_dtrace fails if the last entry of $PATH is a file

Jay Yin added the comment: no problem, thanks for helping and fixing the issue, I can now help contribute to python =D -- ___ Python tracker

[issue32670] Enforce PEP 479—StopIteration and generators—in Python 3.7 by default

New submission from Yury Selivanov : As per PEP 479, in Python 3.7 it should be a RuntimeError when a StopIteration exception is raised manually in a generator, a coroutine, or an async generator. -- assignee: yselivanov components: Interpreter Core messages:

[issue32670] Enforce PEP 479—StopIteration and generators—in Python 3.7 by default

Change by Yury Selivanov : -- keywords: +patch pull_requests: +5172 stage: -> patch review ___ Python tracker ___

[issue32657] Mutable Objects in SMTP send_message Signature

R. David Murray added the comment: On Thu, 25 Jan 2018 15:18:01 +, Steven D'Aprano wrote: > On Thu, Jan 25, 2018 at 02:28:17PM +, R. David Murray wrote: > The docstring for send_message does say > > If the sender or any of the

[issue32630] Migrate decimal to use PEP 567 context variables

Change by Yury Selivanov : -- nosy: +ned.deily priority: normal -> release blocker ___ Python tracker ___

[issue32630] Migrate decimal to use PEP 567 context variables

Change by Stefan Krah : -- priority: release blocker -> normal ___ Python tracker ___

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: Stefan, I do think that this is a release blocker. We want to get this change as early as possible to ensure that it's well tested. AFAIK Guido also wants decimal to be updated and well supported in async/await code. --

[issue32630] Migrate decimal to use PEP 567 context variables

Stefan Krah added the comment: Sure, and *I* am the one running the extended decimal test suite as we speak, not Guido. You are playing power games here, and you did that from the start by choosing the nosy list. -- ___ Python

[issue32630] Migrate decimal to use PEP 567 context variables

Yury Selivanov added the comment: > Sure, and *I* am the one running the extended decimal test suite as we speak, > not Guido. Thank you. > You are playing power games here, and you did that from the start by choosing > the nosy list. Please. I thought it was pretty

[issue32630] Migrate decimal to use PEP 567 context variables

Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___

[issue32662] Implement Server.serve_forever and corresponding APIs

Yury Selivanov added the comment: New changeset c9070d03f5169ad6e171e641b7fa8feab18bf229 by Yury Selivanov in branch 'master': bpo-32662: Implement Server.start_serving() and Server.serve_forever() (#5312)

[issue32662] Implement Server.serve_forever and corresponding APIs

Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue31698] Add REQ_NAME to the node.h API

Change by Cheryl Sabella : -- type: -> enhancement ___ Python tracker ___ ___

[issue32645] test_asyncio: TLS tests fail on "x86 Windows7" buildbot

STINNER Victor added the comment: Build 537 of x86 Tiger 3.x failed, whereas the previous build was a success. Hum, maybe these asyncio failures are "just" race conditions, trigger if the system load is too high? I recall that the Windows 7 buildbot is usually

[issue27505] Missing documentation for setting module __class__ attribute

Cheryl Sabella added the comment: Thanks Nick. I've made the PRs for the versionadded and to add __class__ to the 3.6 docs. -- stage: patch review -> needs patch versions: +Python 3.7 -Python 3.5 ___ Python tracker

  1   2   >