[issue1621] Do not assume signed integer overflow behavior

2016-08-05 Thread Xiang Zhang
Xiang Zhang added the comment: It's good Martin. Just commit it. -- ___ Python tracker ___ ___

[issue1621] Do not assume signed integer overflow behavior

2016-08-05 Thread Martin Panter
Martin Panter added the comment: Xiang: regarding your overflow_fix_in_listextend.patch, what do you think about adding a comment or debugging assertion instead, something like: /* It should not be possible to allocate a list large enough to cause an overflow on any relevant platform */

[issue21056] csv documentation is incorrect

2016-08-05 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch versions: +Python 3.5, Python 3.6 -Python 3.4 ___ Python tracker

[issue18548] In unittest doc change WidgetTestCase to SimpleWidgetTestCase in suite()

2016-08-05 Thread Berker Peksag
Berker Peksag added the comment: Good catch, thanks! I went with Ezio's suggestion but left 2.7 documentation as is. -- nosy: +berker.peksag resolution: -> fixed stage: patch review -> resolved status: open -> closed type: enhancement -> behavior versions: +Python 3.5, Python 3.6

[issue18548] In unittest doc change WidgetTestCase to SimpleWidgetTestCase in suite()

2016-08-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset d0402caa0ef5 by Berker Peksag in branch '3.5': Issue #18548: Fix unittest.TestSuite() example https://hg.python.org/cpython/rev/d0402caa0ef5 New changeset e17e3f620709 by Berker Peksag in branch 'default': Issue #18548: Merge from 3.5

[issue15639] csv.Error description is incorrectly broad

2016-08-05 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. Most of the csv.Error usages are in Modules/_csv.c. You can search for "_csvstate_global->error_obj" in the module's source code. I think the documentation is correct as is. -- nosy: +berker.peksag resolution: -> not a bug

[issue27621] Finish IDLE Query dialog appearance and behavior.

2016-08-05 Thread Mark Roseman
Mark Roseman added the comment: Looks great Terry - thanks. Only nit is that test_click_help_source fails on Mac, courtesy a leading 'file://' added in the last few lines of path_ok -- ___ Python tracker

[issue26981] add compatibility shim for enum34 backport

2016-08-05 Thread Ethan Furman
Ethan Furman added the comment: Done in issue26988. -- resolution: -> fixed status: open -> closed superseder: -> Add AutoNumberedEnum to stdlib ___ Python tracker

[issue26988] Add AutoNumberedEnum to stdlib

2016-08-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset 7ed7d7f58fcd by Ethan Furman in branch 'default': Add AutoEnum: automatically provides next value if missing. Issue 26988. https://hg.python.org/cpython/rev/7ed7d7f58fcd -- nosy: +python-dev ___ Python

[issue15786] IDLE code completion window can hang or misbehave with mouse

2016-08-05 Thread Mark Roseman
Mark Roseman added the comment: I've done some playing around... not quite there yet, but I think much closer. First, I assume the 'freeze' on Mac is not a hard freeze, but where the text window is not responding to events, but if you switch to another app and back, it works again? Second,

[issue14594] document imp.load_dynamic()

2016-08-05 Thread Berker Peksag
Berker Peksag added the comment: The imp module has been deprecated long time ago and the importlib module itself doesn't it anymore. However, Cython still use it: https://github.com/cython/cython/blob/master/pyximport/pyximport.py#L217 I'm inclined to close this as 'out of date' but feel

[issue3216] Scarce msilib documentation

2016-08-05 Thread Berker Peksag
Berker Peksag added the comment: All obvious bugs have already been fixed. -- nosy: +berker.peksag resolution: -> fixed stage: -> resolved status: open -> closed ___ Python tracker

[issue22391] MSILIB truncates last character in summary information stream

2016-08-05 Thread Berker Peksag
Berker Peksag added the comment: Thanks for the report. This is a duplicate of issue 1104. -- nosy: +berker.peksag resolution: -> duplicate stage: -> resolved status: open -> closed ___ Python tracker

[issue12276] 3.x ignores sys.tracebacklimit=0

2016-08-05 Thread Berker Peksag
Changes by Berker Peksag : -- keywords: +easy stage: -> needs patch type: -> behavior versions: +Python 3.5, Python 3.6 -Python 3.1, Python 3.2 ___ Python tracker

[issue27695] Compilation doesnt' end

2016-08-05 Thread STINNER Victor
STINNER Victor added the comment: FYI my Python reimplementation of the bytecode peephole optimizer doesn't have this issue. It estimates the size of a**b using exp() and ln() functions. http://bytecode.readthedocs.io/en/latest/ -- ___ Python tracker

[issue27242] Make the docs for NotImplemented & NotImplementedError unambiguous

2016-08-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset 142f5325af06 by Ethan Furman in branch 'default': Clarify NotImplemented vs NotImplementedError. Initial patch by Emmanuel Barry. Closes issue 27242. https://hg.python.org/cpython/rev/142f5325af06 -- nosy: +python-dev resolution: ->

[issue27697] Obscure bug in the int() function

2016-08-05 Thread Berker Peksag
Changes by Berker Peksag : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___

[issue27697] Obscure bug in the int() function

2016-08-05 Thread Ammar Askar
Ammar Askar added the comment: You've ran into a classic floating point number limitation. Please read the following doc page: https://docs.python.org/2/tutorial/floatingpoint.html The problem comes when you multiply the number by 100, which is what causes the precision loss and drops it by

[issue27182] PEP 519 support in the stdlib

2016-08-05 Thread Brett Cannon
Brett Cannon added the comment: Just a quick update: between the patches for issue #26027 and issue #26667, the necessary code to make os.path work with path-like objects is done. At this point I'm just waiting for code reviews on those patches. --

[issue27697] Obscure bug in the int() function

2016-08-05 Thread nathan snobelen
New submission from nathan snobelen: Hi, I've noticed a bug in int() when converting a specific range of numbers it will incorrectly round the last digit down. We have some payment code which formats numbers for processing in our system and we noticed that the payment of 1108431.38 was

[issue26027] Support Path objects in the posix module

2016-08-05 Thread Brett Cannon
Brett Cannon added the comment: Here is a version of Jelle's patch but with PyOS_FSPath() inlined. Serhiy, does this work for you? -- stage: patch review -> commit review Added file: http://bugs.python.org/file44029/path_converter.diff ___ Python

[issue27696] win_add2path.py does not add user site directory

2016-08-05 Thread Kyle Altendorf
New submission from Kyle Altendorf: Since the detected user path has the text `%APPDATA%` replaced into it `os.path.isdir()` returns `False`. As a result, the user site path is not added to the `%PATH%` variable. The patch adds `os.path.expandvars()` to the `isdir()` check to resolve this

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

2016-08-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset 4d33bccb59a8 by Vinay Sajip in branch '3.3': Issue #20160: Handled passing of large structs to callbacks correctly. https://hg.python.org/cpython/rev/4d33bccb59a8 New changeset 190ebf99bf45 by Vinay Sajip in branch '3.4': Issue #20160: Merged fix

[issue8243] curses writing to window's bottom right position raises: `_curses.error: addstr() returned ERR'

2016-08-05 Thread Ned Deily
Ned Deily added the comment: See also Issue27693 which documents a similar issue using curses.textpad. -- ___ Python tracker ___

[issue27693] curses.textpad.Textbox(win).edit() won't edit last character

2016-08-05 Thread Ned Deily
Ned Deily added the comment: Looks like there have been longstanding issues with using curses to write to the right-/bottom-most character position of a curses window; see open Issue8243 and various discussions elsewhere. Some of the discussions suggest the issues dates back to support of

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

2016-08-05 Thread Roundup Robot
Roundup Robot added the comment: New changeset 09475e6135d0 by Vinay Sajip in branch '2.7': Issue #20160: Handled passing of large structs to callbacks correctly. https://hg.python.org/cpython/rev/09475e6135d0 -- ___ Python tracker

[issue27689] Add documentation for typing.Generator

2016-08-05 Thread Guido van Rossum
Guido van Rossum added the comment: changeset: 102542:f10029fea6ee tag: tip parent: 102540:fe189b8bd3ab parent: 102541:b5403f416836 user:Guido van Rossum date:Fri Aug 05 12:57:38 2016 -0700 summary: Add typing.Generator docs, by Michael

[issue26800] Don't accept bytearray as filenames part 2

2016-08-05 Thread Brett Cannon
Brett Cannon added the comment: Assigning to Serhiy to apply since Larry doesn't care and I already reviewed the patch. -- assignee: larry -> serhiy.storchaka stage: patch review -> commit review ___ Python tracker

[issue27184] Support path objects in the ntpath module

2016-08-05 Thread Brett Cannon
Brett Cannon added the comment: I added support for ntpath as part of issue #27524. -- resolution: -> duplicate status: open -> closed superseder: -> Update os.path for PEP 519/__fspath__() ___ Python tracker

[issue27689] Add documentation for typing.Generator

2016-08-05 Thread Michael Lee
Michael Lee added the comment: Revision 3 -- I changed the protocol for the example so that you stop the generator by sending in a negative number as a sentinel rather then None. -- Added file: http://bugs.python.org/file44027/document-generators-v3.patch

[issue27671] FAQ: len() is still function for good reason.

2016-08-05 Thread Terry J. Reedy
Terry J. Reedy added the comment: I agree. We do not need to semi-apologize for having generic functions be builtin generic functions. -- nosy: +terry.reedy ___ Python tracker

[issue27695] Compilation doesnt' end

2016-08-05 Thread Ammar Askar
Ammar Askar added the comment: Just in case anyone is wondering why this happens. The compiler's peephole optimizer will fold constant expressions like x = 5 + 5 into x = 10 More specifically, this bit here:

[issue27689] Add documentation for typing.Generator

2016-08-05 Thread Michael Lee
Michael Lee added the comment: Revision two -- I added a brief note mentioning that SendType is contravariant, as Ivan suggested. -- Added file: http://bugs.python.org/file44026/document-generators-v2.patch ___ Python tracker

[issue27688] Expand documentation about Any in the typing module

2016-08-05 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: I have reviewed your patch, and it compiles with sphinx. no issue with the content, but I am not a native speaker and not an expert of the type hinting of python 3.5 -- nosy: +matrixise ___ Python tracker

[issue27695] Compilation doesnt' end

2016-08-05 Thread SilentGhost
SilentGhost added the comment: On 3.6 it takes a very long time, but it does finish. time ./python -c "raise ValueError ; 2 ** 12345678912345" Traceback (most recent call last): File "", line 1, in ValueError real1m35.673s user1m18.952s sys 0m16.644s -- nosy:

[issue27695] Compilation doesnt' end

2016-08-05 Thread SilentGhost
Changes by SilentGhost : -- type: compile error -> resource usage versions: +Python 2.7 ___ Python tracker ___

[issue27695] Compilation doesnt' end

2016-08-05 Thread SilentGhost
Changes by SilentGhost : -- components: +Interpreter Core nosy: +haypo, serhiy.storchaka versions: +Python 3.6 -Python 2.7 ___ Python tracker

[issue27695] Compilation doesnt' end

2016-08-05 Thread Franco Costantini
New submission from Franco Costantini: Hi, we currently are fuzzing Python programs to find valid code that fails to compile. We found this program never finishes its compilation. $ echo "raise ValueError ; 2 ** 12345678912345" > inf.py $ python -m py_compile inf.py We realize the computation

[issue24658] open().write() fails on 2 GB+ data (OS X)

2016-08-05 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Sorry, I was busy with a task but here is my patch for 3.5, in fact, it's just the same for 3.6 -- Added file: http://bugs.python.org/file44023/issue24658-3.5.diff ___ Python tracker

[issue24658] open().write() fails on 2 GB+ data (OS X)

2016-08-05 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : Added file: http://bugs.python.org/file44024/issue24658-3.5.diff ___ Python tracker ___

[issue27688] Expand documentation about Any in the typing module

2016-08-05 Thread Michael Lee
Michael Lee added the comment: Here's revision two. The only change I didn't make was the one about the isinstance check. It isn't included in PEP 484, and after talking to Guido, he decided it wouldn't be appropriate to document it here. -- Added file:

[issue24658] open().write() fails on 2 GB+ data (OS X)

2016-08-05 Thread Stéphane Wirtel
Changes by Stéphane Wirtel : Removed file: http://bugs.python.org/file44023/issue24658-3.5.diff ___ Python tracker ___

[issue26945] difflib.HtmlDiff().make_file() treat few change as whole line change

2016-08-05 Thread SilentGhost
SilentGhost added the comment: JW, could you submit a minimal reproducer for this? -- ___ Python tracker ___

[issue27585] asyncio.Lock deadlock after cancellation

2016-08-05 Thread Guido van Rossum
Guido van Rossum added the comment: OK, merged upstream. It'll eventually come down to Python 3.5.3 and 3.6. On Thu, Aug 4, 2016 at 1:28 PM, sss wrote: > > sss added the comment: > > Thank you. This looks good to me > > -- > >

[issue26945] difflib.HtmlDiff().make_file() treat few change as whole line change

2016-08-05 Thread JW
JW added the comment: i found that making a change similar to this one in a certain place towards then end of my 300 or so long list of strings produces issues further along: making a change of Latitude=1.1 -> Latitude=111.1 correctly shows as 11 added; however subsequent matching lines then

[issue27689] Add documentation for typing.Generator

2016-08-05 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: Michael, thank you for the patch. I have only one comment. Generator is one of the few types in typing.py that behaves contravariantly. Maybe you could emphasize that it is contravariant in send type in your patch? -- nosy: +levkivskyi

[issue27689] Add documentation for typing.Generator

2016-08-05 Thread Guido van Rossum
Changes by Guido van Rossum : -- assignee: docs@python -> gvanrossum ___ Python tracker ___

[issue27689] Add documentation for typing.Generator

2016-08-05 Thread Guido van Rossum
Guido van Rossum added the comment: Patch LGTM. I'll apply and merge once your other patches are final. -- ___ Python tracker ___

[issue27424] Failures in test.test_logging

2016-08-05 Thread Emanuel Barry
Emanuel Barry added the comment: I'm not home to check, but judging by the error message and previous discussions with other developers, it seems indeed like an issue with a non-ASCII character in my hostname. I've changed my hostname since then, so I'm going to close this as won't fix. If it

[issue27614] Race in test_docxmlrpc.py

2016-08-05 Thread earl.chew
earl.chew added the comment: In the original code, the key to the failure I observed is: # wait for port to be assigned n = 1000 while n > 0 and PORT is None: time.sleep(0.001) n -= 1 This gives a fixed deadline for the server thread to create

[issue27694] Socket incorrectly states IP address that start with a zero after a dot are illegal

2016-08-05 Thread SilentGhost
Changes by SilentGhost : -- stage: -> resolved ___ Python tracker ___ ___

[issue27694] Socket incorrectly states IP address that start with a zero after a dot are illegal

2016-08-05 Thread Martin Panter
Martin Panter added the comment: I am pretty sure it isn’t legal. Python’s inet_aton() just wraps the underlying OS call. According to Posix , the leading zero in 093 would indicate octal notation, but the nine is not a

[issue20004] csv.DictReader classic class has a property with setter

2016-08-05 Thread Mathieu Dupuy
Mathieu Dupuy added the comment: The comment is still present in python 3 sources at the moment. Shouldn't we remove it in python 3 ? -- nosy: +deronnax ___ Python tracker

[issue27694] Socket incorrectly states IP address that start with a zero after a dot are illegal

2016-08-05 Thread Haaroon Y
New submission from Haaroon Y: Using the socket library and the method socket.inet_aton(ipAddr) it incorrectly states IP address such as 192.168.093.1 and 192.092.2.1 are not legal when they are. -- components: Library (Lib) messages: 272033 nosy: Haaroon Y priority: normal severity:

[issue27694] Socket incorrectly states IP address that start with a zero after a dot are illegal

2016-08-05 Thread Haaroon Y
Haaroon Y added the comment: This seems to occur when a IP value is 078 or higher. -- ___ Python tracker ___

[issue27692] Clean serveral unnecessary NULL checks in exceptions.c

2016-08-05 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: LGTM. -- stage: -> commit review ___ Python tracker ___ ___

[issue27683] ipaddress subnet slicing iterator malfunction

2016-08-05 Thread Emanuel Barry
Emanuel Barry added the comment: Ack, special cases! I can look into making a patch, but I'm not really acquainted with ipaddress or the relevant protocols, so it might not be optimal. I'll give it a shot next week if nobody else does. -- stage: patch review -> needs patch

[issue24658] open().write() fails on 2 GB+ data (OS X)

2016-08-05 Thread Stéphane Wirtel
Stéphane Wirtel added the comment: Here is my patch 3.6, I am going to provide the patch for 3.5 -- nosy: +matrixise Added file: http://bugs.python.org/file44021/issue24658-3.6.diff ___ Python tracker

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

2016-08-05 Thread Patrick Stewart
Patrick Stewart added the comment: Actually the current released version of libffi (3.2.1) is even more severely broken on win64, you can't return structs at all. (patch here

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

2016-08-05 Thread Steve Dower
Steve Dower added the comment: Yeah, it's more a loose end than a real concern. Helps make the case for reintegrating current libffi builds, as IIRC they've had the fix for a long time, but we don't have anyone willing to do the integration work right now. --

[issue27693] curses.textpad.Textbox(win).edit() won't edit last character

2016-08-05 Thread Dietmar Schindler
New submission from Dietmar Schindler: curses.textpad.Textbox(win).edit() does not allow to enter a character (or change one, if already there) at the very last position in a window (the lower right hand corner), though it allows to position the cursor there. This applies to the whole screen

[issue15873] datetime: add ability to parse RFC 3339 dates and times

2016-08-05 Thread Mathieu Dupuy
Mathieu Dupuy added the comment: updated version with SilentGhost's concerns addressed. -- Added file: http://bugs.python.org/file44019/fromisoformat_regexinclasses2.patch ___ Python tracker

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

2016-08-05 Thread Larry Hastings
Larry Hastings added the comment: 3.4 is also in security-fixes-only mode, which also means it's in no-binary-installers mode. Good luck making the case that "this bugfix, which took us more than 2.5 years to finalize, is so critical that the release team must immediately issue binary

[issue20160] broken ctypes calling convention on MSVC / 64-bit Windows (large structs)

2016-08-05 Thread Vinay Sajip
Vinay Sajip added the comment: According to PEP 398, we should patch the source for security updates for 3.3 until September 2017, though no new binary release needs to be made. I'm not sure if expedited binary releases are needed for 3.4 and 3.5. I will look at applying the patch in 2.7 and

[issue27691] X509 cert with GEN_RID subject alt name causes SytemError

2016-08-05 Thread Christian Heimes
Changes by Christian Heimes : -- keywords: +patch Added file: http://bugs.python.org/file44018/0001-Fix-handling-of-GEN_RID-in-X.509-subjectAltName-fiel.patch ___ Python tracker

[issue27692] Clean serveral unnecessary NULL checks in exceptions.c

2016-08-05 Thread Xiang Zhang
New submission from Xiang Zhang: While studying exceptions.c, find several unnecessary NULL checks that can be removed. -- components: Interpreter Core files: small_cleanup_exceptions.patch keywords: patch messages: 272023 nosy: martin.panter, serhiy.storchaka, xiang.zhang priority:

[issue27614] Race in test_docxmlrpc.py

2016-08-05 Thread Martin Panter
Martin Panter added the comment: Earl: Can you give any more details on your original hang or race condition? Was it related to setting PORT, or shutting down the server, or something else? It is not clear from your patch. I have tried adding artificial sleep() calls at various points but

[issue15873] datetime: add ability to parse RFC 3339 dates and times

2016-08-05 Thread Mathieu Dupuy
Changes by Mathieu Dupuy : Added file: http://bugs.python.org/file44016/fromisoformat_strptimesingledispatch.patch ___ Python tracker ___

[issue15873] datetime: add ability to parse RFC 3339 dates and times

2016-08-05 Thread Mathieu Dupuy
Changes by Mathieu Dupuy : Added file: http://bugs.python.org/file44015/fromisoformat_regexinclasses.patch ___ Python tracker ___

[issue15873] datetime: add ability to parse RFC 3339 dates and times

2016-08-05 Thread Mathieu Dupuy
Mathieu Dupuy added the comment: I'm back on the issue. I'm currently stuck on the design. We need to store the regexes somewhere, and that's what causes problem : I can't really find a good place to store them. We basically have two possible designs : * single dispatch kind, class-type

[issue27691] X509 cert with GEN_RID subject alt name causes SytemError

2016-08-05 Thread Christian Heimes
New submission from Christian Heimes: A X509 cert with a registered id general name in subject alternative name causes a SystemError: error return without exception set. This prevents host name validation of certs with a registered id. >>> import _ssl >>> _ssl._test_decode_cert('rid.pem')

[issue26462] Patch to enhance literal block language declaration

2016-08-05 Thread Martin Panter
Martin Panter added the comment: I backported the patch to 2.7. Now I get no warnings about syntax highlighting from 2.7 (there were only a few reported before). -- resolution: -> fixed stage: needs patch -> resolved status: open -> closed ___

[issue27688] Expand documentation about Any in the typing module

2016-08-05 Thread Ivan Levkivskyi
Changes by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker ___ ___

[issue27389] When a TypeError is raised due to invalid arguments to a method, it should use __qualname__ to identify the class the method is in

2016-08-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- superseder: -> Names in function call exception should have class names, if they're methods ___ Python tracker

[issue27690] os.path.normcase broken.

2016-08-05 Thread Serhiy Storchaka
Changes by Serhiy Storchaka : -- resolution: -> works for me stage: -> resolved status: open -> closed ___ Python tracker

[issue27683] ipaddress subnet slicing iterator malfunction

2016-08-05 Thread Nick Coghlan
Nick Coghlan added the comment: As Stephen notes, the underlying problem appears to be a behavioural difference between two theoretically equivalent ways of defining a network: >>> list(ipaddress.IPv4Network(('127.0.0.4', 31)).hosts()) [] >>>

[issue27690] os.path.normcase broken.

2016-08-05 Thread Lilin Lao
Lilin Lao added the comment: I Fixed it by uninstall and then reinstall python, thanks -- ___ Python tracker ___