[issue29384] Unused beos build scripts

2017-01-28 Thread Senthil Kumaran
Senthil Kumaran added the comment: @martin, the patch looks good to me. Please go ahead and commit this. -- nosy: +orsenthil ___ Python tracker ___

[issue29326] Blank lines in ._pth file are not ignored

2017-01-28 Thread Steve Dower
Steve Dower added the comment: I haven't had a chance to try the patch (underpth_blank_lines.diff) or apply it, but it looks right. If one of the other core devs gets to apply this before I do, feel free. Alexey, you don't need to sign a CLA for this fix, but if you're going to contribute

[issue29386] select.epoll.poll may behave differently if timeout = -1 vs timeout = None

2017-01-28 Thread Gabriel McManus
New submission from Gabriel McManus: The select module epoll.poll method takes a "timeout" parameter which is documented as having a default value of -1 [1]. If no timeout (or None) is passed to epoll.poll, then a value of -1 is passed to the epoll_wait system call. But if a timeout of -1 is

[issue23980] Documentation for format units starting with 'e' is inconsistent

2017-01-28 Thread Martin Panter
Martin Panter added the comment: The O! and O& units are in a similar situation. They just use a different font and descriptive name, rather than a specific type: ``O!`` (object) [*typeobject*, PyObject \*] ``O&`` (object) [*converter*, *anything*] Following this lead, you could write:

[issue29385] Sockets Crashes or Memory Corruption

2017-01-28 Thread Dhiraj
New submission from Dhiraj: When Python Server receives a string of '/xff' (5 or more) from a page after completing a handshake, the tab immediately crashes. There are variations of this string with other characters mixed in that also cause an immediate close of python server. To

[issue29310] Document typing.NamedTuple default argument syntax

2017-01-28 Thread Raymond Hettinger
Raymond Hettinger added the comment: Thanks for the patch. It applies cleanly. The docs build just fine. The markup looks okay. The example runs correctly. Applied and marking as closed. -- resolution: -> fixed status: open -> closed ___

[issue29310] Document typing.NamedTuple default argument syntax

2017-01-28 Thread Roundup Robot
Roundup Robot added the comment: New changeset b33c3f26eefa by Raymond Hettinger in branch '3.6': Issue 29310: Document typing.NamedTuple default argument syntax https://hg.python.org/cpython/rev/b33c3f26eefa -- nosy: +python-dev ___ Python tracker

[issue29384] Unused beos build scripts

2017-01-28 Thread Martin Panter
New submission from Martin Panter: Modules/ld_so_beos and Modules/ar_beos are no longer used since Be OS support was dropped from the configure script for Python 3: https://hg.python.org/cpython/diff/a5e984eda45a/configure.in I propose to also remove the scripts. -- components: Build

[issue29310] Document typing.NamedTuple default argument syntax

2017-01-28 Thread Raymond Hettinger
Changes by Raymond Hettinger : -- assignee: -> rhettinger nosy: +rhettinger ___ Python tracker ___

[issue29310] Document typing.NamedTuple default argument syntax

2017-01-28 Thread Guido van Rossum
Guido van Rossum added the comment: Sorry, I'm still sick. You may have to find another core dev to help you. -- ___ Python tracker ___

[issue29381] Tutorial documentation contains undefined reference to #!

2017-01-28 Thread Raymond Hettinger
Raymond Hettinger added the comment: > Is Mariatta responsible for reviewing Documentation submissions? No, she is a new core developer and this is a good issue for her to do the initial review and post any thoughts on the subject. We've all got to start somewhere. > If so, should I nosy

[issue3991] urllib.request.urlopen does not handle non-ASCII characters

2017-01-28 Thread Martin Panter
Martin Panter added the comment: I’m not really an expert on non-ASCII URLs / IRIs. Maybe it is obvious to other people that this is a good general implementation, but for me to thoroughly review it I would need time to research the relevant RFCs, other implementations, suitability for the

[issue29262] Provide a way to check for *real* typing.Union instances

2017-01-28 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: Cross-posting the link to upstream work on this: https://github.com/python/typing/pull/377 -- ___ Python tracker ___

[issue20664] _findLib_crle and _get_soname broken on latest SunOS 5.11

2017-01-28 Thread Martin Panter
Martin Panter added the comment: There is an Open Indiana buildbot , that was passing test_ctypes (until the buildbot went offline a few weeks ago). Would it be possible to include a regression test case? Also, in

[issue23287] ctypes.util.find_library needlessly call crle on Solaris

2017-01-28 Thread Martin Panter
Martin Panter added the comment: Do you have an opinion of the proposal Shawn? Judging by John’s “[the constant] is what the system provides, though users may customize as needed”, it sounds like the patch is more than a bug fix. Will it also mean find_library() will no longer search

[issue29362] regrtest: don't fail immediately if a child does crash

2017-01-28 Thread Ammar Askar
Ammar Askar added the comment: This patch makes it so that when a child runner crashes during a multiprocess test run, it is treated similar to a keyboard interrupt. That is, the currently running tests will continue to run and immediately after it will print out a summary. I think the test

[issue23287] ctypes.util.find_library needlessly call crle on Solaris

2017-01-28 Thread Shawn
Shawn added the comment: Could we get someone to evaluate this please? -- nosy: +swalker ___ Python tracker ___

[issue29310] Document typing.NamedTuple default argument syntax

2017-01-28 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: Thank you! Guido, I think this is ready to be merged. -- ___ Python tracker ___

[issue29310] Document typing.NamedTuple default argument syntax

2017-01-28 Thread Jelle Zijlstra
Jelle Zijlstra added the comment: Fixed the typo -- Added file: http://bugs.python.org/file46445/issue29310-3.patch ___ Python tracker ___

[issue29381] Tutorial documentation contains undefined reference to #!

2017-01-28 Thread Jim Fasarakis-Hilliard
Jim Fasarakis-Hilliard added the comment: Indeed, this does create an issue. The last sentence in the documentation actually specifies where the encoding comment can be but doesn't strictly specify it can be on the second line if and only if preceded by `#!`. I'm thinking the last sentence

[issue29381] Tutorial documentation contains undefined reference to #!

2017-01-28 Thread Marco Buttu
Marco Buttu added the comment: You wrote: "It is also possible to specify a different encoding for source files. In order to do this, you can use a special comment line that defines the source file encoding::". I think that is not true, because the line have to be the first line, or right

[issue27200] make doctest in CPython has failures

2017-01-28 Thread Marco Buttu
Marco Buttu added the comment: In order for the patches to work for every Python version (see #msg284622 ), I added a new feature to the Sphinx doctest extension, called pyversion. Starting from Sphinx 1.6, it will be possible to specify the Python version in order for the example to be

[issue28055] pyhash's siphash24 assumes alignment of the data pointer

2017-01-28 Thread Antoine Pitrou
Antoine Pitrou added the comment: I agree with Stefan and Serhiy. Unaligned memoryviews shouldn't trigger a copy when hashing. -- nosy: +pitrou ___ Python tracker

[issue29302] add contextlib.AsyncExitStack

2017-01-28 Thread Vedran Čačić
Vedran Čačić added the comment: An example from "real life": I recently needed this when implementing a demo of dining philosophers using asyncio (when the order of locks should depend on comparison of fork ids, not be static). Of course, it wasn't hard to implement it directly, but still, it

[issue29381] Tutorial documentation contains undefined reference to #!

2017-01-28 Thread Jim Fasarakis-Hilliard
Jim Fasarakis-Hilliard added the comment: Hi, Raymond. Is Mariatta responsible for reviewing Documentation submissions? If so, should I nosy Mariatta in any future documentation issues? -- ___ Python tracker

[issue10544] yield expression inside generator expression does nothing

2017-01-28 Thread Armin Rigo
Armin Rigo added the comment: Let's see if the discussion goes anywhere or if this issue remains in limbo for the next 7 years. In the meantime, if I may humbly make a suggestion: whether the final decision is to give SyntaxError or change the semantics, one or a few intermediate versions

[issue10544] yield expression inside generator expression does nothing

2017-01-28 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: > How about fixing CPython to raise SyntaxWarning or even SyntaxError? I think it is better to just fix the issue, i.e. make comprehensions be equivalent to for-loops even if they contain `yield`. (In particular this will lead to [(yield i) for i in

[issue10544] yield expression inside generator expression does nothing

2017-01-28 Thread Armin Rigo
Armin Rigo added the comment: Just to add my comment to this 7-years-old never-resolved issue: in PyPy 3.5, which behaves like Python 3.x in this respect, I made the following constructions give a warning. def wrong_listcomp(): return [(yield 42) for i in j] def

[issue29310] Document typing.NamedTuple default argument syntax

2017-01-28 Thread Ivan Levkivskyi
Ivan Levkivskyi added the comment: I have found one typo (see Rietveld), otherwise LGTM. -- ___ Python tracker ___

[issue29366] os.listdir has inconsistent behavior when run on a non-directory

2017-01-28 Thread Eryk Sun
Eryk Sun added the comment: Python has no specific use for ERROR_PATH_NOT_FOUND (3) and just maps it to FileNotFoundError -- like the CRT maps it to ENOENT. Even if we wanted listdir() to specially handle this error, given that it's implemented via FindFirstFile, there's nothing that can be