[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

2018-08-21 Thread miss-islington
miss-islington added the comment: New changeset 0ef61ee7b194a1c15747d6bca3cf30a5c581e7e3 by Miss Islington (bot) in branch '3.6': bpo-34457: Python/ast.c: Add missing NULL check to alias_for_import_name(). (GH-8852)

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

2018-08-21 Thread miss-islington
miss-islington added the comment: New changeset b8e7319d39bf44355bf60f9bbec07cfbbe56739d by Miss Islington (bot) in branch '3.7': bpo-34457: Python/ast.c: Add missing NULL check to alias_for_import_name(). (GH-8852)

[issue34456] pickle: Missing NULL check in save_global()

2018-08-21 Thread miss-islington
miss-islington added the comment: New changeset b14a68fd7d8f02bd133b59709f969c1c564f5978 by Miss Islington (bot) in branch '3.6': bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851) https://github.com/python/cpython/commit/b14a68fd7d8f02bd133b59709f969c1c564f5978

[issue34456] pickle: Missing NULL check in save_global()

2018-08-21 Thread miss-islington
miss-islington added the comment: New changeset 3152bc36fd1a8ab349d6802e9b48dd88a35b3620 by Miss Islington (bot) in branch '3.7': bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851) https://github.com/python/cpython/commit/3152bc36fd1a8ab349d6802e9b48dd88a35b3620

[issue34400] Undefined behavior in Parser/parsetok.c

2018-08-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset eb9a1c01d07309006ef5544da62ba813685bd098 by Serhiy Storchaka (Zackery Spytz) in branch '2.7': [2.7] bpo-34400: Fix more undefined behavior in parsetok.c (GH-8833). (GH-8849)

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

2018-08-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +8328 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

2018-08-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 28853a249b1d0c890b7e9ca345290bb8c1756446 by Serhiy Storchaka (Alexey Izbyshev) in branch 'master': bpo-34457: Python/ast.c: Add missing NULL check to alias_for_import_name(). (GH-8852)

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

2018-08-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +8327 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34456] pickle: Missing NULL check in save_global()

2018-08-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +8326 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34456] pickle: Missing NULL check in save_global()

2018-08-21 Thread miss-islington
Change by miss-islington : -- pull_requests: +8325 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34456] pickle: Missing NULL check in save_global()

2018-08-21 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset f8c06b028036e50596e75d4c9f6b27ba05133efe by Serhiy Storchaka (Alexey Izbyshev) in branch 'master': bpo-34456: pickle: Add missing NULL check to save_global(). (GH-8851)

[issue34455] Tkinter crashing when pressing Command + ^ (OSX)

2018-08-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: PS, When replaying by email, please delete the quoted message, as it is redundant in the web page display. -- ___ Python tracker ___

[issue34455] Tkinter crashing when pressing Command + ^ (OSX)

2018-08-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: Please download and run https://bugs.python.org/file47676/tk_scroll.py. It is a very stripped-down version of an IDLE editor window. After making a couple of edits, to make sure it is working, hit the fatal key combination. Does it still crash?

[issue34410] Segfault/TimeoutError: itertools.tee of multiprocessing.pool.imap_unordered

2018-08-21 Thread Carlo Rosati
Carlo Rosati added the comment: If what you've said is correct, would it make the most sense to create a Manager method which returns a Proxy to a tee'd iterator? -- ___ Python tracker

[issue34458] No way to alternate options

2018-08-21 Thread Victor Porton
New submission from Victor Porton : I have: parser.add_argument('-p', '--preload', help='preload asset', action='append', metavar='NAMESPACE') I want also add: parser.add_argument('-f', '--file', help='preload file', action='append', metavar='FILE', dest='preload') This way I could

[issue34454] datetime: NULL dereference in fromisoformat() on PyUnicode_AsUTF8AndSize() failure

2018-08-21 Thread Paul Ganssle
Paul Ganssle added the comment: > Note that technically a difference between C and Python implementation of > fromisoformat() will still remain: if a part of the input string before or > after the separator contains surrogates, the C code will throw a > UnicodeEncodeError while the Python

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

2018-08-21 Thread Alexey Izbyshev
Change by Alexey Izbyshev : -- keywords: +patch pull_requests: +8324 stage: -> patch review ___ Python tracker ___ ___

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

2018-08-21 Thread Alexey Izbyshev
Alexey Izbyshev added the comment: The NULL dereference seems to be hard to trigger due to caching for one-character Latin-1 strings, but being safe probably won't hurt. -- ___ Python tracker

[issue34457] Missing NULL check in alias_for_import_name() from Python/ast.c

2018-08-21 Thread Alexey Izbyshev
New submission from Alexey Izbyshev : The return value of PyUnicode_InternFromString() is dereferenced without checking at https://github.com/python/cpython/blob/ef8861c112ed1dac9351958c121bc24ca4ecdb08/Python/ast.c#L3256 Reported by Svace static analyzer. -- components: Interpreter

[issue34456] pickle: Missing NULL check in save_global()

2018-08-21 Thread Alexey Izbyshev
Change by Alexey Izbyshev : -- keywords: +patch pull_requests: +8323 stage: -> patch review ___ Python tracker ___ ___

[issue34456] pickle: Missing NULL check in save_global()

2018-08-21 Thread Alexey Izbyshev
New submission from Alexey Izbyshev : The return value of Py_BuildValue() is dereferenced without checking at https://github.com/python/cpython/blob/ef8861c112ed1dac9351958c121bc24ca4ecdb08/Modules/_pickle.c#L3457 Reported by Svace static analyzer. -- components: Extension Modules

[issue34455] Tkinter crashing when pressing Command + ^ (OSX)

2018-08-21 Thread iPodClassic
iPodClassic added the comment: Hello Terry. I installed 3.7 from Python.org First time it crashed, I was playing around with some basic code (I’m learning), whilst trying to enter [ character (which is option + ^key in spanish keyboard), by mistake I pressed command (key next to option) and

[issue34455] Tkinter crashing when pressing Command + ^ (OSX)

2018-08-21 Thread Terry J. Reedy
Terry J. Reedy added the comment: I believe NSException crashes are due to interaction between tcl/tk and the Mac graphics subsystem, in this case for 10.11.6. Did you install 3.7 with the python.org installer or something else? How did you start IDLE and what state was it in when you hit

[issue34446] ambiguous _max_size parameter in SpooledTemporaryFile

2018-08-21 Thread jcc2220
jcc2220 added the comment: Here's an example of the inconsistency - if SpooledTemporaryFile is instantiated with max_size set to 0, it will not rollover, EXCEPT when truncate method is called. Both write and writelines (public methods) call _check, which deals with rollover, but _check

[issue34454] datetime: NULL dereference in fromisoformat() on PyUnicode_AsUTF8AndSize() failure

2018-08-21 Thread Alexey Izbyshev
Alexey Izbyshev added the comment: I will be glad to rebase my PR and remove the try/except from the test if you remove the dependency of separator searching code on PyUnicode_AsUTF8AndSize() as you suggest. Or we can go the other way and merge mine first -- whatever you prefer. Note that

[issue34455] IDLE crashing when pressing Command + ^ (OSX)

2018-08-21 Thread iPodClassic
New submission from iPodClassic : IDLE crashes when pressing Command (⌘) + ^ I have attached the crash report just in case. -- assignee: terry.reedy components: IDLE files: crash report idle.txt messages: 323848 nosy: iPodClassic, terry.reedy priority: normal severity: normal status:

[issue14841] os.get_terminal_size() should check stdin as a fallback

2018-08-21 Thread Eryk Sun
Eryk Sun added the comment: The Windows implementation shouldn't map file-descriptor values 0, 1, and 2 to the process standard handles. fileno(stdout) may not even be 1 in some cases. It should use `handle = _get_osfhandle(fd)`, which is more generally correct and not limited to hard-coded

[issue34454] datetime: NULL dereference in fromisoformat() on PyUnicode_AsUTF8AndSize() failure

2018-08-21 Thread Paul Ganssle
Paul Ganssle added the comment: So this is related to something I was actually meaning to fix. When I wrote this code I didn't understand the way PyUnicode works, there's actually no need to call `PyUnicode_AsUTF8AndSize()` on the entire unicode string. My understanding is that each glyph

[issue34446] ambiguous _max_size parameter in SpooledTemporaryFile

2018-08-21 Thread Brett Cannon
Brett Cannon added the comment: Do realize that anything which starts with an underscore, like _check, is considered a private API. -- nosy: +brett.cannon ___ Python tracker

[issue34454] datetime: NULL dereference in fromisoformat() on PyUnicode_AsUTF8AndSize() failure

2018-08-21 Thread Alexey Izbyshev
Change by Alexey Izbyshev : -- keywords: +patch pull_requests: +8322 stage: -> patch review ___ Python tracker ___ ___

[issue34454] datetime: NULL dereference in fromisoformat() on PyUnicode_AsUTF8AndSize() failure

2018-08-21 Thread Alexey Izbyshev
New submission from Alexey Izbyshev : A failure of PyUnicode_AsUTF8AndSize() in various fromisoformat() functions in Modules/_datetimemodule.c leads to NULL dereference due to the missing check, e.g.: >>> from datetime import date >>> date.fromisoformat('\ud800') Segmentation fault (core

[issue34453] ipaddress module accepts some strange IPv6 addresses that it shouldn't

2018-08-21 Thread Luke Kenneth Casson Leighton
New submission from Luke Kenneth Casson Leighton : adding some unit tests to some code being written, searched randomly on the internet for an IPv6 test suite and found one in php *shudder* # https://github.com/gws/ipv6-address-test/blob/master/Tests/Ipv6TestCase.php converted it to python,

[issue14841] os.get_terminal_size() should check stdin as a fallback

2018-08-21 Thread Mark Lawrence
Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34452] docs: help text for [>>>] toggle always in English

2018-08-21 Thread Jonathan Fine
Jonathan Fine added the comment: Thank you. I've raised "The help text for [>>>] toggle always in English" https://github.com/python/python-docs-theme/issues/23 -- ___ Python tracker

[issue34452] docs: help text for [>>>] toggle always in English

2018-08-21 Thread Mariatta Wijaya
Change by Mariatta Wijaya : -- status: pending -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34452] docs: help text for [>>>] toggle always in English

2018-08-21 Thread Mariatta Wijaya
Mariatta Wijaya added the comment: The help text that says "Show the prompts and output" comes from python-docs-theme, and it is tracked in a separate repo: https://github.com/python/python-docs-theme/ Not sure if there's any customization that we can do here. I suggest raising the issue

[issue34452] docs: help text for [>>>] toggle always in English

2018-08-21 Thread Jonathan Fine
New submission from Jonathan Fine : As subject. Background information in #34451. See https://docs.python.org/fr/3/tutorial/introduction.html The hover help text for the [>>>] is in English, not French. Korean and Japanese documentation has the same problem. -- assignee: docs@python

[issue34451] docs: tutorial/introduction doesn't mention toggle of prompts

2018-08-21 Thread Jonathan Fine
New submission from Jonathan Fine : Interactive code examples need the prompt to be stripped, before copy-and-paste. This is explained in https://docs.python.org/3/tutorial/introduction.html But this page does not tell us about the [>>>] prompt-toggle at top of each interactive code

[issue34417] imp.find_module reacts badly to iterator

2018-08-21 Thread Phillip M. Feldman
Phillip M. Feldman added the comment: My apologies for the tone of my remark. I am grateful to you and others who donate their time to develop the code. I'm attaching the wrapper code that I created to work around the problem. Phillip def expander(paths='./*'): """ OVERVIEW This

[issue34417] imp.find_module reacts badly to iterator

2018-08-21 Thread Brett Cannon
Brett Cannon added the comment: Saying "the available functionality is massively inefficient" is unnecessarily hostile towards those of us who actually wrote and maintain that code. Without diving into the code, chances are that requirement is there so that the C code can use macros to

[issue14841] os.get_terminal_size() should check stdin as a fallback

2018-08-21 Thread Grant Jenks
Grant Jenks added the comment: I asked on the ncurses maintainers email list about their logic and was pointed to tty_settings.c which checks: 1. stderr 2. stdout 3. stdin 4. open('/dev/tty', 'r+') I don't know a cross-platform way to check #4 but I think #1-3 are a reasonable change to

[issue34400] Undefined behavior in Parser/parsetok.c

2018-08-21 Thread Zackery Spytz
Change by Zackery Spytz : -- pull_requests: +8321 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34450] improve shutil.make_archive

2018-08-21 Thread Emily Morehouse
Emily Morehouse added the comment: I'll have to think through this a bit more, but my gut is that it would be much more favorable for backwards-compatibility to clarify the documentation instead of changing the functionality. In any case, the change would only take effect in 3.8+, so it

[issue34207] test_cmd_line test_utf8_mode test_warnings fail in all FreeBSD 3.x (3.8) buildbots

2018-08-21 Thread Łukasz Langa
Łukasz Langa added the comment: Looking at what's going on here, this is quite possibly a PEP 538 side-effect (I see surrogate escapes). -- ___ Python tracker ___

[issue34207] test_cmd_line test_utf8_mode test_warnings fail in all FreeBSD 3.x (3.8) buildbots

2018-08-21 Thread Łukasz Langa
Change by Łukasz Langa : -- nosy: +ncoghlan ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34207] test_cmd_line test_utf8_mode test_warnings fail in all FreeBSD 3.x (3.8) buildbots

2018-08-21 Thread Łukasz Langa
Łukasz Langa added the comment: I think the root cause is this: the mentioned tests are invalid when no LC_* or LANG environment variables are present. Michael's sleuthing in issue34347 might provide a way for us to fix those. As a workaround in the mean time, if this is an option on your

[issue34207] test_cmd_line test_utf8_mode test_warnings fail in all FreeBSD 3.x (3.8) buildbots

2018-08-21 Thread Łukasz Langa
Łukasz Langa added the comment: This is definitely dependent on the environment. I can reproduce exactly the same failures on a CentOS 7 box at work, too. -- nosy: +lukasz.langa ___ Python tracker

[issue34347] AIX: test_utf8_mode.test_cmd_line fails

2018-08-21 Thread Łukasz Langa
Change by Łukasz Langa : -- keywords: +3.7regression ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34403] test_utf8_mode.test_cmd_line() fails on HP-UX due to false assumptions

2018-08-21 Thread Łukasz Langa
Change by Łukasz Langa : -- keywords: +3.7regression versions: -Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34207] test_cmd_line test_utf8_mode test_warnings fail in all FreeBSD 3.x (3.8) buildbots

2018-08-21 Thread Łukasz Langa
Change by Łukasz Langa : -- keywords: +3.7regression versions: +Python 3.7 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34403] test_utf8_mode.test_cmd_line() fails on HP-UX due to false assumptions

2018-08-21 Thread Łukasz Langa
Change by Łukasz Langa : -- dependencies: +test_cmd_line test_utf8_mode test_warnings fail in all FreeBSD 3.x (3.8) buildbots ___ Python tracker ___

[issue34347] AIX: test_utf8_mode.test_cmd_line fails

2018-08-21 Thread Łukasz Langa
Change by Łukasz Langa : -- dependencies: +test_cmd_line test_utf8_mode test_warnings fail in all FreeBSD 3.x (3.8) buildbots ___ Python tracker ___

[issue34347] AIX: test_utf8_mode.test_cmd_line fails

2018-08-21 Thread Łukasz Langa
Łukasz Langa added the comment: I have no idea what's going on here yet but just wanted to report that we are seeing this issue on one FreeBSD buildbot, too: https://buildbot.python.org/all/#/builders/124/builds/508/steps/4/logs/stdio I can also reproduce on CentOS 7. Could this be related

[issue34194] test_ssl, AIX, and defaults for _ssl connections

2018-08-21 Thread Michael Felt
Michael Felt added the comment: On 21/08/2018 09:46, Michael wrote: > On 04/08/2018 16:37, Michael Felt wrote: >> Some help would really be appreciated! > Gotten a bit further :) A little bit more: Modules/_ssl.c  +3707  fprintf(stderr,"load_cert_chain():certfile:%s\n", (char *)

[issue34450] improve shutil.make_archive

2018-08-21 Thread iMath
New submission from iMath : The current behavior of shutil.make_archive caused many issues , the problem is mainly on the extracted archive directory hierarchy. These are the proofs: https://stackoverflow.com/questions/51914467/directory-hierarchy-issue-when-using-shutil-make-archive

[issue34434] Removal of kwargs for built-in types not covered with "changed in Python" note in documentation

2018-08-21 Thread Louis Sautier
Change by Louis Sautier : -- keywords: +patch pull_requests: +8320 stage: -> patch review ___ Python tracker ___ ___

[issue34410] Segfault/TimeoutError: itertools.tee of multiprocessing.pool.imap_unordered

2018-08-21 Thread Xiang Zhang
Xiang Zhang added the comment: Ahh, the infinite iterator could also releases GIL in `PyIter_Next`. -- ___ Python tracker ___ ___

[issue34449] HP aCC complains about invalid -fPIC on HP-UX

2018-08-21 Thread Michael Osipov
Change by Michael Osipov <1983-01...@gmx.net>: -- keywords: +patch pull_requests: +8319 stage: -> patch review ___ Python tracker ___

[issue34449] HP aCC complains about invalid -fPIC on HP-UX

2018-08-21 Thread Michael Osipov
New submission from Michael Osipov <1983-01...@gmx.net>: The compiler (HP aCC) says: > /opt/aCC/bin/cc -Ae -b -L/usr/local/lib/hpux32 > build/temp.hp-ux-B.11.31-ia64-3.8-pydebug/var/osipovmi/cpython/Modules/_ctypes/_ctypes.o > >

[issue34404] test_time incorrectly defined

2018-08-21 Thread Michael Osipov
Change by Michael Osipov <1983-01...@gmx.net>: -- versions: +Python 3.6, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list

[issue34448] incomplete/missing message from configure.ac for usable wchar_t

2018-08-21 Thread Michael Osipov
Change by Michael Osipov <1983-01...@gmx.net>: -- versions: +Python 3.6 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34401] Make test_gdb work on HP-UX

2018-08-21 Thread Michael Osipov
Change by Michael Osipov <1983-01...@gmx.net>: -- versions: +Python 3.6, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list

[issue34403] test_utf8_mode.test_cmd_line() fails on HP-UX due to false assumptions

2018-08-21 Thread Michael Osipov
Change by Michael Osipov <1983-01...@gmx.net>: -- versions: +Python 3.6, Python 3.8 ___ Python tracker ___ ___ Python-bugs-list

[issue34448] incomplete/missing message from configure.ac for usable wchar_t

2018-08-21 Thread Michael Osipov
Change by Michael Osipov <1983-01...@gmx.net>: -- keywords: +patch pull_requests: +8318 stage: -> patch review ___ Python tracker ___

[issue34448] incomplete/missing message from configure.ac for usable wchar_t

2018-08-21 Thread Michael Osipov
New submission from Michael Osipov <1983-01...@gmx.net>: If the wchar_t is usable on a system we get the following: > checking for UCS-4 tcl... no > checking whether wchar_t is signed... no > yes > checking whether byte ordering is bigendian... yes > checking ABIFLAGS... dm > checking SOABI...

[issue26544] platform.libc_ver() returns incorrect version number

2018-08-21 Thread Matthias Klose
Matthias Klose added the comment: +1 -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34194] test_ssl, AIX, and defaults for _ssl connections

2018-08-21 Thread Michael Felt
Michael Felt added the comment: On 04/08/2018 16:37, Michael Felt wrote: > Some help would really be appreciated! Gotten a bit further :) While it does not affect the 'failures', this change decreases 'errors' by 8 (skipped +1). I do not expect this to be 'acceptable' - however, I hope this

[issue26544] platform.libc_ver() returns incorrect version number

2018-08-21 Thread Marc-Andre Lemburg
Marc-Andre Lemburg added the comment: I added a comment to the PR, but other than that I think it's good to go. -- ___ Python tracker ___

[issue34443] enum repr should use __qualname__

2018-08-21 Thread underscore_asterisk
underscore_asterisk added the comment: Hi, I would like to work on this issue. I can submit a PR by tomorrow (or maybe even later today). -- nosy: +underscore_asterisk ___ Python tracker