[issue34736] Confusing base64.b64decode output

2018-09-27 Thread miss-islington
miss-islington added the comment: New changeset 1fba2ffc37da52c08db51fe4360459990b0311c9 by Miss Islington (bot) (Tal Einat) in branch 'master': bpo-34736: improve error message for invalid length b64decode inputs (GH-9563)

[issue34827] Make argparse.NameSpace iterable

2018-09-27 Thread Micheal Taylor
New submission from Micheal Taylor : There was an issue to make argparse.Namespace iterable with a specific intent on being able to convert it to a dictionary (https://bugs.python.org/issue8982). Additionally there was another improvement request to make it accessible like a dictionary.

[issue34826] io.BufferedReader crashes in 2.7 on memoryview attribute access

2018-09-27 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue27195] Crash when RawIOBase.write(b) evaluates b.format

2018-09-27 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34777] urllib.request accepts anything as a header parameter for some URLs

2018-09-27 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the details. Each server behaves differently for these headers which depends on the server configuration and using other client like curl will also return the same result as Python does. So I would propose closing it as not a bug since

[issue34751] Hash collisions for tuples

2018-09-27 Thread Tim Peters
Tim Peters added the comment: Also worth noting: other projects need to combine hashes too. Here's a 64-bit version of the highly regarded C++ Boost[1] library's hash_combine() function (I replaced its 32-bit int literal with "a random" 64-bit one): x ^= (Py_uhash_t)y +

[issue34751] Hash collisions for tuples

2018-09-27 Thread Tim Peters
Tim Peters added the comment: Perhaps worth noting that FNV-1a works great if used as _intended_: on a stream of unsigned bytes. All tests except the new tuple hash test suffer no collisions; the new test suffers 14. Nothing is needed to try to worm around nested tuple catastrophes, or

[issue34521] Multiple tests (test_socket, test_multiprocessing_*) fail due to incorrect recvmsg(2) buffer lengths, causing failures on FreeBSD CURRENT

2018-09-27 Thread Kubilay Kocak
Kubilay Kocak added the comment: To clarify affected tests/versions: Python 3.x - test_socket test_multiprocessing_spawn Python 2.7 - test_multiprocessing_spawn All of the issues are related to incorrect recvmsg(2) buffer length use, so I've amended the issue summary to describe the

[issue18578] Rename and document test.bytecode_helper as test.support.bytecode_helper

2018-09-27 Thread Cheryl Sabella
Cheryl Sabella added the comment: @seydou, would you be interested in making a GitHub pull request for your patch? -- assignee: -> docs@python components: +Documentation, Tests nosy: +cheryl.sabella, docs@python stage: -> needs patch type: -> enhancement versions: +Python 3.8

[issue34818] test.test_ssl.ThreadedTests.test_tls1_3 fails in 2.7 with AttributeError: __exit__

2018-09-27 Thread Dimitri John Ledkov
Dimitri John Ledkov added the comment: Similar client sockets are used in that file, but they are wrapped in extra `with closing(...) as s:` Is closing() wrapper missing in this test case? -- ___ Python tracker

[issue34521] test_socket.Recvmsg[Into]SCMRightsStreamTest tests fail on AMD64 FreeBSD CURRENT

2018-09-27 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +9012 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34521] test_socket.Recvmsg[Into]SCMRightsStreamTest tests fail on AMD64 FreeBSD CURRENT

2018-09-27 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +9012, 9013 ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue34826] io.BufferedReader crashes in 2.7 on memoryview attribute access

2018-09-27 Thread Zackery Spytz
Zackery Spytz added the comment: See #27195 and PR 8415. -- nosy: +ZackerySpytz ___ Python tracker ___ ___ Python-bugs-list

[issue34826] io.BufferedReader crashes in 2.7 on memoryview attribute access

2018-09-27 Thread Gregory P. Smith
New submission from Gregory P. Smith : The following test code segfaults on Python 2.7: ```python import io class X(io.RawIOBase): def readable(self): return True def readinto(self, b): if isinstance(b, memoryview): print(b.format) # XXX boom, crashes here. return 0

[issue32552] Improve text for file arguments in argparse.ArgumentDefaultsHelpFormatter class

2018-09-27 Thread paul j3
paul j3 added the comment: An alternative to customizing a HelpFormatter is to write your own utility `add_argument` function, e.g. def my_add_argument(parser, *args, add_default=True, **kwargs): if add_default: help = kwargs.get('help','') help += ' (default:

[issue34709] Suggestion: make getuser.getpass() also look at SUDO_USER environment variable

2018-09-27 Thread Amos S
Amos S added the comment: The use of environment variables like USER and LOGNAME instead of getuid() etc is done in order to try to get "who really initiated this process?" rather than "who this process belongs to?". This is hidden today when SUDO_USER is ignored. This also fits my

[issue32956] python 3 round bug

2018-09-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > the silent and subtle change in behaviour from Python 2 to Python 3 was a bit > unpleasant, and a possible source of late-discovered (or undiscovered) bugs. This change was advertised in the "What’s New In Python 3.0" document.

[issue34777] urllib.request accepts anything as a header parameter for some URLs

2018-09-27 Thread Jose Gama
Jose Gama added the comment: Thank you for the quick reply. You are correct about the difficulties of using a universally accepted list.This is one example that generates errors on the server side. Just for the record. #!/usr/bin/env python3 from urllib.request import Request, urlopenfrom

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread Gefn
Gefn added the comment: I think it's much clearer -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread Yury Selivanov
Change by Yury Selivanov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34248] dbm errors should contain file names

2018-09-27 Thread Berker Peksag
Change by Berker Peksag : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34248] dbm errors should contain file names

2018-09-27 Thread Berker Peksag
Berker Peksag added the comment: New changeset 9df346bf98069a87de14a3c2f69009d800994c63 by Berker Peksag (Zsolt Cserna) in branch 'master': bpo-34248: Add filename to error raised in {gnu,ndbm}.open() (GH-8590) https://github.com/python/cpython/commit/9df346bf98069a87de14a3c2f69009d800994c63

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread miss-islington
miss-islington added the comment: New changeset 85ccedc5b57ddda198e7176ba787e3896435c504 by Miss Islington (bot) in branch '3.7': bpo-34802: Fix asyncio.iscoroutine() docs (GH-9611) https://github.com/python/cpython/commit/85ccedc5b57ddda198e7176ba787e3896435c504 -- nosy:

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +9010 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 59ee5b12938efbf534f2a19300a847bf6b23a77d by Yury Selivanov in branch 'master': bpo-34802: Fix asyncio.iscoroutine() docs (GH-9611) https://github.com/python/cpython/commit/59ee5b12938efbf534f2a19300a847bf6b23a77d --

[issue7674] select.select() corner cases: duplicate fds, out-of-range fds

2018-09-27 Thread Berker Peksag
Change by Berker Peksag : -- nosy: +berker.peksag ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: I'll make a simple fix for the asyncio.coroutine decorator docs. > I would suggest below for #coroutines : >> Coroutines declared with async/await syntax is the preferred way of writing >> asyncio applications but asyncio also supports legacy

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread Yury Selivanov
Change by Yury Selivanov : -- keywords: +patch pull_requests: +9009 stage: -> patch review ___ Python tracker ___ ___

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: Thank you Serhiy, for re-opening this! I've pushed fixes to 3.7 and master branches. -- stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue34802] asyncio.iscoroutine() documentation is wrong

2018-09-27 Thread Brett Cannon
Change by Brett Cannon : -- nosy: +asvetlov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 24cb7de15d3a5979425b281ab4f600f7c2b401f2 by Yury Selivanov in branch '3.7': [3.7] bpo-34762: Update PyContext* refs to PyObject* in asyncio and decimal (GH-9610) https://github.com/python/cpython/commit/24cb7de15d3a5979425b281ab4f600f7c2b401f2

[issue34533] Apply PEP384 to _csv module

2018-09-27 Thread Berker Peksag
Berker Peksag added the comment: This is a duplicate of issue 14935. Could you please retarget PR 8977 against issue 14935? -- nosy: +berker.peksag resolution: -> duplicate stage: patch review -> resolved status: open -> closed superseder: -> PEP 384 Refactoring applied to _csv

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Change by Yury Selivanov : -- pull_requests: +9008 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34751] Hash collisions for tuples

2018-09-27 Thread Tim Peters
Tim Peters added the comment: I should have spelled this out before: these are all permutations, so in general permuting the result space of `x * mult + y` (or any other permutation involving x and y) is exactly the same as not permuting it but applying a different permutation to y

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: New changeset 994269ccee5574f03cda6b018399347fc52bf330 by Yury Selivanov in branch 'master': bpo-34762: Update PyContext* to PyObject* in asyncio and decimal (GH-9609) https://github.com/python/cpython/commit/994269ccee5574f03cda6b018399347fc52bf330

[issue32956] python 3 round bug

2018-09-27 Thread Mark Dickinson
Mark Dickinson added the comment: [Joshua] > 1. Update the round() docs to make the documentation of this behavior less > buried, Sounds reasonable to me; I'm definitely open to documentation improvements. Though it doesn't seem all that buried to me: the round-ties-to-even behaviour is

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Change by Yury Selivanov : -- pull_requests: +9007 stage: resolved -> patch review ___ Python tracker ___ ___ Python-bugs-list

[issue34820] binascii.c:1578:1: error: the control flow of function ‘binascii_crc32’ does not match its profile data (counter ‘arcs’)

2018-09-27 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report. * Can you please add the OS, GCC details, full traceback and command that triggers the error? * Is it consistent? * Are you adding a flag to treat all the warnings as errors? I assume you are running PGO. As I can see on

[issue34820] binascii.c:1578:1: error: the control flow of function ‘binascii_crc32’ does not match its profile data (counter ‘arcs’)

2018-09-27 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34821] Crash after run Python interpreter from removed directory

2018-09-27 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Just installed Python 3.4 and can confirm this is fixed in 3.5 but exists on Python 3.4.9 though I don't receive any segfaults though as in the picture with 3.4. karthi@ubuntu-s-1vcpu-1gb-blr1-01:~$ mkdir /tmp/foo

[issue34825] Add more entries to os module to pathlib reference table

2018-09-27 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- keywords: +patch pull_requests: +9006 stage: -> patch review ___ Python tracker ___ ___

[issue34022] 6 tests fail using SOURCE_DATE_EPOCH env var

2018-09-27 Thread Elvis Pranskevichus
Elvis Pranskevichus added the comment: https://github.com/python/cpython/pull/9607 turns SOURCE_DATE_EPOCH into a *default* rather than absolute override. test_cmd_line_script and test_runpy fail due to the lack of support for hash-based .pycs in zipimport, which needs fixing also.

[issue34825] Add more entries to os module to pathlib reference table

2018-09-27 Thread Karthikeyan Singaravelan
New submission from Karthikeyan Singaravelan : I found issue33194 where unlink from pathlib can be used to delete a file or symlink similar to os.unlink or os.remove but the visibility for the function was low. I found there is a reference table with os module functions and their equivalent

[issue34821] Crash after run Python interpreter from removed directory

2018-09-27 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report and steps. Can you try this on Python 3.5 ? I think this is the related issue issue22834 that was not fixed in Python 3.4 and has the same line numbers. I can't reproduce this on my Ubuntu machine with Python 3.6.5 from

[issue34821] Crash after run Python interpreter from removed directory

2018-09-27 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Yury Selivanov
Yury Selivanov added the comment: Right, I'll make a PR. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34762] Change contextvars C API to use PyObject

2018-09-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: Perhaps this change caused new compiler warnings: In file included from ./Include/pytime.h:6:0, from ./Include/Python.h:68, from /home/serhiy/py/cpython/Modules/_asynciomodule.c:1:

[issue29708] support reproducible Python builds

2018-09-27 Thread Elvis Pranskevichus
Change by Elvis Pranskevichus : -- pull_requests: +9005 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34022] 6 tests fail using SOURCE_DATE_EPOCH env var

2018-09-27 Thread Elvis Pranskevichus
Change by Elvis Pranskevichus : -- pull_requests: +9004 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34824] _ssl.c: Possible null pointer dereference

2018-09-27 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +9003 stage: -> patch review ___ Python tracker ___ ___

[issue34822] Simplify AST for slices

2018-09-27 Thread Serhiy Storchaka
Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +9002 stage: -> patch review ___ Python tracker ___ ___

[issue34824] _ssl.c: Possible null pointer dereference

2018-09-27 Thread Yury Selivanov
Change by Yury Selivanov : -- nosy: +yselivanov ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34824] _ssl.c: Possible null pointer dereference

2018-09-27 Thread Zackery Spytz
New submission from Zackery Spytz : If _PyBytes_Resize() fails in _ssl_MemoryBIO_read_impl(), Py_DECREF() will be called on a null pointer. -- assignee: christian.heimes components: Extension Modules, SSL messages: 326573 nosy: ZackerySpytz, christian.heimes priority: normal severity:

[issue34776] Postponed annotations break inspection of dataclasses

2018-09-27 Thread INADA Naoki
Change by INADA Naoki : -- nosy: +inada.naoki ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34823] libffi detection doesn’t work in my setup

2018-09-27 Thread Michael Stapelberg
New submission from Michael Stapelberg : (Tested with Python 3.7, but AFAICT, the situation hasn’t changed in Python 3.8.) Python’s configure tries to fill the LIBFFI_INCLUDEDIR system variable with the value of -I as returned by pkg-config libffi --cflags-only-I. Python’s setup.py tries to

[issue34803] argparse int type does not accept scientific notation

2018-09-27 Thread paul j3
Change by paul j3 : -- resolution: -> not a bug stage: -> resolved status: open -> closed ___ Python tracker ___ ___

[issue34776] Postponed annotations break inspection of dataclasses

2018-09-27 Thread Ivan Levkivskyi
Change by Ivan Levkivskyi : -- nosy: +levkivskyi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34815] Change Py_Ellipse __str__ behavior.

2018-09-27 Thread tom.r
tom.r added the comment: That's understandable. Thanks for considering it, closing the patch. -- stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34822] Simplify AST for slices

2018-09-27 Thread Serhiy Storchaka
New submission from Serhiy Storchaka : Currently an AST for expressions can have non-terminal nodes of two types: expr and slice. Every of them can be a one of several kinds. A slice can be of kind Index (just an expression), Slice (optional expressions separated by ":") or ExtSlice (slices

[issue34700] typing.get_type_hints doesn't know about typeshed

2018-09-27 Thread Ivan Levkivskyi
Change by Ivan Levkivskyi : -- assignee: -> levkivskyi ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34521] test_socket.Recvmsg[Into]SCMRightsStreamTest tests fail on AMD64 FreeBSD CURRENT

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: Is test_socket of Python 2.7 affected by the issue? If not, I suggest to remove 2.7 from this issue and close it. -- ___ Python tracker ___

[issue32892] Remove specific constant AST types in favor of ast.Constant

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: Thank you Serhiy :-D I really love ast.Constant, it simplify many things when writing code modifying the AST. -- ___ Python tracker ___

[issue34821] Crash after run Python interpreter from removed directory

2018-09-27 Thread Игорь Никитин
New submission from Игорь Никитин : How to repeat: see screen. For example, command "lsb_release" is also not found removed directory, but there is no crash. Python2, in this case, run without problem. -- files: python_bug.png messages: 326567 nosy: Игорь Никитин priority: normal

[issue32892] Remove specific constant AST types in favor of ast.Constant

2018-09-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: New changeset 3f22811fef73aec848d961593d95fa877f77ecbf by Serhiy Storchaka in branch 'master': bpo-32892: Use ast.Constant instead of specific constant AST types. (GH-9445) https://github.com/python/cpython/commit/3f22811fef73aec848d961593d95fa877f77ecbf

[issue32892] Remove specific constant AST types in favor of ast.Constant

2018-09-27 Thread Serhiy Storchaka
Serhiy Storchaka added the comment: > Since Python 3.6 ;-) Thank you for correction Victor. It is what I meant. Why I had written 3.8? :-? -- ___ Python tracker ___

[issue34815] Change Py_Ellipse __str__ behavior.

2018-09-27 Thread Guido van Rossum
Guido van Rossum added the comment: I'm against this. The str() and repr() of Ellipsis are 'Ellipsis' for a reason: to remind the user that this is "just" an object, not a piece of special syntax. -- ___ Python tracker

[issue34820] binascii.c:1578:1: error: the control flow of function ‘binascii_crc32’ does not match its profile data (counter ‘arcs’)

2018-09-27 Thread wencan
New submission from wencan : git version: a94ee12c26aa8dd7dce01373779df8055aff765b /home/wencan/Projects/github.com/python/cpython/Modules/binascii.c: In function ‘binascii_crc32’: /home/wencan/Projects/github.com/python/cpython/Modules/binascii.c:1578:1: error: the control flow of function

[issue34521] test_socket.Recvmsg[Into]SCMRightsStreamTest tests fail on AMD64 FreeBSD CURRENT

2018-09-27 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: It looks like the test_socket is fixed but some related issues are still left in multiprocessing. -- ___ Python tracker ___

[issue34521] test_socket.Recvmsg[Into]SCMRightsStreamTest tests fail on AMD64 FreeBSD CURRENT

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: Commit merged into master: commit 7291108d88ea31d205da4db19d202d6cbffc6d93 Author: Pablo Galindo Date: Thu Sep 27 10:25:03 2018 +0100 Fix tests in test_socket to use correctly CMSG_LEN (GH-9594) After some failures in AMD64 FreeBSD CURRENT

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread Matthias Klose
Matthias Klose added the comment: Debian/Ubuntu doesn't link against the library because it would add dependencies on all supported Python versions. Normally this is just during transition times, but e.g. for the upcoming Ubuntu 18.10 release we didn't finish the transition and so ship two

[issue34370] Tkinter scroll issues on macOS

2018-09-27 Thread Kevin Walzer
Kevin Walzer added the comment: Ned, please hold off a bit on this--another developer is doing some final fine-tuning of the scrolling code so it fully passes Tk's test suite. I'm waiting for the final commit of this code any day now. -- status: pending -> open

[issue34763] Python lacks 0x4E17

2018-09-27 Thread Steven D'Aprano
Change by Steven D'Aprano : -- nosy: +steven.daprano ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34709] Suggestion: make getuser.getpass() also look at SUDO_USER environment variable

2018-09-27 Thread Steven D'Aprano
Steven D'Aprano added the comment: Versions 3.7 and below are all in feature-freeze, so this change could only apply to 3.8 and above. I don't know if this feature is desirable or not. If it is (sometimes?) desirable, my guess is that it would be undesirable to use SUDO_USER *unless* the

[issue34816] ctypes + hasattr

2018-09-27 Thread Lars Friedrich
Lars Friedrich added the comment: Thank you for your reply. I am not sure if I understood correctly: Do you suggest to modify ctypes.__init__.py so that the __getattr__ method of LibraryLoader catches the OSError and raises an AttributeError instead, as in your example? --

[issue34816] ctypes + hasattr

2018-09-27 Thread Eryk Sun
Eryk Sun added the comment: ctypes.windll is an instance of ctypes.LibraryLoader, which has a __getattr__ method that calls ctypes.WinDLL(name) and caches the result as an instance attribute. I suppose with chained exceptions it's reasonable to handle OSError in __getattr__ by raising

[issue34576] [EASY doc] http.server, SimpleHTTPServer: warn users on security

2018-09-27 Thread Felipe Rodrigues
Felipe Rodrigues added the comment: Well, even if we do fix some security issues in SimpleHTTPServer, it doesn't change the fact that it shouldn't really be used for sensitive applications. I like how Django docs handles a similar issue regarding their development server

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread miss-islington
miss-islington added the comment: New changeset 2b01121fd4200f1c27873422f7f72d02eec08630 by Miss Islington (bot) in branch '3.7': bpo-34819: Use a monotonic clock to compute timeouts in concurrent.futures (GH-9599)

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread Antoine Pitrou
Change by Antoine Pitrou : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread orlnub123
orlnub123 added the comment: Happy to help! I'm surprised it got merged so quickly, amazing response times all-around. -- ___ Python tracker ___

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread miss-islington
miss-islington added the comment: New changeset 3a4aa6ac55e04c42757443d5b5854b6d893e0461 by Miss Islington (bot) in branch '3.6': bpo-34819: Use a monotonic clock to compute timeouts in concurrent.futures (GH-9599)

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: But as you said, we need consistency: either *never* link to libpython, or *always* link to libpython. You are proposing to always link, I'm arguing we should never link. -- ___ Python tracker

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: Oh, I missed the Lib/concurrent/futures/ directory when I tried to patch the whole stdlib to use monotonic clocks for timeouts :-( Thanks for the fix! -- ___ Python tracker

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +9000 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +9001 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: New changeset a94ee12c26aa8dd7dce01373779df8055aff765b by Antoine Pitrou (orlnub123) in branch 'master': bpo-34819: Use a monotonic clock to compute timeouts in concurrent.futures (GH-9599)

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: > I'm not talking about the standard library obviously. I don't remember my > original use case exactly, but I must have been compiling a C extension on a > system and expected it to work on another. It seems like we are talking about two different things:

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: > Is it a real use case? Why would anyone use a RHEL binary on Debian? Debian > already provides the full standard library. I'm not talking about the standard library obviously. I don't remember my original use case exactly, but I must have been compiling

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: > It means a C extension compiled with a shared-library Python cannot be > imported on a monolithic Python (which doesn't have libpython.so). It's a > real problem when you want to redistribute compiled C extensions: if you > compile it on RedHat/CentOS,

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: > * FreeBSD 12 (alpha): Python 2.7 and Python 3.6 are linked to libpython > (--enable-shared) Note: _ctypes, _hashlib and _struct are all linked to libpython, on Python 2 and Python 3. Antoine: > Do you realize libpython.so doesn't exist on Debian /

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: Antoine: > Why do you call this a bug? "./configure --enable-shared && make" links C extensions to libpython. It's surprising that C extensions compiled by Makefile behave differently (not linked to libpython). We need consistency: either *never* link to

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: Extract of Antoine's comment on bpo-21536: > (AFAIK, systems notorious for providing shared library Pythons are > RedHat-alike systems, while Debian/Ubuntu provide statically linked Pythons) Oh. I didn't notice this major difference... * Ubuntu 16.04:

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Sorry, please ignore the comment reference to https://bugs.python.org/issue29733#msg289116 . I misunderstood that it was about concurrent.futures using time.time but it turns out it was about the program using time.time as verifying the PR against

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread Antoine Pitrou
Antoine Pitrou added the comment: Le 27/09/2018 à 12:49, STINNER Victor a écrit : > > I search if C extensions of the Python standard libraries are always linked > or not to libpython... it's complicated. I tested _ctypes, _hashlib and > _struct modules: > > * Debian and Ubuntu: NOT linked

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: Ah, it seems like the bpo-832799 (reported in 2003) is similar to the RHEL bug: https://bugzilla.redhat.com/show_bug.cgi?id=1585201 Extract of the RHEL bug report: --- pythontest.c: #include int main(int argc, char *argv[]) { void *pylib =

[issue34814] makesetup: must link C extensions to libpython when compiled in shared mode

2018-09-27 Thread STINNER Victor
STINNER Victor added the comment: I search if C extensions of the Python standard libraries are always linked or not to libpython... it's complicated. I tested _ctypes, _hashlib and _struct modules: * Debian and Ubuntu: NOT linked to libpython * Conda: LINKED to libpython * Mageia 7: LINKED

[issue34521] test_socket.Recvmsg[Into]SCMRightsStreamTest tests fail on AMD64 FreeBSD CURRENT

2018-09-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +8999 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue34521] test_socket.Recvmsg[Into]SCMRightsStreamTest tests fail on AMD64 FreeBSD CURRENT

2018-09-27 Thread miss-islington
Change by miss-islington : -- pull_requests: +8998 stage: backport needed -> patch review ___ Python tracker ___ ___

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Thanks for the report and PR. I can find a very similar issue where time.time was changed to time.monotonic across multiprocessing module by Victor for the same reason : issue34054. I don't know why it wasn't changed in concurrent.futures . Seems

[issue34521] test_socket.Recvmsg[Into]SCMRightsStreamTest tests fail on AMD64 FreeBSD CURRENT

2018-09-27 Thread Kubilay Kocak
Kubilay Kocak added the comment: Copying in my original email to Pablo that elucidated the test failure cause and resolution, including upstream commit/review/issue references for the recvmsg(2) changes IN CURRENT. Full buildbot worker log attached While I'm here, update list of versions

[issue34819] Executor.map and as_completed timeouts are able to deviate

2018-09-27 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +xtreak ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

  1   2   >