[issue37269] Python 3.8b1 miscompiles conditional expressions containing __debug__

2019-06-13 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- pull_requests: +13931 pull_request: https://github.com/python/cpython/pull/14073 ___ Python tracker ___

[issue37269] Python 3.8b1 miscompiles conditional expressions containing __debug__

2019-06-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +13930 pull_request: https://github.com/python/cpython/pull/14072 ___ Python tracker ___

[issue37269] Python 3.8b1 miscompiles conditional expressions containing __debug__

2019-06-13 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 05f831865545b08c9a21cfb7773af58b76ec64cb by Pablo Galindo in branch 'master': bpo-37269: Correctly optimise conditionals with constant booleans (GH-14071) https://github.com/python/cpython/commit/05f831865545b08c9a21cfb7773af58b76ec64cb

[issue37275] GetConsole(Output)CP is used even when stdin/stdout is redirected

2019-06-13 Thread Inada Naoki
New submission from Inada Naoki : When stdout is redirected to file and cp65001 is used, stdout encoding is unexpectable: # Power Shell 6 (use cp65001 by default) PS C:¥> python3 -c "print('おはよう')" > ps.txt # cmd.exe C:¥> chcp 65001 C:¥> python3 -c "print('おはよう')" > cmd.txt Now,

[issue37269] Python 3.8b1 miscompiles conditional expressions containing __debug__

2019-06-13 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +pablogsal ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37269] Python 3.8b1 miscompiles conditional expressions containing __debug__

2019-06-13 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +13929 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14071 ___ Python tracker

[issue37258] Logging cache not cleared properly when setting level

2019-06-13 Thread Raymond Hettinger
Change by Raymond Hettinger : -- assignee: -> vinay.sajip ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37274] Scripts folder is empty in python 3.7.3 for windows.

2019-06-13 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- components: +Windows nosy: +paul.moore, steve.dower, tim.golden, zach.ware ___ Python tracker ___

[issue37274] Scripts folder is empty in python 3.7.3 for windows.

2019-06-13 Thread Hansol Moon
New submission from Hansol Moon : I downloaded python 3.7.3 which is the latest version of python for windows. And I was going to download Pygame via pip in Python. and I found out that the scripts folder in Python is literally empty. so I was not able to use pip to install Pygame.. I tried

[issue37273] from pickle import rick

2019-06-13 Thread Aldwin Pollefeyt
Aldwin Pollefeyt added the comment: It is Pickle Rick from Rick and Morty. https://en.wikipedia.org/wiki/Pickle_Rick No need to be in python libraries. But you can make your own library on github with this kind of art. :) -- nosy: +aldwinaldwin

[issue37273] from pickle import rick

2019-06-13 Thread Steven D'Aprano
Steven D'Aprano added the comment: This looks like some sort of spam or joke. There's no explanation given of what this enhancement does, the PR seems to add only a rather suspicious looking triple-quoted string. (Possibly really bad ASCII art of a finger?) In the absence of any meaningful

[issue37273] from pickle import rick

2019-06-13 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: Can you please add a description over why you want to include the text in PR as part of pickle and the improvement it provides to the user? -- nosy: +xtreak ___ Python tracker

[issue37273] from pickle import rick

2019-06-13 Thread Luiz Amaral
Change by Luiz Amaral : -- type: -> enhancement ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37273] from pickle import rick

2019-06-13 Thread Luiz Amaral
New submission from Luiz Amaral : from pickle import rick print(rick) -- components: Library (Lib) messages: 345546 nosy: luxedo priority: normal pull_requests: 13928 severity: normal status: open title: from pickle import rick versions: Python 3.8

[issue9694] argparse required arguments displayed under "optional arguments"

2019-06-13 Thread paul j3
paul j3 added the comment: Mark, Have you tried defining your own Argument Group? If that didn't work, what fix do you want? Why? -- ___ Python tracker ___

[issue37272] pygit2 won't build

2019-06-13 Thread Dull Bananas
New submission from Dull Bananas : I am not sure if this is an issue with Python or pygit2, but Pyhton 3.8 and 3.9 are unable to build the pygit2 package, and an error with gcc occurs. This is causing errors on my Travis CI build; here is a link where you can see build logs for my project

[issue37271] Make multiple passes of the peephole optimizer until bytecode cannot be optimized further

2019-06-13 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- nosy: +serhiy.storchaka ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37271] Make multiple passes of the peephole optimizer until bytecode cannot be optimized further

2019-06-13 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +13927 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14068 ___ Python tracker

[issue37271] Make multiple passes of the peephole optimizer until bytecode cannot be optimized further

2019-06-13 Thread Pablo Galindo Salgado
New submission from Pablo Galindo Salgado : The peephole optimizer currently does not optimize the result of its own optimization when its possible. For example, consider the following code: if a: if b: if (c or d): foo() else: bar()

[issue9694] argparse required arguments displayed under "optional arguments"

2019-06-13 Thread Mark Grandi
Mark Grandi added the comment: Is there anything that can be done to help this issue move along? I just ran into it just now -- nosy: +markgrandi ___ Python tracker ___

[issue37077] Threading: add builtin TID attribute to Thread objects for AIX

2019-06-13 Thread miss-islington
miss-islington added the comment: New changeset 886d83e5aa8df2dd2e93421d2f614438a3244a1c by Miss Islington (bot) in branch '3.8': bpo-37077: Add native thread ID (TID) for AIX (GH-13624) https://github.com/python/cpython/commit/886d83e5aa8df2dd2e93421d2f614438a3244a1c --

[issue37077] Threading: add builtin TID attribute to Thread objects for AIX

2019-06-13 Thread Andrew Svetlov
Change by Andrew Svetlov : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.9 ___ Python tracker ___

[issue37077] Threading: add builtin TID attribute to Thread objects for AIX

2019-06-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +13926 pull_request: https://github.com/python/cpython/pull/14067 ___ Python tracker ___

[issue37077] Threading: add builtin TID attribute to Thread objects for AIX

2019-06-13 Thread miss-islington
miss-islington added the comment: New changeset d0eeb936d8daf05d7d89f6935e3f4c0dee49c5be by Miss Islington (bot) (Michael Felt) in branch 'master': bpo-37077: Add native thread ID (TID) for AIX (GH-13624) https://github.com/python/cpython/commit/d0eeb936d8daf05d7d89f6935e3f4c0dee49c5be

[issue37270] Manage memory lifetime for all type-related objects.

2019-06-13 Thread Joe Jevnik
Change by Joe Jevnik : -- keywords: +patch pull_requests: +13925 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14066 ___ Python tracker ___

[issue37270] Manage memory lifetime for all type-related objects.

2019-06-13 Thread Joe Jevnik
New submission from Joe Jevnik : When using PyType_FromSpec, the memory for PyType_Spec.name, Py_tp_methods, and Py_tp_members needs to somehow outlive the resulting type. This makes it hard to use this interface to generate types without just leaking the memory for these arrays, which is

[issue36710] Pass _PyRuntimeState as an argument rather than using the _PyRuntime global variable

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: I wrote my notes on this issue there: https://pythoncapi.readthedocs.io/runtime.html -- ___ Python tracker ___

[issue36710] Pass _PyRuntimeState as an argument rather than using the _PyRuntime global variable

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: New changeset 838f26402de82640698c38ea9d2be65c6cf780d6 by Victor Stinner in branch 'master': bpo-36710: Pass explicitly tstate in sysmodule.c (GH-14060) https://github.com/python/cpython/commit/838f26402de82640698c38ea9d2be65c6cf780d6 --

[issue37260] shutil.rmtree() FileNotFoundError race condition

2019-06-13 Thread Jeffrey Kintscher
Change by Jeffrey Kintscher : -- keywords: +patch pull_requests: +13924 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14064 ___ Python tracker

[issue37130] pathlib.Path.with_name() handles '.' and '..' inconsistently

2019-06-13 Thread Brett Cannon
Brett Cannon added the comment: @Antoine: Basically Path.with_name() fails under '.' but works with '..' although with a somewhat odd result. And then after that is the fact that Path('.').name is the empty string but for Path('..').name it's '..' (which is what causes Path('.').with_name()

[issue37213] Peeephole optimizer does not optimize functions with multiline expressions

2019-06-13 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: > Not unless someone can show how this is a major problem in 3.7 I would say is not a major problem in 3.7 I will close the issue then. Thanks everyone who participated! -- resolution: -> fixed stage: patch review -> resolved status: open

[issue37213] Peeephole optimizer does not optimize functions with multiline expressions

2019-06-13 Thread Ned Deily
Ned Deily added the comment: > Should we backport this to 3.7 as well? Not unless someone can show how this is a major problem in 3.7 and then only if the changes will not introduce any 3.7.x compatibility problems. -- nosy: +ned.deily ___ Python

[issue37269] Python 3.8b1 miscompiles conditional expressions containing __debug__

2019-06-13 Thread Marius Gedminas
New submission from Marius Gedminas : Python 3.8 miscompiles the following code: $ cat /tmp/wat.py enable_debug = False if not enable_debug or not __debug__: print("you shall not pass!") $ python3.7 /tmp/wat.py you shall not pass! $ python3.8 /tmp/wat.py (no

[issue37213] Peeephole optimizer does not optimize functions with multiline expressions

2019-06-13 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Should we backport this to 3.7 as well? -- ___ Python tracker ___ ___ Python-bugs-list

[issue37213] Peeephole optimizer does not optimize functions with multiline expressions

2019-06-13 Thread miss-islington
miss-islington added the comment: New changeset 5282b3b1d2e0bdf13899b1616aea20a6e3c4e13e by Miss Islington (bot) in branch '3.8': bpo-37213: Handle negative line deltas correctly in the peephole optimizer (GH-13969)

[issue37213] Peeephole optimizer does not optimize functions with multiline expressions

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: > The optimization is skipped if lnotab contains 255. It was very uncommon in > older versions (only when the function contains very large expressions, > larger than hundreds of lines or bytecode instructions), but in 3.8 this > situation is common. Do you

[issue37213] Peeephole optimizer does not optimize functions with multiline expressions

2019-06-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +13923 pull_request: https://github.com/python/cpython/pull/14063 ___ Python tracker ___

[issue37213] Peeephole optimizer does not optimize functions with multiline expressions

2019-06-13 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: New changeset 3498c642f4e83f3d8e2214654c0fa8e0d51cebe5 by Pablo Galindo in branch 'master': bpo-37213: Handle negative line deltas correctly in the peephole optimizer (GH-13969)

[issue36763] Implementation of the PEP 587

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: _PySys_ReadPreInitOptions() code should be moved somewhere closer to PyConfig_Read(). -- ___ Python tracker ___

[issue37241] Item Count Error in Shelf

2019-06-13 Thread SilentGhost
Change by SilentGhost : -- stage: -> resolved status: open -> closed ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue36763] Implementation of the PEP 587

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: Two interesting TODO. sysmodule.c: get_xoptions() /* PEP432 TODO: we can reach this if xoptions is NULL in the main * interpreter config. When that happens, we need to properly set * the `xoptions` reference in the main interpreter

[issue37264] Python 3.7.3 win 64bit - unresolved external symbol PyOS_AfterFork_Child

2019-06-13 Thread Steve Dower
Steve Dower added the comment: Windows does not have fork, and so the fork functionality is not built into it (PyOS_AfterFork() is empty). You will need to report this to mod_wsgi to be able to build without fork support. -- resolution: -> third party stage: -> resolved status:

[issue36710] Pass _PyRuntimeState as an argument rather than using the _PyRuntime global variable

2019-06-13 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +13922 pull_request: https://github.com/python/cpython/pull/14060 ___ Python tracker ___

[issue37241] Item Count Error in Shelf

2019-06-13 Thread Jesse Bacon
Change by Jesse Bacon : -- resolution: -> third party ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37241] Item Count Error in Shelf

2019-06-13 Thread Jesse Bacon
Jesse Bacon added the comment: I was using anaconda distribution on OSX. It failed for 3.6 and 3.7. I pulled off anaconda and compiled from source and the script executed correctly regardless of whether or not "--enable-optimizations" was set. Anaconda claims to be geared towards

[issue26180] multiprocessing.util._afterfork_registry leak in threaded environment

2019-06-13 Thread Terry J. Reedy
Terry J. Reedy added the comment: With master and Windows 10, the output looks like (0, 61333912, ): (1, 63524512, . at 0x03CA2940>): (2, 60787504, . at 0x03CA2760>): ProcessLocalSet() (5, 63524512, . at 0x03CA2C60>): ... <8 more lines like the two with ForkAwareLocal.__init__> I

[issue37111] Logging - Inconsistent behaviour when handling unicode

2019-06-13 Thread Steve Dower
Steve Dower added the comment: I think Vinay gets to make the call, but I also agree that some sort of error handling by default makes sense for logging. Especially now that it's (about to be) easier to override the default. FWIW, I'd leave the default arguments as None and just coerce it

[issue37268] Deprecate the parser module

2019-06-13 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Yep, will make a PR soon. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue20443] __code__. co_filename should always be an absolute path

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: One of the side effect of my PR 14053 is that tracebacks are more verbose: the filename is now absolute rather than relative. Currently: $ python3 x.py Traceback (most recent call last): File "x.py", line 4, in func() File "x.py", line 2, in func

[issue37261] test_io leaks references on AMD64 Fedora Rawhide Refleaks 3.8

2019-06-13 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +13921 pull_request: https://github.com/python/cpython/pull/14059 ___ Python tracker ___

[issue6689] subprocess doesn't pass arguments correctly on Linux when shell=True

2019-06-13 Thread miss-islington
miss-islington added the comment: New changeset ec3839a215a68cf35ff1f90cb6823f67a5abdce3 by Miss Islington (bot) in branch '3.8': bpo-6689: os.path.commonpath raises ValueError for different drives isn't documented (GH-14045)

[issue6689] subprocess doesn't pass arguments correctly on Linux when shell=True

2019-06-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +13920 pull_request: https://github.com/python/cpython/pull/14058 ___ Python tracker ___

[issue6689] subprocess doesn't pass arguments correctly on Linux when shell=True

2019-06-13 Thread miss-islington
miss-islington added the comment: New changeset 95492032c48fef20b9c7076a23fe7e46927a4688 by Miss Islington (bot) (Makdon) in branch 'master': bpo-6689: os.path.commonpath raises ValueError for different drives isn't documented (GH-14045)

[issue37261] test_io leaks references on AMD64 Fedora Rawhide Refleaks 3.8

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: I tested manually "./python -m test test_io -m CBufferedRWPairTest -R 3:3": it failed before the fix, it now pass on 3.8 and master with the fix. I close the issue. Enjoy resurrected objects... -- resolution: -> fixed stage: patch review ->

[issue36779] time.tzname returns empty string on Windows if default codepage is a Unicode codepage

2019-06-13 Thread miss-islington
miss-islington added the comment: New changeset 6a433f5ae63de72a85d20b05ff826c6f72d529b7 by Miss Islington (bot) in branch '3.7': bpo-36779: time.tzname returns empty string on Windows if default cod… (GH-13073)

[issue37261] test_io leaks references on AMD64 Fedora Rawhide Refleaks 3.8

2019-06-13 Thread miss-islington
miss-islington added the comment: New changeset b4f5b212535e75503fc33513676837089037bb48 by Miss Islington (bot) in branch '3.8': bpo-37261: Fix support.catch_unraisable_exception() (GH-14052) https://github.com/python/cpython/commit/b4f5b212535e75503fc33513676837089037bb48 --

[issue36779] time.tzname returns empty string on Windows if default codepage is a Unicode codepage

2019-06-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +13919 pull_request: https://github.com/python/cpython/pull/14057 ___ Python tracker ___

[issue36779] time.tzname returns empty string on Windows if default codepage is a Unicode codepage

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: New changeset 0a9baec16c17d261377fb8a31a57d8c397e25af6 by Victor Stinner (Miss Islington (bot)) in branch '3.8': bpo-36779: time.tzname returns empty string on Windows if default cod… (GH-13073) (GH-14032)

[issue37261] test_io leaks references on AMD64 Fedora Rawhide Refleaks 3.8

2019-06-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +13918 pull_request: https://github.com/python/cpython/pull/14056 ___ Python tracker ___

[issue37261] test_io leaks references on AMD64 Fedora Rawhide Refleaks 3.8

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6d22cc8e90ccb1e1965b1a4bc79456e2cc1e5a3e by Victor Stinner in branch 'master': bpo-37261: Fix support.catch_unraisable_exception() (GH-14052) https://github.com/python/cpython/commit/6d22cc8e90ccb1e1965b1a4bc79456e2cc1e5a3e --

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: If you care of inherited handles on Windows, please have a look at: * https://github.com/python/cpython/pull/7827 from https://bugs.python.org/issue18174 * https://github.com/python/cpython/pull/7966 from https://bugs.python.org/issue33966 ref:

[issue37210] Pure Python pickle module should not depend on _pickle.PickleBuffer

2019-06-13 Thread miss-islington
miss-islington added the comment: New changeset cbda40db7b604b377acfd3f04e19407ca33748a7 by Miss Islington (bot) in branch '3.8': bpo-37210: Fix pure Python pickle when _pickle is unavailable (GH-14016) https://github.com/python/cpython/commit/cbda40db7b604b377acfd3f04e19407ca33748a7

[issue36402] threading._shutdown() race condition: test_threading test_threads_join_2() fails randomly

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: Ok, the root issue (threading._shutdown() race condition) has been fixed in Python 3.7, 3.8 and master branches. I close the issue. Thanks for the reviews! -- components: +Library (Lib) -Tests resolution: -> fixed stage: patch review -> resolved

[issue37210] Pure Python pickle module should not depend on _pickle.PickleBuffer

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: I pushed my change to 3.8 and master branches. I close the issue. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue36402] threading._shutdown() race condition: test_threading test_threads_join_2() fails randomly

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: The bpo-18808 "Thread.join returns before PyThreadState is destroyed" was not fixed in Python 2.7: threading.Thread has no _tstate_lock attribute. I'm not comfortable to backport bpo-18808 "feature" or "bugfix" to Python 2.7, not to backport this change.

[issue36402] threading._shutdown() race condition: test_threading test_threads_join_2() fails randomly

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6eb2878e42152e9c45d7ee5e6f889532d753e67c by Victor Stinner (Miss Islington (bot)) in branch '3.7': bpo-36402: Fix threading._shutdown() race condition (GH-13948) (GH-14050) (GH-14054)

[issue37253] PyCompilerFlags got a new cf_feature_version field

2019-06-13 Thread STINNER Victor
Change by STINNER Victor : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37268] Deprecate the parser module

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: Pablo: Are you interested to implement this change? -- nosy: +pablogsal ___ Python tracker ___

[issue37268] Deprecate the parser module

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: I searched for "import parser" in GitHub code search, but I failed to find any project using the Python stdlib parser module. I only found copies of the CPython code source which has on "import parser" in Lib/test/test_parser.py. --

[issue37253] PyCompilerFlags got a new cf_feature_version field

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: > It's fine to document the current state. I don't think you should spend any > time *changing* the API to "future-proof" it. Ok. > I am hoping that larger changes to the compiler implementation will happen > before Python 4, which will make the whole API

[issue37268] Deprecate the parser module

2019-06-13 Thread STINNER Victor
New submission from STINNER Victor : The parser module should be deprecated as soon as possible according to Pablo Galindo Salgo and Guido van Rossum: * https://mail.python.org/pipermail/python-dev/2019-May/157464.html * https://bugs.python.org/issue37253#msg345398 I propose to deprecate it

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

2019-06-13 Thread STINNER Victor
Change by STINNER Victor : -- nosy: -vstinner ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37210] Pure Python pickle module should not depend on _pickle.PickleBuffer

2019-06-13 Thread miss-islington
Change by miss-islington : -- keywords: +patch pull_requests: +13917 stage: resolved -> patch review pull_request: https://github.com/python/cpython/pull/14055 ___ Python tracker

[issue37210] Pure Python pickle module should not depend on _pickle.PickleBuffer

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: New changeset 63ab4ba07b492448844940c347787ba30735b7f2 by Victor Stinner in branch 'master': bpo-37210: Fix pure Python pickle when _pickle is unavailable (GH-14016) https://github.com/python/cpython/commit/63ab4ba07b492448844940c347787ba30735b7f2

[issue36402] threading._shutdown() race condition: test_threading test_threads_join_2() fails randomly

2019-06-13 Thread miss-islington
Change by miss-islington : -- pull_requests: +13916 pull_request: https://github.com/python/cpython/pull/14054 ___ Python tracker ___

[issue36402] threading._shutdown() race condition: test_threading test_threads_join_2() fails randomly

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: New changeset e40a97a721d46307dfdc2b0322028ccded6eb571 by Victor Stinner in branch '3.8': [3.8] bpo-36402: Fix threading._shutdown() race condition (GH-13948) (GH-14050) https://github.com/python/cpython/commit/e40a97a721d46307dfdc2b0322028ccded6eb571

[issue19645] decouple unittest assertions from the TestCase class

2019-06-13 Thread Pascal Chambon
Pascal Chambon added the comment: "Suppose failureException is set to TypeError on that TestCase class, how would your assertEquals signal failure to the test runner?" failureException is an artefact from unittest.TestCase. It's only supposed to be used in a TestCase context, with an

[issue20443] __code__. co_filename should always be an absolute path

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: PR 14053 is a different approach than PR 13527: compute the absolute path to the script filename in PyConfig_Read() just after parsing the command line. -- nosy: +vstinner ___ Python tracker

[issue20443] __code__. co_filename should always be an absolute path

2019-06-13 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +13915 pull_request: https://github.com/python/cpython/pull/14053 ___ Python tracker ___

[issue19645] decouple unittest assertions from the TestCase class

2019-06-13 Thread Robert Collins
Robert Collins added the comment: Right now that attribute could be set by each test separately, or even varied within a test. TBH I'm not sure that the attribute really should be supported; perhaps thinking about breaking the API is worth doing. But - what are we solving for here. The OP

[issue19645] decouple unittest assertions from the TestCase class

2019-06-13 Thread Michael Foord
Michael Foord added the comment: Or even making the assert methods into custom descriptors. -- ___ Python tracker ___ ___

[issue19645] decouple unittest assertions from the TestCase class

2019-06-13 Thread Michael Foord
Michael Foord added the comment: Hmm, it could be done by __init_subclass__ potentially. -- ___ Python tracker ___ ___

[issue19645] decouple unittest assertions from the TestCase class

2019-06-13 Thread Michael Foord
Michael Foord added the comment: Suppose failureException is set to TypeError on that TestCase class, how would your assertEquals signal failure to the test runner? -- ___ Python tracker

[issue37247] swap distutils build_ext and build_py commands to allow proper SWIG extension installation

2019-06-13 Thread Jeroen van den Hout
Jeroen van den Hout added the comment: > Adding a separate build step for SWIG (then the order would be build_swig, > build_py, build_ext) would be safer and IMHO also more logical. I like this suggestion and contemplated it. However SWIG interface files are defined in Extension instances,

[issue37261] test_io leaks references on AMD64 Fedora Rawhide Refleaks 3.8

2019-06-13 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +13914 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14052 ___ Python tracker ___

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

2019-06-13 Thread Zackery Spytz
Change by Zackery Spytz : -- keywords: +patch pull_requests: +13913 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14051 ___ Python tracker ___

[issue37267] os.dup() creates an inheritable fd when handling a character file on Windows

2019-06-13 Thread Zackery Spytz
New submission from Zackery Spytz : In PR 13739, Eryk Sun mentioned that the Windows implementation of os.dup() returns an inheritable fd when handling a character file. A comment in _Py_dup() makes it seem as though this is due to a belief that handles for character files cannot be made

[issue36402] threading._shutdown() race condition: test_threading test_threads_join_2() fails randomly

2019-06-13 Thread STINNER Victor
Change by STINNER Victor : -- pull_requests: +13912 pull_request: https://github.com/python/cpython/pull/14050 ___ Python tracker ___

[issue37265] Memory leaks regression caused by: Fix threading._shutdown() race condition

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: commit 6f75c873752a16a7ad8f35855b1e29f59d048e84 (HEAD -> master, upstream/master) Author: Victor Stinner Date: Thu Jun 13 12:06:24 2019 +0200 tbpo-36402: Fix threading.Thread._stop() (GH-14047) Remove the _tstate_lock from _shutdown_locks,

[issue37266] Daemon threads must be forbidden in subinterpreters

2019-06-13 Thread STINNER Victor
Change by STINNER Victor : -- keywords: +patch pull_requests: +13911 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14049 ___ Python tracker ___

[issue36402] threading._shutdown() race condition: test_threading test_threads_join_2() fails randomly

2019-06-13 Thread STINNER Victor
STINNER Victor added the comment: New changeset 6f75c873752a16a7ad8f35855b1e29f59d048e84 by Victor Stinner in branch 'master': tbpo-36402: Fix threading.Thread._stop() (GH-14047) https://github.com/python/cpython/commit/6f75c873752a16a7ad8f35855b1e29f59d048e84 --

[issue37266] Daemon threads must be forbidden in subinterpreters

2019-06-13 Thread Karthikeyan Singaravelan
Change by Karthikeyan Singaravelan : -- nosy: +eric.snow ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue21872] LZMA library sometimes fails to decompress a file

2019-06-13 Thread Ma Lin
Ma Lin added the comment: I wrote a review guide in PR 14048. -- versions: +Python 3.8, Python 3.9 -Python 2.7, Python 3.4, Python 3.5, Python 3.6 ___ Python tracker ___

[issue37258] Logging cache not cleared properly when setting level

2019-06-13 Thread Karthikeyan Singaravelan
Karthikeyan Singaravelan added the comment: A unittest patch for this issue. This occurs in master and 3.8 too. diff --git a/Lib/test/test_logging.py b/Lib/test/test_logging.py index 50148dc2f2..30fd9ee37a 100644 --- a/Lib/test/test_logging.py +++ b/Lib/test/test_logging.py @@ -4172,6

[issue28009] core logic of uuid.getnode() needs refresh

2019-06-13 Thread Michael Felt
Michael Felt added the comment: p.s. - changed the title: way back when I first started on this I was mainly concerned that the _netstat_getnode() routine was broken for AIX. During the research and follow-up discussions it has become clear that it is more than just an AIX issue. There are

[issue18299] Change script_helper to use universal_newlines=True in _assert_python

2019-06-13 Thread hai shi
hai shi added the comment: spawn_python in script_helper is good enough, so this bug looks like cloud be closed. -- ___ Python tracker ___

[issue19645] decouple unittest assertions from the TestCase class

2019-06-13 Thread Pascal Chambon
Pascal Chambon added the comment: I don't get it, why would failureException block anything ? The unittest.TestCase API must remain the same anyway, but it could become just a wrapper towards external assertions. For example : class TestCase: assertEqual = wrap(assertions.assert_equal)

[issue21872] LZMA library sometimes fails to decompress a file

2019-06-13 Thread Ma Lin
Change by Ma Lin : -- pull_requests: +13910 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14048 ___ Python tracker ___

[issue28009] core logic of uuid.getnode() is broken for netstat

2019-06-13 Thread Michael Felt
Change by Michael Felt : -- versions: +Python 3.9 ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue28009] core logic of uuid.getnode() is broken for netstat

2019-06-13 Thread Michael Felt
Michael Felt added the comment: I have modified - _NODE_GETTERS_WIN32 = [_windll_getnode, _netbios_getnode, _ipconfig_getnode] _NODE_GETTERS_UNIX = [_unix_getnode, _ifconfig_getnode, _ip_getnode, _arp_getnode, _lanscan_getnode, _netstat_getnode] to: +683 #

  1   2   >