[issue32303] Namespace packages have inconsistent __loader__ and __spec__.loader

2018-02-01 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- assignee: -> barry versions: +Python 3.8 ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue32694] Can no longer specify OpenSLL locations with CPPFLAGS / LDFLAGS ?

2018-01-29 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: Can we also cover Brew? Here's the dumb little configure wrapper I use: ``` #!/bin/sh export CPPFLAGS="-I$(brew --prefix sqlite3)/include -I$(brew --prefix zlib)/include" export LDFLAGS="-L$(brew --prefix sqlite3)/

[issue32714] remove resourceLoader related code since it's deprecated

2018-01-29 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: We can't remove the code because it might still be used by third parties. Deprecation generally means we inform users that they shouldn't use the code any more (possibly with a DeprecationWarning, although we decided not

[issue32699] pythonXY._pth : unclear how .pth files are handled

2018-01-28 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32699> ___ __

[issue32694] macos/configure: Discover OpenSSL when installed with MacPorts

2018-01-28 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32694> ___ __

[issue32446] ResourceLoader.get_data() should accept a PathLike

2018-01-26 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: Hi Jay. Thanks for your interest in contributing to Python! Actually, I'm going to close this issue since we ultimately decided to deprecate the ResourceLoader ABC: https://docs.python.org/3.7/library/importlib.html?hig

[issue32493] UUID Module - FreeBSD build failure

2018-01-26 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32493> ___ __

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2018-01-24 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: Now that the zipimporter support has landed, I think we're done! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement ___ P

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2018-01-24 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: New changeset 6f6eb35f9bee18f54945f09664344f2d118ed89f by Barry Warsaw in branch 'master': bpo-32248 - Implement `ResourceReader` and `get_resource_reader()` for zipimport (#5248) https://github.com/python/cpython/

[issue32651] os.getlogin() should recommend getpass.getuser()

2018-01-24 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.6 ___ Python tracker <rep...@bugs.python.org> <https://bu

[issue32651] os.getlogin() should recommend getpass.getuser()

2018-01-24 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: New changeset 196b8cbab2b5044b92077f0b3c07c798fff68bc6 by Barry Warsaw (Miss Islington (bot)) in branch '3.6': bpo-32651 Recommend getpass.getuser() (GH-5301) (#5304) https://github.com/python/cpython/

[issue32651] os.getlogin() should recommend getpass.getuser()

2018-01-24 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: New changeset d499031f5f33c3ef71be7c81ef52eee6b47c42e1 by Barry Warsaw in branch 'master': bpo-32651 Recommend getpass.getuser() (#5301) https://github.com/python/cpython/commit/d499031f5f33c3ef71be7c81ef52eee6b4

[issue32651] os.getlogin() should recommend getpass.getuser()

2018-01-24 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- keywords: +patch pull_requests: +5148 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue32651] os.getlogin() should recommend getpass.getuser()

2018-01-24 Thread Barry A. Warsaw
New submission from Barry A. Warsaw <ba...@python.org>: The documentation for os.getlogin() says: "Return the name of the user logged in on the controlling terminal of the process. For most purposes, it is more useful to use the environment variables LOGNAME or USERNAME to f

[issue32502] uuid1() fails if only 64-bit interface addresses are available

2018-01-24 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- resolution: -> fixed stage: patch review -> resolved status: open -> closed versions: +Python 3.7 ___ Python tracker <rep...@bugs.python.org> <https://bu

[issue32502] uuid1() fails if only 64-bit interface addresses are available

2018-01-24 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: New changeset d69794f4df81de731cc66dc82136e28bee691e1e by Barry Warsaw (Bo Bayles) in branch '3.6': [3.6] bpo-32502: Discard 64-bit (and other invalid) hardware addresses (GH-5254) (#5290) https://github.com/python/cpython/

[issue32502] uuid1() fails if only 64-bit interface addresses are available

2018-01-23 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: New changeset 6b273f7f4056f8276f61a97c789d6bb4425e653c by Barry Warsaw (Bo Bayles) in branch 'master': bpo-32502: Discard 64-bit (and other invalid) hardware addresses (#5254) https://github.com/python/cpython/

[issue32616] Significant performance problems with Python 2.7 built with clang 3.x or 4.x

2018-01-22 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: Has anyone done the same analysis with Python 3.6 or 3.7? -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2018-01-19 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- pull_requests: +5093 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32248> ___ _

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2018-01-16 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- pull_requests: -5016 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32248> ___

[issue29708] support reproducible Python builds

2018-01-15 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Jan 15, 2018, at 11:31, Brett Cannon <rep...@bugs.python.org> wrote: > > 1. SOURCE_DATE_EPOCH acts as an environment variable flag to forcibly > generate hash-based .pyc files with the check_source bit set in py_comp

[issue32516] Add a shared library mechanism for win32

2018-01-13 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32516> ___ __

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2018-01-10 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- pull_requests: -5006 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32248> ___

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2018-01-10 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: @bbayles: I don't think PR 5149 is related to this issue. -- ___ Python tracker <rep...@bugs.python.org> <https://bugs.python

[issue2518] smtpd.py to handle huge email

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- resolution: -> wont fix stage: test needed -&

[issue19679] smtpd.py (SMTPChannel): implement enhanced status codes

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- resolution: -> wont fix stage: -> resolved

[issue14261] Cleanup in smtpd module

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- nosy: +barry resolution: -> wont fix stage: ne

[issue3802] smtpd.py __getaddr insufficient handling

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- nosy: +barry resolution: -> wont fix stage: te

[issue8503] smtpd SMTPServer does not allow domain filtering

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- resolution: -> wont fix stage: test needed -&

[issue19806] smtpd crashes when a multi-byte UTF-8 sequence is split between consecutive data packets

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- nosy: +barry resolution: -> wont fix stage: pat

[issue22159] smtpd.PureProxy and smtpd.DebuggingServer do not work with decode_data=True

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- nosy: +barry resolution: -> wont fix stage: -&

[issue22071] Remove long-time deprecated attributes from smtpd

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- nosy: +barry resolution: -> wont fix stage: pat

[issue11260] smtpd-as-a-script feature should be documented and should use argparse

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- resolution: -> wont fix stage: patch review -&

[issue22158] RFC 6531 (SMTPUTF8) support in smtpd.PureProxy

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- nosy: +barry resolution: -> wont fix stage: -&

[issue12816] smtpd uses library outside of the standard libraries

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and will likely not get any future development. Please see aiosmtpd as a much better third party replacement. -- resolution: -> wont fix stage: -> resolved

[issue25553] smtpd strips final carraige return from received message body

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and likely won't see much future improvements. Please take a look at aiosmtpd as a much better third party replacement. -- resolution: -> wont fix stage: ne

[issue26036] Unnecessary arguments on smtpd.SMTPServer

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix simce smtpd.py is deprecated and likely won't see any future improvements. Please take a look at aiosmtpd as a much better third party replacement. -- resolution: -> wont fix stage: -&

[issue16462] smtpd should return greeting

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm closing this as won't fix since smtpd.py is deprecated and likely won't see any fixes. Please take a look at aiosmtpd as a much better third party replacement. -- resolution: -> wont fix stage: -> resolved

[issue19678] smtpd.py: channel should be passed to process_message

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I'm going to close this as won't fix since smtpd.py is deprecated, and there's little chance that folks are still interested in working on it. See aiosmtpd as a much better third party replacement. -- resolution: ->

[issue12815] Coverage of smtpd.py

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: smtpd.py is deprecated so there's really almost zero chance we'll be doing any development on it. Please check out http://aiosmtpd.readthedocs.io/en/latest/ for a third party replacement (maybe pulled into the stdlib f

[issue32522] Add precision argument to datetime.now

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Jan 9, 2018, at 08:33, Paul Ganssle <rep...@bugs.python.org> wrote: > @Barry I don't think it's a good idea to duplicate the `replace` > functionality in `datetime` like that. I think the main problem isn't the

[issue32522] Add precision argument to datetime.now

2018-01-09 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: The .replace(microseconds=0) hack annoys me too, but I'd be happier with a simpler solution: make datetime.now() accept a microseconds parameter, so datetime.now(microseconds=0) would be equivalent to datetime.now().replace(microsec

[issue32522] Add precision argument to datetime.now

2018-01-09 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32522> ___ __

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2018-01-06 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Jan 6, 2018, at 13:33, Zachary Ware <rep...@bugs.python.org> wrote: > > I notice that my 'Installed' builder > (http://buildbot.python.org/all/#/builders/103) has been broken since PR4911 > landed. My sus

[issue32502] uuid1() broken on macos high sierra

2018-01-06 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Jan 6, 2018, at 11:26, Andres Petralli <rep...@bugs.python.org> wrote: > > Traceback (most recent call last): > File "/Users/andy/Desktop/test.py", line 3, in >str(uuid.uuid1()) > File

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2017-12-30 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: Next up - implementing the ResourceReader ABC. -- ___ Python tracker <rep...@bugs.python.org> <https://bugs.python

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2017-12-30 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: New changeset deae6b451fefd5fd3143dd65051e1d341e5a5f84 by Barry Warsaw in branch 'master': bpo-32248 - Implement importlib.resources (#4911) https://github.com/python/cpython/commit/deae6b451fefd5fd3143dd65051e1d341e

[issue23749] asyncio missing wrap_socket (starttls)

2017-12-30 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: @yselivanov - thanks for adding this, it's a huge win. I think the feature is significant enough for a What's New entry. -- ___ Python tracker <rep...@bugs.python.org> <https://

[issue32446] ResourceLoader.get_data() should accept a PathLike

2017-12-29 Thread Barry A. Warsaw
New submission from Barry A. Warsaw <ba...@python.org>: Currently get_data() only accepts a string. It should also accept a os.PathLike -- messages: 309178 nosy: barry, brett.cannon priority: normal severity: normal status: open title: ResourceLoader.get_data() should accept a Pa

[issue32145] Wrong ExitStack Callback recipe

2017-12-29 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Dec 29, 2017, at 08:40, Nick Coghlan <rep...@bugs.python.org> wrote: > > I'm not clear on what you mean about allowing arbitrary names for the > instance creation function - What I meant was that I don’t se

[issue32429] Outdated Modules/Setup warning is invisible

2017-12-26 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Dec 26, 2017, at 18:17, Antoine Pitrou <rep...@bugs.python.org> wrote: > > I'd really like it if we could get rid of the Setup/Setup.dist thing. It's a > distraction to have to type `cp -f Modules/Setup.dist Module

[issue32145] Wrong ExitStack Callback recipe

2017-12-26 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Dec 25, 2017, at 18:51, Nick Coghlan <rep...@bugs.python.org> wrote: > > 3. A for-subclasses-only "self._clone()" API could work as follows: > >def _clone(self, new_instance=None)

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2017-12-17 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: PR 4911 implements the importlib.resources API, along with tests and documentation. @brett.cannon - I'm thinking we should do the native ResourceReader implementations for the built-in loaders as a separate

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2017-12-17 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- pull_requests: +4805 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32248> ___ _

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2017-12-17 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I have the tests and code ported, but there are still a few things to do, but here's a question: We're using type annotations in importlib_resources, which of course is the right decision. But I think we still have a moratorium on

[issue20891] PyGILState_Ensure on non-Python thread causes fatal error

2017-12-15 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue20891> ___ __

[issue32333] test_smtplib: dangling threads on x86 Gentoo Non-Debug with X 3.x

2017-12-15 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32333> ___ __

[issue32305] Namespace packages have inconsistent __file__ and __spec__.origin

2017-12-13 Thread Barry A. Warsaw
New submission from Barry A. Warsaw <ba...@python.org>: Along the lines of Issue32303 there's another inconsistency in namespace package metadata. Let's say I have a namespace package: >>> importlib_resources.tests.data03.namespace The package has no __file__ attrib

[issue32303] Namespace packages have inconsistent __loader__ and __spec__.loader

2017-12-13 Thread Barry A. Warsaw
New submission from Barry A. Warsaw <ba...@python.org>: Let's say I have a namespace package: >>> importlib_resources.tests.data03.namespace This package has a non-None __loader__ but a None __spec__.loader: >>> importlib_resources.tests.dat

[issue21762] update the import machinery to only use __spec__

2017-12-13 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue21762> ___ __

[issue31554] Warn when __loader__ != __spec__.loader

2017-12-13 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue31554> ___ __

[issue32145] Wrong ExitStack Callback recipe

2017-12-10 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I wasn't even aware that pop_all() tries to create the concrete subtype. I wonder how common subclassing ExitStack is in practice. (Of course, the answer is that we'll never know.) For 3.7, we should probably delegate instance cr

[issue32234] Add context management to mailbox.Mailbox

2017-12-10 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: It's possible that the Mailman example can just assume that the mailbox will be flushed and unlocked on __exit__(), so it could just call .close(). Then the question is whether entering the CM should lock the mailbox. The two

[issue32263] Template string docs refer to "normal %-based substitutions"

2017-12-10 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Dec 10, 2017, at 14:36, Raymond Hettinger <rep...@bugs.python.org> wrote: > > Raymond Hettinger <raymond.hettin...@gmail.com> added the comment: > > We can remove the word "normal" but otherwis

[issue32263] Template string docs refer to "normal %-based substitutions"

2017-12-09 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32263> ___ __

[issue32248] Port importlib_resources (module and ABC) to Python 3.7

2017-12-07 Thread Barry A. Warsaw
New submission from Barry A. Warsaw <ba...@python.org>: We intend to port importlib_resources to Python 3.7 as importlib.resources, with a provisional API. There's also a ResourceReader ABC to include, along with documentation and tests. Nosying Brett and assigning to myself, but if

[issue32199] uuid.getnode() should return the MAC address on Android

2017-12-07 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: LGTM, and thanks! -- ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32199> ___

[issue32234] Add context management to mailbox.Mailbox

2017-12-06 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: Yes, I think this is a good idea. Would you like to submit a PR for it? FWIW, we have this code in Mailman 3: class Mailbox(MMDF): """A mailbox that interoperates with the 'with' statement."

[issue32199] uuid.getnode() should return the MAC address on Android

2017-12-06 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: > Maybe we should just close this issue as 'wont fix' then. I would be okay with any of these resolutions: * Close as `wont fix` * Just call `ip link` (without list) * Add a new getter such that both `ip link` and `ip link list` a

[issue32199] uuid.getnode() should return the MAC address on Android

2017-12-06 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Dec 6, 2017, at 02:06, Xavier de Gaye <rep...@bugs.python.org> wrote: > > Whatever the change made to fix this issue, it is not possible to add a test > case for this change. Even with say, exception raising mocks f

[issue32199] uuid.getnode() should return the MAC address on Android

2017-12-05 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Dec 5, 2017, at 16:28, Xavier de Gaye <rep...@bugs.python.org> wrote: > > The result of various 'ip' commands on Android, the last 'ip link list' > command is run as root and succeeds (did not think abo

[issue32199] uuid.getnode() should return the MAC address on Android

2017-12-05 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: Over in the PR I suggested: Here's another thought: what if you just added another getter that calls ip link list and placed that after one that calls ip link. Wouldn't that accomplish both goals? Then if ip link fails, we fal

[issue32107] Improve MAC address calculation and fix test_uuid.py

2017-12-03 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: I missed it too. Serhiy, do you want to add that fix to your already open PR 4677? -- ___ Python tracker <rep...@bugs.python.org> <https://bugs.python

[issue32107] Improve MAC address calculation and fix test_uuid.py

2017-12-02 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: > Sorry, but I can't understand how 23df2d1304ece169d7e0dfc843dfb8026b413d9f > could break getnode() on Android and how your changes can fix this. The only > effect of this change is that an error in _random_getnode() no lon

[issue32192] Provide importlib.util.lazy_import helper function

2017-12-01 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32192> ___ __

[issue32107] Improve MAC address calculation and fix test_uuid.py

2017-11-29 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker <rep...@bugs.python.org> <https://bu

[issue32107] Improve MAC address calculation and fix test_uuid.py

2017-11-29 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: New changeset 23cc8c0f9ece32f1f96133b9db2cb30c64f23a0e by Barry Warsaw in branch '3.6': [3.6] bpo-32107 - Backport bitmask check fix (GH-4576) (#4591) https://github.com/python/cpython/commit/23cc8c0f9ece32f1f96133b9db2cb30c64

[issue32107] Improve MAC address calculation and fix test_uuid.py

2017-11-29 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: New changeset 56e444f8df34cd502d6e3b110c90aed086883a72 by Barry Warsaw in branch '2.7': [2.7] bpo-32107 - Backport bitmask check fix (GH-4576) (#4590) https://github.com/python/cpython/commit/56e444f8df34cd502d6e3b110c90aed086

[issue32107] Improve MAC address calculation and fix test_uuid.py

2017-11-28 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: New changeset 23df2d1304ece169d7e0dfc843dfb8026b413d9f by Barry Warsaw in branch 'master': bpo-32107 - Improve MAC address calculation and fix test_uuid.py (#4600) https://github.com/python/cpython/

[issue32158] Suppress (and other contextlib context managers) should work as decorators (where appropriate)

2017-11-28 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- nosy: +barry ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32158> ___ __

[issue32107] Improve MAC address calculation and fix test_uuid.py

2017-11-28 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- title: test_uuid uses the incorrect bitmask -> Improve MAC address calculation and fix test_uuid.py ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue32107] test_uuid uses the incorrect bitmask

2017-11-27 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- pull_requests: +4520 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32107> ___ _

[issue32107] test_uuid uses the incorrect bitmask

2017-11-27 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Nov 27, 2017, at 18:38, STINNER Victor <rep...@bugs.python.org> wrote: > > STINNER Victor <victor.stin...@gmail.com> added the comment: > > The commit 9522a218f7dff95c490ff359cc60e8c2af35f5c8 broke multip

[issue32107] test_uuid uses the incorrect bitmask

2017-11-27 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Nov 27, 2017, at 16:21, Ned Deily <rep...@bugs.python.org> wrote: > > The latest checkin seems to have broken several buildbots: > > http://buildbot.python.org/all/#builders/47/builds/243 > http://buildbot.

[issue32107] test_uuid uses the incorrect bitmask

2017-11-27 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Nov 27, 2017, at 16:08, Serhiy Storchaka <rep...@bugs.python.org> wrote: > > We shouldn't check the 42nd bit in maintenance releases. This check will fail > on some computers. Oh, without the preferential retu

[issue32107] test_uuid uses the incorrect bitmask

2017-11-27 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- pull_requests: +4515 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32107> ___ _

[issue32107] test_uuid uses the incorrect bitmask

2017-11-27 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- pull_requests: +4514 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32107> ___ _

[issue32107] test_uuid uses the incorrect bitmask

2017-11-27 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Nov 27, 2017, at 15:18, Serhiy Storchaka <rep...@bugs.python.org> wrote: > > My apologies for my dim comment and my obliviousness that leaded to spending > your time on trying to fix a wrong issue. No worries at all

[issue32107] test_uuid uses the incorrect bitmask

2017-11-27 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: New changeset 9522a218f7dff95c490ff359cc60e8c2af35f5c8 by Barry Warsaw in branch 'master': bpo-32107 - Better merge of #4494 (#4576) https://github.com/python/cpython/commit/9522a218f7dff95c490ff359cc60e8c2af

[issue32107] test_uuid uses the incorrect bitmask

2017-11-27 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Nov 27, 2017, at 01:24, Serhiy Storchaka <rep...@bugs.python.org> wrote: > > 3. Makes methods for getting the address of the real network card preferring > universally administered addresses and falling back to

[issue32107] test_uuid uses the incorrect bitmask

2017-11-26 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: PR #4576 includes all related changes. -- ___ Python tracker <rep...@bugs.python.org> <https://bugs.python

[issue32107] test_uuid uses the incorrect bitmask

2017-11-26 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- pull_requests: +4504 ___ Python tracker <rep...@bugs.python.org> <https://bugs.python.org/issue32107> ___ _

[issue32107] test_uuid uses the incorrect bitmask

2017-11-26 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Nov 26, 2017, at 14:07, Serhiy Storchaka <rep...@bugs.python.org> wrote: > > Universally/locally administered MAC addresses doesn't have relation to this > issue. My assumption was about the multicast bit (1<<

[issue32107] test_uuid uses the incorrect bitmask

2017-11-26 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Nov 26, 2017, at 12:40, Serhiy Storchaka <rep...@bugs.python.org> wrote: > > Serhiy Storchaka <storchaka+cpyt...@gmail.com> added the comment: > > If I understand correctly, the original problem

[issue32107] test_uuid uses the incorrect bitmask

2017-11-23 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Nov 23, 2017, at 11:24, Serhiy Storchaka <rep...@bugs.python.org> wrote: > Wait, now I understand the purpose of the current test! There is just a typo > in a comment, should be 41 instead of 47. The test

[issue32107] test_uuid uses the incorrect bitmask

2017-11-21 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: On Nov 21, 2017, at 15:47, Serhiy Storchaka <rep...@bugs.python.org> wrote: > If your fix is correct (and it looks correct to me), we should fix not only > the test, but, first of all, the _*_getnode functions. Perhaps the

[issue32107] test_uuid uses the incorrect bitmask

2017-11-21 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: Yikes. It's entirely possible that these tests are tainted by environmental leakage. I was looking into why Travis fails on my PR: https://travis-ci.org/python/cpython/jobs/305433725 and stepping through _ifconfig_getnode() on

[issue32107] test_uuid uses the incorrect bitmask

2017-11-21 Thread Barry A. Warsaw
Barry A. Warsaw <ba...@python.org> added the comment: Pure chance I believe. It all depends on the MAC address of the machines the test runs on (which is perhaps an unacceptable environmental variability in the test suite, and should be fixed/mocked?). FWIW, I saw the failures on m

[issue32107] test_uuid uses the incorrect bitmask

2017-11-21 Thread Barry A. Warsaw
Change by Barry A. Warsaw <ba...@python.org>: -- keywords: +patch pull_requests: +4431 stage: -> patch review ___ Python tracker <rep...@bugs.python.org> <https://bugs.pyt

[issue32107] test_uuid uses the incorrect bitmask

2017-11-21 Thread Barry A. Warsaw
New submission from Barry A. Warsaw <ba...@python.org>: The check_node() function in test_uuid.py uses the wrong bitmask, causing the tests to fail on valid MAC addresses. Also, the description in the comment is incorrect. From my reading of the wikipedia page, the test is trying to

<    1   2   3   4   5   6   7   8   9   10   >