Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue38931>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue38928>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
nosy: +vinay.sajip
___
Python tracker
<https://bugs.python.org/issue38927>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Do note that Path inherits from PurePath, so providing a normalize() method on
the latter means it will end up on the former.
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue38
Brett Cannon added the comment:
New changeset 2f2489310d89f589a091aa09ac1eb973d9a383d8 by Brett Cannon (Miss
Islington (bot)) in branch '3.7':
bpo-21063: Improve module synopsis for distutils (GH-17363) (#17381)
https://github.com/python/cpython/commit
Brett Cannon added the comment:
Although I will admit we have not had a discussion on python-dev about removing
stuff that was left for Python 2.7 compatibility, so that discussion should
probably occur first before we go ripping stuff out
Brett Cannon added the comment:
If it was documented as deprecated and raising a deprecation warning then 3.2
is definitely far enough back to warrant removing it.
--
___
Python tracker
<https://bugs.python.org/issue38
Change by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
New changeset f8a6316778faff3991144c3aec4fa92d7b30a72b by Brett Cannon (Sanchit
Khurana) in branch 'master':
bpo-21063: Improve module synopsis for distutils (GH-17363)
https://github.com/python/cpython/commit/f8a6316778faff3991144c3aec4fa92d7b30a72b
Brett Cannon added the comment:
@Vinay you got exactly what I mean. I had to actually teach a ton of people
that shell trick with basename and pwd on Twitter, that trick doesn't seem to
be something people know about, and yet a ton of people seem to be creating
virtual environments
New submission from Brett Cannon :
I did a Twitter poll to see if there was consistent naming of the directory
people created a virtual environment into when done locally to code (the answer
is no). But a common theme was people not liking that the prompt defaults to
the name
Change by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
Is this best served in the stdlib or in an external tool like how
virtualenvwrapper is separate from virtualenv? While I get the convenience of
not having to install another tool to do this, it does bring in some complexity
that does not directly tie
Change by Brett Cannon :
--
keywords: +patch
pull_requests: +16844
stage: -> patch review
pull_request: https://github.com/python/cpython/pull/17359
___
Python tracker
<https://bugs.python.org/issu
New submission from Brett Cannon :
https://fishshell.com/docs/current/commands.html#source
--
assignee: brett.cannon
components: Documentation
messages: 357346
nosy: brett.cannon
priority: low
severity: normal
status: open
title: Document that virtual environment activation for fish
Brett Cannon added the comment:
I just realized one problem with this is it explicitly requires subclassing the
ABC while os.PathLike is supposed to represent a protocol (before
typing.Protocol was a thing).
So why is it bad that in the example class B is considered a "sub
Brett Cannon added the comment:
@greg I hope this goes into 3.8.1 since it was a breaking change.
@victor if we are going to ask folks to start using a setter and getter I say
we might as well get it right the first time and start taking the tstate now
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue38883>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue38870>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
Can you test this with a package that isn't tensorflow (e.g. something else in
the stdlib or something created manually; basically a smaller reproducer)? It's
hard to diagnose if this is really Python or not without a smaller reproducer
as tensorflow might
Brett Cannon added the comment:
Ah, your `assert` call threw me since it does succeed so it isn't acting as a
test case.
--
resolution: not a bug ->
status: closed -> open
___
Python tracker
<https://bugs.python.org/i
Change by Brett Cannon :
--
nosy: +brett.cannon, eric.snow, ncoghlan
___
Python tracker
<https://bugs.python.org/issue38884>
___
___
Python-bugs-list mailin
Brett Cannon added the comment:
Posted
https://mail.python.org/archives/list/python-...@python.org/thread/4UZJYAZL3NHRAGN5WAMJC4IHAHEXF3QF/
to see if anyone else wants to weigh in.
--
___
Python tracker
<https://bugs.python.org/issue38
Brett Cannon added the comment:
@Mark
> PEP 523 makes no mention of adding a getter or setter.
> Adding them is a big change to Python semantics and shouldn't, IMO, be done
> without a PEP that explicit states they are going to be added.
Adding getters or setters for
Brett Cannon added the comment:
Closing as importing 'typing' in 'os' is probably too much and would impact
start-up time.
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bug
New submission from Brett Cannon :
Since os.PathLike explicitly defines a a protocol, it would make sense to have
it inherit from typing.Protocol instead of abc.ABC.
--
components: Library (Lib)
messages: 357206
nosy: brett.cannon
priority: normal
severity: normal
status: open
title
Brett Cannon added the comment:
I can't reproduce in Python 3.8.0:
>>> import os
>>> class A(os.PathLike): pass
...
>>> class B:
... def __fspath__(self): pass
...
>>> issubclass(B, A)
True
Did you check against an older version of Python?
--
Brett Cannon added the comment:
I'm not in a good position to review distutils stuff.
--
___
Python tracker
<https://bugs.python.org/issue38021>
___
___
Pytho
Brett Cannon added the comment:
It's also possible the leading underscore was used to prevent name collisions.
Unfortunately I don't know the history of _attributes, so without someone
digging through the git history or personally knowing the reason behind it I
don't know whether we should
Brett Cannon added the comment:
OK, then my vote is to provide getter and setter methods that are
underscore-prefixed to mark them as "internal" with clear comments specifying
that they are part of PEP 523 and thus should not be needlessly broken in a
bugf
Change by Brett Cannon :
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue38839>
___
Brett Cannon added the comment:
New changeset 892221bfa04a41cf581f988ba19dc263f557e157 by Brett Cannon (Adam
Johnson) in branch 'master':
bpo-38839: Fix some unused functions in tests (GH-17189)
https://github.com/python/cpython/commit/892221bfa04a41cf581f988ba19dc263f557e157
Change by Brett Cannon :
--
title: Some unused functions in test suite -> Fix some unused functions in test
suite
___
Python tracker
<https://bugs.python.org/issu
Brett Cannon added the comment:
I think the real question is whether this is part of the CPython public API or
the CPython internal API.
@Fabio how burdensome would it be if we placed this in the internal API that
you can get access to but we don't make backwards-compatibility guarantees
Brett Cannon added the comment:
I've assigned this to Joannah to decide if she wants to backport this.
--
assignee: -> nanjekyejoannah
nosy: +nanjekyejoannah
___
Python tracker
<https://bugs.python.org/issu
Brett Cannon added the comment:
I think bpo-38500 needs to get resolved first before this as that will affect
whether this is acceptable or not as an API-breaking change.
--
___
Python tracker
<https://bugs.python.org/issue38
Brett Cannon added the comment:
3.6 and 3.5 are in security mode, so unless there's a security risk due to this
bug the fix will not be backported to those older versions
(https://devguide.python.org/#status-of-python-branches).
--
___
Python
Brett Cannon added the comment:
Just an FYI a raised exception isn't considered a crash. For us a crash is a
C-level crash like a segfault.
--
nosy: +brett.cannon
type: crash -> behavior
___
Python tracker
<https://bugs.python.org/issu
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue38793>
___
___
Python-bugs-list mailing list
Unsubscribe:
New submission from Brett Cannon :
Now that typing.Protocol exists we should convert the ABCs in importlib over to
protocols as the import system functions off of structural typing and not
nominal typing.
--
components: Library (Lib)
messages: 356501
nosy: brett.cannon
priority: low
Brett Cannon added the comment:
Adding Lisa to potentially add the PR from Ilya.
--
assignee: -> lisroach
___
Python tracker
<https://bugs.python.org/issu
Brett Cannon added the comment:
I would like to bring this issue back on topic as this about how to expose PEP
523 support in Python 3.8, not whether Fabio should be using a different
approach when he has been something sanctioned in an accepted PEP and was
previously doable
Change by Brett Cannon :
--
resolution: -> third party
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
PEP 523 was to give user code the ability to change the eval function. While
the work was motivated by our JIT work, supporting debugging was another
motivating factor: https://www.python.org/dev/peps/pep-0523/#debugging. There's
no C API because at the time
Change by Brett Cannon :
--
nosy: +brett.cannon, eric.snow, ncoghlan
___
Python tracker
<https://bugs.python.org/issue38691>
___
___
Python-bugs-list mailin
Brett Cannon added the comment:
I've flagged this as a release blocker so the Release Manager can make a call
about whether this should hold up future releases.
--
nosy: +brett.cannon
priority: normal -> release blocker
___
Python tracker
<
Brett Cannon added the comment:
Basically you have to figure out where that bad memory came from and that's
just plain hard in C short of slowly cutting out code until you get a small
reproducer. Typically these sorts of issues are almost always in the extension
modules, but your case
Brett Cannon added the comment:
@Mark are you strongly opposed because we're providing an API for changing the
eval function in the CPython API and you think it should be in the private API?
Or you objecting to PEP 523 all-up (based on your list of objections)? Either
way the PEP
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue38662>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
components: +Library (Lib)
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue38671>
___
___
Python-bugs-list mailin
Brett Cannon added the comment:
Can you trace this to actually being Python's fault? Unfortunately you're using
two extension modules who both could be at fault with this.
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.
Brett Cannon added the comment:
Please note that calling something "sloppy" and that somehow its development
was done in some "carelessness" fashion to the point of being "egregious" is
not motivating to others to try and help. Trying to support all of this code
Brett Cannon added the comment:
My guess is we won't want to take code specific to WolfSSL due to maintenance
overhead of trying to support another SSL library. There has been talk about
trying to move away from our OpenSSL dependency and switch to using the OS's
native secure sockets
Brett Cannon added the comment:
And just to add Serhiy's logic, think of pathlib more as an equivalent to
os.path than a be-all solution to anything path-related.
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue38
Change by Brett Cannon :
--
title: Bug in traceback.py -> ElementTree.ParseError does not implement
SyntaxError interface as expected
___
Python tracker
<https://bugs.python.org/issu
Brett Cannon added the comment:
Can you provide a small reproducer? Otherwise the recursion check is mostly
best effort if you have recursion in C code which never goes out to Python code
where the recursion check is implemented.
--
nosy: +brett.cannon
Brett Cannon added the comment:
Why do you think the warning can be removed? Is it documented as supported in
distutils? If setuptools supports that argument but not distutils then that
would be a bug against them.
--
nosy: +brett.cannon
Brett Cannon added the comment:
@Peter you can close this if issue36541 will fix your issue (i.e. both
assignment expressions and positional-only parameters).
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue38
Change by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<https://bugs.python.org/issue38457>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
nosy: +brett.cannon, eric.snow, ncoghlan
___
Python tracker
<https://bugs.python.org/issue38457>
___
___
Python-bugs-list mailin
Change by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<https://bugs.python.org/issue38457>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
nosy: +ghaering
___
Python tracker
<https://bugs.python.org/issue38413>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I personally think it would be fine to change the wording to say "measurable
speed-up" and not attribute a specific number.
--
___
Python tracker
<https://bugs.python.o
Change by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<https://bugs.python.org/issue37631>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
@Artificial please see the various blog posts and explanations about why the
clear separation between bytes and text came to be and thus this change isn't
"unnecessarily complicated".
--
nosy: +br
Brett Cannon added the comment:
Closing as not a bug as this seems to be an issue from installing over a b3 or
earlier build where the importlib/metadata/ directory gets left behind and thus
take priority in import over importlib/metadata.py.
--
nosy: +brett.cannon
resolution
Brett Cannon added the comment:
So it's a bit misleading to use the stdlib as a guideline because there are
reasons we do this in certain spots. E.g. the os module purposefully does
function-level imports to make startup cheaper. importlib does this to minimize
how many modules need
Change by Brett Cannon :
--
nosy: -brett.cannon
___
Python tracker
<https://bugs.python.org/issue15902>
___
___
Python-bugs-list mailing list
Unsubscribe:
Brett Cannon added the comment:
I'm -1 as PEP 519 created __fspath__ specifically so that pathlib.Path wouldn't
be confused as a string by accident. You can also use os.fspath() to get a
string representation of the path itself.
I also don't know if Antoine wants to make this sort of call
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue38215>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
resolution: -> fixed
stage: -> resolved
status: -> closed
___
Python tracker
<https://bugs.python.org/issue29652>
___
Change by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
Thanks for catching the warning and the fix, Karthikeyan!
--
___
Python tracker
<https://bugs.python.org/issue37409>
___
___
Brett Cannon added the comment:
New changeset 145cf1f50c8a8e8233e641f345cd5e25ee69190a by Brett Cannon
(Dong-hee Na) in branch 'master':
bpo-35923: Update the BuiltinImporter to use loader._ORIGIN instead of a
hard-coded value (GH-15651)
https://github.com/python/cpython/commit
Brett Cannon added the comment:
Forgot that this class is deprecated.
--
resolution: -> rejected
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Change by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
New changeset 37c22206981f52ae35c28b39f7530f8438afbfdb by Brett Cannon (Joannah
Nanjekye) in branch 'master':
bpo-35943: Prevent PyImport_GetModule() from returning a partially-initialized
module (GH-15057)
https://github.com/python/cpython/commit
Change by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
New changeset 0a6693a469cfb1dd5c8048d8cb4231a7b5883251 by Brett Cannon in
branch '3.8':
[3.8] bpo-37409: fix relative import with no parent (GH-14956) (GH-15913)
https://github.com/python/cpython/commit/0a6693a469cfb1dd5c8048d8cb4231a7b5883251
Change by Brett Cannon :
--
pull_requests: +15554
pull_request: https://github.com/python/cpython/pull/15913
___
Python tracker
<https://bugs.python.org/issue37
Brett Cannon added the comment:
New changeset 92420b3e679959a7d0ce875875601a4cee45231e by Brett Cannon (Ben
Lewis) in branch 'master':
bpo-37409: fix relative import with no parent (#14956)
https://github.com/python/cpython/commit/92420b3e679959a7d0ce875875601a4cee45231e
Change by Brett Cannon :
--
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.org/issue37585>
___
___
Pyth
Brett Cannon added the comment:
New changeset 6472ece5a0fe82809d3aa0ffb281796fcd252d76 by Brett Cannon (Kyle
Stanley) in branch 'master':
bpo-37585: Add clarification regarding comparing dict.values() (GH-14954)
https://github.com/python/cpython/commit
New submission from Brett Cannon :
importlib.machinery.WindowsRegistryFinder.DEBUG_BUILD has existed since Python
3.3
(https://hg.python.org/cpython/file/v3.3.0/Lib/importlib/_bootstrap.py#l1750).
--
assignee: docs@python
components: Documentation
messages: 351784
nosy: brett.cannon
Brett Cannon added the comment:
New changeset 17499d82702432955d8e442a1871ff276ca64bc5 by Brett Cannon (Jason
R. Coombs) in branch 'master':
bpo-38086: Sync importlib.metadata with importlib_metadata 0.21. (GH-15840)
https://github.com/python/cpython/commit
Brett Cannon added the comment:
Since no one has ever asked for this I won't worry about it. This was mostly to
start using the proper API for reading data out of a package, but it isn't
critical.
--
resolution: -> rejected
stage: -> resolved
status: open -&g
Brett Cannon added the comment:
This works as expected as nothing is inherently injected into your global
namespace in any of the other code that you are executing. Otherwise the fact
that the imported module is not being put into sys.modules also doesn't help if
you're trying to get access
Change by Brett Cannon :
--
nosy: +ncoghlan
___
Python tracker
<https://bugs.python.org/issue37941>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue37936>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue37935>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
Fixed by issue37663.
--
resolution: -> fixed
stage: patch review -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
Fixed by issue37663.
--
resolution: -> fixed
stage: -> resolved
status: open -> closed
___
Python tracker
<https://bugs.python.or
Brett Cannon added the comment:
I would just read through the other tests files under test_importlib to see how
other tests were done.
--
___
Python tracker
<https://bugs.python.org/issue37
Change by Brett Cannon :
--
priority: normal -> low
type: -> enhancement
___
Python tracker
<https://bugs.python.org/issue37918>
___
___
Python-bugs-list
Brett Cannon added the comment:
New changeset 48ede6b8f685669f53d26ae8456647af42ae3dae by Brett Cannon in
branch 'master':
bpo-37663: have venv activation scripts all consistently use __VENV_PROMPT__
for prompt customization (GH-14941)
https://github.com/python/cpython/commit
Brett Cannon added the comment:
A key question here is why are you trying to avoid the AttributeError case so
much? If something has a bug and an attribute doesn't exist that should then
that's a bug and the test needs to catch that. Now whether that's via an error
from AttributeError being
Brett Cannon added the comment:
What Serhiy said. :) There's code to be able to easily test both
builtins.__import__ and importlib.__import__ in tests so that there's no drift
between the two implementations.
--
___
Python tracker
<ht
Change by Brett Cannon :
--
nosy: +brett.cannon
___
Python tracker
<https://bugs.python.org/issue37860>
___
___
Python-bugs-list mailing list
Unsubscribe:
Change by Brett Cannon :
--
nosy: +barry
___
Python tracker
<https://bugs.python.org/issue37813>
___
___
Python-bugs-list mailing list
Unsubscribe:
601 - 700 of 5790 matches
Mail list logo