[issue5319] stdout error at interpreter shutdown fails to return OS error status

2015-08-26 Thread Robert Collins
Robert Collins added the comment: Right. So I think one could also propose that the default exception handling should also change to this new number, but it is a different situation - programs don't conflict with that - they allow it to bubble up, but this situation is outside its control

[issue22936] traceback module has no way to show locals

2015-08-25 Thread Robert Collins
Robert Collins added the comment: This itself is fixed. -- resolution: - fixed stage: - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22936

[issue23552] Have timeit warn about runs that are not independent of each other

2015-08-25 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- resolution: - fixed stage: patch review - resolved status: open - closed versions: +Python 3.6 -Python 3.5 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23552

[issue23183] timeit CLI best of 3: undocumented output format

2015-08-25 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23183

[issue21112] 3.4 regression: unittest.expectedFailure no longer works on TestCase subclasses

2015-08-25 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21112

[issue24193] Make LOGGING_FORMAT of assertLogs configurable

2015-08-24 Thread Robert Collins
Robert Collins added the comment: I don't know if or when it was moved, but right now: ./python -m pydoc unittest.case.TestCase.assertLogs ... the docs for it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24193

[issue24294] DeprecationWarnings should be visible by default in the interactive REPL

2015-08-24 Thread Robert Collins
Robert Collins added the comment: Hi, just to say - I'm happy to help steer this through. I think its an important ecosystem fixup. -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24294

[issue24294] DeprecationWarnings should be visible by default in the interactive REPL

2015-08-24 Thread Robert Collins
Robert Collins added the comment: On testing this - I don't think subprocess tests are necessarily needed. The scenarios are these (from Nick's comment): Test frameworks. - there are two in the standard library. unittest and doctest. - unittest's code paths end up going through 'TestProgram

[issue2786] Names in traceback should have class names, if they're methods

2015-08-24 Thread Robert Collins
Robert Collins added the comment: Forgot docs - I'll do before committing, but not worried about review of them so much. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2786

[issue2786] Names in traceback should have class names, if they're methods

2015-08-24 Thread Robert Collins
Robert Collins added the comment: Ok, so this is an API and ABI change. I'm going to do a variant without that downside. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2786

[issue2786] Names in traceback should have class names, if they're methods

2015-08-24 Thread Robert Collins
Robert Collins added the comment: And herewith. -- Added file: http://bugs.python.org/file40250/issue-2786-1.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2786

[issue17908] Unittest runner needs an option to call gc.collect() after each test

2015-08-23 Thread Robert Collins
Robert Collins added the comment: say, something to run a test until failure, or to watch for reference leaks, or to run tests in multiple processes :-)) I think a few complimentary things. unittest extensability currently requires a new CLI entry point for each thing. I'd like to fix

[issue22812] Documentation of unittest -p usage wrong on windows.

2015-08-23 Thread Robert Collins
Robert Collins added the comment: Thanks for the patch! -- resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22812

[issue23839] Clear caches after every test

2015-08-23 Thread Robert Collins
Robert Collins added the comment: Ok, so this is still in the noise space - it might be useful, it might not. Do we have reports of machines failing to run the test suite (that are also usefully big enough to compile Python and use

[issue24193] Make LOGGING_FORMAT of assertLogs configurable

2015-08-23 Thread Robert Collins
Robert Collins added the comment: Parameters please, TestCase has nothing to do with this - it really shouldn't even have the method. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24193

[issue24168] Unittest discover fails with namespace package if the path contains the string same as the module name

2015-08-23 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- versions: +Python 3.5, Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24168

[issue20851] Update devguide to cover testing from a tarball

2015-08-23 Thread Robert Collins
Robert Collins added the comment: Possibly silly q: how does one /make/ a Python release tarball? 'make dist' which is the autoconf standard complains that it has no such target... -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http

[issue24633] README file installed into site-packages conflicts with package named readme

2015-08-23 Thread Robert Collins
Robert Collins added the comment: Applied to 3.6 only (since I don't want to disrupt the 3.5 release train, and think that making packagers adjust on a point release would be mean). -- resolution: - fixed stage: patch review - resolved status: open - closed

[issue2786] Names in traceback should have class names, if they're methods

2015-08-23 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- stage: needs patch - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue2786

[issue24055] unittest package-level set up tear down module

2015-08-23 Thread Robert Collins
Robert Collins added the comment: Personally I'm very skeptical of all the multi-test setup facilties because of the very poor interactions with parallel testing that this basic approach has. But - we haven't yet brought in something sensible to let us deprecate setUpModule and setUpClass, so

[issue24904] Patch: add timeout to difflib SequenceMatcher ratio() and quick_ratio()

2015-08-20 Thread Robert Collins
Robert Collins added the comment: So - I'm with Victor and Raymond here. I think modifying difflib to provide external control over the poor-O components would permit many more benefits than just controlling time: you could wrap them in a timer module to get what this patch does, you could

[issue14534] Add means to mark unittest.TestCases as do not run.

2015-08-20 Thread Robert Collins
Robert Collins added the comment: So I've two more cases for this that I think we need to ensure works. Firstly FunctionTestCase should be blacklistable, and its not abstract. Secondly we're going to want nose, unittest2 etc to be able to also honour this. I suspect that this is easy and may

[issue22680] Blacklist FunctionTestCase from test discovery

2015-08-20 Thread Robert Collins
Robert Collins added the comment: Thanks for this. I think that a better approach would be the other linked bug - we can kill many birds with one stone. -- resolution: - duplicate status: open - closed ___ Python tracker rep...@bugs.python.org http

[issue22197] Allow better verbosity / output control in test cases

2015-08-20 Thread Robert Collins
Robert Collins added the comment: There's a few interacting things here. If I can suggest some design thoughts. buffering within a test is I think really something we should offer a test servicing API for. There are many thirdparty ones (e.g. I have one in fixtures) - but it should

[issue14534] Add means to mark unittest.TestCases as do not load.

2015-08-20 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- title: Add means to mark unittest.TestCases as do not run. - Add means to mark unittest.TestCases as do not load. ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14534

[issue14534] Add means to mark unittest.TestCases as do not run.

2015-08-20 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: Removed file: http://bugs.python.org/file36315/01438f18ee18.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14534

[issue14534] Add means to mark unittest.TestCases as do not run.

2015-08-20 Thread Robert Collins
Robert Collins added the comment: Removed the bogus huge diff. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue14534 ___ ___ Python-bugs-list

[issue24263] unittest cannot load module whose name starts with Unicode

2015-08-20 Thread Robert Collins
Robert Collins added the comment: I'm torn on whether this needs a test or not. It would be hard to regress, but testing this properly really wants hypothesis with a valid-python-identifier-strategy. I think on balance we do need one. So - we need a test in test_discover that mocks

[issue14534] Add means to mark unittest.TestCases as do not run.

2015-08-20 Thread Robert Collins
Robert Collins added the comment: I'm going to review on rietvald - I see a lot of changes needed - sorry - and some are a bit bikesheddy. But, if we do them I'll commit it asap and do any final fixup needed. -- ___ Python tracker rep

[issue24352] Provide a way for assertLogs to optionally not hide the logging output

2015-08-20 Thread Robert Collins
Robert Collins added the comment: Ok so, design thoughts here. assertLogs really does two things. Firstly it takes a copy of the logs so it can do its assertion. Secondly it disables all other logging, cleaning up noisy tests. Your specific need only conflicts with the second case. The way

[issue23882] unittest discovery doesn't detect namespace packages when given no parameters

2015-08-20 Thread Robert Collins
Robert Collins added the comment: (for the trivial case of CLI discover without a parameter - so translate that to the lower level API and then test that) -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23882

[issue23882] unittest discovery doesn't detect namespace packages when given no parameters

2015-08-20 Thread Robert Collins
Robert Collins added the comment: reviewed in rietvald, but here too just in case. The hunk that saves/restores _top_level_dir feels wrong to me - and not part of this bug, please remove it. The rest of the patch is fine today. But it also needs to add two specifically namespace tests

[issue24247] unittest discover modifies sys.path

2015-08-20 Thread Robert Collins
Robert Collins added the comment: It did that because you did not specify a top level directory. Without that, the cwd is not on the path and that breaks many environments. We should probably document it better. The workaround for your needs is to either just run 'unittest discover', or run

[issue24355] Provide a unittest api for controlling verbosity in tests

2015-08-20 Thread Robert Collins
Robert Collins added the comment: I've put a fairly comprehensive comment into issue22197. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24355

[issue24758] unittest.mock.Mock's new unsafe feature needs a better error message

2015-08-20 Thread Robert Collins
Robert Collins added the comment: @Randy - ok thanks. So, please do improve the prose in the error message, should be a very straight forward patch. -- stage: test needed - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue24263] unittest cannot load module whose name starts with Unicode

2015-08-20 Thread Robert Collins
Robert Collins added the comment: Thank you very much for writing your patch in backwards compatible style - it will make backporting to unittest2 much easier. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24263

[issue24710] Class name hardcoded in TracebackException.from_exception()

2015-08-19 Thread Robert Collins
Robert Collins added the comment: So I'm still ambivalent at best about this - this interface hasn't been designed for subclassing - I'm sure there is a bunch more stuff that would be needed. What /is/ needed feature wise here is a sideways extension mechanism for doing filtering

[issue20362] longMessage attribute is ignored in unittest.TestCase.assertRegexpMatches etc

2015-08-19 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20362

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

2015-08-19 Thread Robert Collins
Robert Collins added the comment: I can't see how the patch could have caused the Traceback (most recent call last): File D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib\test\test_symbol.py, line 44, in test_real_grammar_and_symbol_file os.stat(TEST_PY_FILE))) AssertionError

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

2015-08-19 Thread Robert Collins
Robert Collins added the comment: So it looks like one failure is: FAIL: test_getline (test.test_linecache.GoodUnicode) -- Traceback (most recent call last): File D:\cygwin\home\db3l\buildarea\3.x.bolen-windows7\build\lib

[issue20362] longMessage attribute is ignored in unittest.TestCase.assertRegexpMatches etc

2015-08-19 Thread Robert Collins
Robert Collins added the comment: Thanks for the patch, applied to 3.5 and 3.6. -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20362

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

2015-08-19 Thread Robert Collins
Robert Collins added the comment: Debian is green again and I think windows will do so to. -- stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24054

[issue22680] Blacklist FunctionTestCase from test discovery

2015-08-19 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22680

[issue24054] Invalid syntax in inspect_fodder2.py (on Python 2.x)

2015-08-18 Thread Robert Collins
Robert Collins added the comment: Thank you for the patch; sorry it took me so long to get to it - been working on a backlog of patch review. -- resolution: - fixed stage: - resolved status: open - closed versions: +Python 3.6 ___ Python tracker

[issue24891] python aborts running under nohup

2015-08-18 Thread Robert Collins
Robert Collins added the comment: What sort of errors? -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24891 ___ ___ Python-bugs

[issue24769] Interpreter doesn't start when dynamic loading is disabled

2015-08-17 Thread Robert Collins
Robert Collins added the comment: Patch looks good to me too. I think this needs to be put forward as a PR to bitbucket right? It looks Release Critical to me. -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org

[issue24847] Can't import tkinter in Python 3.5.0rc1

2015-08-17 Thread Robert Collins
Robert Collins added the comment: Looks good to me. I think you should commit (or perhaps you are pending PR approval on the rc branch or something?) -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24847

[issue24774] inconsistency in http.server.test

2015-08-16 Thread Robert Collins
Robert Collins added the comment: Thanks for the patch. Applied to 3.4 and up. -- nosy: +rbcollins resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24774

[issue24864] errors writing to stdout during interpreter exit exit with status 0

2015-08-14 Thread Robert Collins
Robert Collins added the comment: Updating the title to reflect my deeper understanding: the only issue here is that we don't alter the exit code. -- title: errors writing to stdout are uncatchable and exit with status 0 - errors writing to stdout during interpreter exit exit

[issue21159] configparser.InterpolationMissingOptionError is not very intuitive

2015-08-14 Thread Robert Collins
Robert Collins added the comment: anyhow fixed -- status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21159 ___ ___ Python-bugs

[issue21159] configparser.InterpolationMissingOptionError is not very intuitive

2015-08-14 Thread Robert Collins
Robert Collins added the comment: Huh? I definitely did. I can see there's a extra head now, but I did the merge up per protocol locally. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21159

[issue24864] errors writing to stdout are uncatchable and exit with status 0

2015-08-14 Thread Robert Collins
New submission from Robert Collins: I was trying to demonstrate how testing some code is hard, and I stumbled upon this. The following code should be debuggable when run with a bad stdout - e.g. python foo.py /dev/full --- import sys import traceback import pdb;pdb.Pdb(stdout=sys.stderr

[issue24864] errors writing to stdout are uncatchable and exit with status 0

2015-08-14 Thread Robert Collins
Robert Collins added the comment: Oh, and for added joy sys.last_value is not set here, so I've yet to manage to poke at what is being executed - clearly pdb is still managing to single-step, ish. -- ___ Python tracker rep...@bugs.python.org http

[issue24869] shlex lineno inaccurate with certain inputs

2015-08-14 Thread Robert Escriva
New submission from Robert Escriva: The newlines calculated by the shlex module are inaccurate for certain inputs with comments inline. I've attached a simple script that illustrates the problem. My assumption here is that the lineno is supposed to match a line related to the current token

[issue11380] Improve reporting of broken stdout pipe during interpreter shutdown

2015-08-14 Thread Robert Collins
Robert Collins added the comment: Oh, just saw your comment Martin; yes, this does look like a dupe. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11380

[issue24864] errors writing to stdout during interpreter exit exit with status 0

2015-08-14 Thread Robert Collins
Robert Collins added the comment: This patch is a minimal stab at the issue. We should do this change because as it stands genuine user affecting errors can be masked both in pipelines and non-pipeline cases. A more comprehensive patch would also change e.g. Py_Exit, and the various other

[issue24864] errors writing to stdout during interpreter exit exit with status 0

2015-08-14 Thread Robert Collins
Robert Collins added the comment: Oh, just saw your comment Martin; yes, this does look like a dupe. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24864

[issue11380] Improve reporting of broken stdout pipe during interpreter shutdown

2015-08-14 Thread Robert Collins
Robert Collins added the comment: Bah, wrong issue. Sorry. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue11380 ___ ___ Python-bugs-list mailing

[issue5319] stdout error at interpreter shutdown fails to return OS error status

2015-08-14 Thread Robert Collins
Robert Collins added the comment: I think you need to make the following changes: - Py_Exit with a non-zero status code should probably preserve the code rather than replacing it with 1. - Ditto in Py_Main. - Add a defs entry for Py_FinalizeEx - should be a copy of the Py_Finalize entry

[issue24864] errors writing to stdout during interpreter exit exit with status 0

2015-08-14 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- resolution: - duplicate status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24864

[issue13224] Change str(x) to return only the qualname for some types

2015-08-14 Thread Robert Collins
Robert Collins added the comment: Ok, so needs more work. Moving back to patch review. -- stage: commit review - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13224

[issue24864] errors writing to stdout are uncatchable and exit with status 0

2015-08-14 Thread Robert Collins
Robert Collins added the comment: Oh, one nuance - the reason my except isn't triggering is that the write is happening in interpreter shutdown - in flush_std_files. Adding a a flush there allows that to work, but its fugly: --- import sys try: print(What... is your quest

[issue11380] Improve reporting of broken stdout pipe during interpreter shutdown

2015-08-14 Thread Robert Collins
Robert Collins added the comment: @zzeeek For Python 3 pipeline tools you need something like this: try: all your stuff finally: try: sys.stdout.flush() finally: try: sys.stdout.close() finally: try: sys.stderr.flush

[issue24864] errors writing to stdout are uncatchable and exit with status 0

2015-08-14 Thread Robert Collins
Robert Collins added the comment: FWIW Python 2.7.8 behaves the same way (different message, same behaviour). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24864

[issue11380] Improve reporting of broken stdout pipe during interpreter shutdown

2015-08-14 Thread Robert Collins
Robert Collins added the comment: See also issue24864 which is not *quite* a dupe, I also found that it exits 0, unreasonably so. The reporting thing is interesting, but the main thing I care about is that we can catch it and do something reasonable with it... and that if not caught

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

2015-08-13 Thread Robert Collins
Robert Collins added the comment: Ok, so will someone commit 3), or would you like me to do so? After that it sounds like we can move this back to patch review, since there will be nothing left ready for commit. -- ___ Python tracker rep

[issue21159] configparser.InterpolationMissingOptionError is not very intuitive

2015-08-13 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21159

[issue21159] configparser.InterpolationMissingOptionError is not very intuitive

2015-08-13 Thread Robert Collins
Robert Collins added the comment: I've applied this since it seems Lukasz was busy. Thanks for the patch Lukasz! -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue21159

[issue24079] xml.etree.ElementTree.Element.text does not conform to the documentation

2015-08-12 Thread Robert Collins
Robert Collins added the comment: So it is downplayed but it is still documented as being application usable. I'll give this another week for Ned to reply, then commit it in the absence of a reply: I think its ok as is. I'd be ok with a tweaked version along the lines Ned proposed too: both

[issue18383] test_warnings modifies warnings.filters when running with -W default

2015-08-12 Thread Robert Collins
Robert Collins added the comment: @ashkop so append=True could be clearer as 'atend=True' - both forms of call are expected to add the filter, but one adds to the front, one to the end. Looking at warn_explicit, its takes the first matching filter, and then acts on its action. So

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-12 Thread Robert Collins
Robert Collins added the comment: Sorry, I didn't realise that Zbigniew was an alternative spelling of your first name. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23725

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-12 Thread Robert Collins
Robert Collins added the comment: Thanks for the patch. I've committed the current status as an unambiguous improvement; we can add tempdir as deprecated later if there is consensus on that, the current patch did improve its docs per R. David Murray's request anyhow. -- resolution

[issue21126] Return results from doctest.run_docstring_examples()

2015-08-12 Thread Robert Collins
Robert Collins added the comment: So, I think this needs a test; returning a generator would be nice but would be an API break. Also the doc update needs to say 3.6 now. Thanks; moving back to patch review. -- nosy: +rbcollins stage: commit review - patch review

[issue9232] Allow trailing comma in any function argument list.

2015-08-11 Thread Robert Collins
Robert Collins added the comment: The patch had some conflicts in the reference docs, I think I resolved it correctly: if someone wanted to cross check my work that would be great. However I was feeling (perhaps wrongly :)) confident so I have committed it as-is. -- resolution

[issue15989] Possible integer overflow of PyLong_AsLong() results

2015-08-09 Thread Robert Collins
Robert Collins added the comment: It looks fine to me, for whatever thats worth. I think you should commit it. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15989

[issue20059] Inconsistent urlparse/urllib.parse handling of invalid port values?

2015-08-09 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20059

[issue23004] mock_open() should allow reading binary data

2015-08-06 Thread Robert Collins
Robert Collins added the comment: Post merge review: looks like data_as_list = read_data.splitlines(True) would be a little cleaner. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23004

[issue4395] Document auto __ne__ generation; provide a use case for non-trivial __ne__

2015-08-06 Thread Robert Collins
Robert Collins added the comment: Thanks for the patch; applied to 3.4 and up. -- nosy: +rbcollins resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue4395

[issue24531] please document that no code preceding encoding declaration is allowed

2015-08-06 Thread Robert Collins
Robert Collins added the comment: Thanks, applied across the board; I had to tweak it a little on 2.7. -- nosy: +rbcollins resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http

[issue21718] sqlite3 cursor.description seems to rely on incomplete statement parsing for detection

2015-08-05 Thread Robert Collins
Robert Collins added the comment: @Gerhard would you like that ported to cPython for you? @Tom - I think that if the patch applies to 2.7.x we should apply it there since its very unlikely to break non-buggy code. -- nosy: +rbcollins versions: +Python 3.6

[issue13224] Change str(x) to return only the qualname for some types

2015-08-05 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13224 ___ ___ Python-bugs

[issue13224] Change str(x) to return only the qualname for some types

2015-08-05 Thread Robert Collins
Robert Collins added the comment: The patch is a little stale but it seems easy enough to fix up. I'll commit it tomorrowish in the absence of other discussion. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue13224

[issue24391] Better repr for threading objects

2015-08-05 Thread Robert Collins
Robert Collins added the comment: So, I think the majority opinion seems to be: module.type at address value1, value2, ... AIUI the patch doesn't quite do that, so I'm going to pop this back to patch review. That said, Serhiy, if you fix it up, just commit it please :) -- nosy

[issue20769] Reload() description is unclear

2015-08-04 Thread Robert Collins
Robert Collins added the comment: 2.7 side applied. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20769 ___ ___ Python-bugs-list mailing list

[issue20769] Reload() description is unclear

2015-08-04 Thread Robert Collins
Robert Collins added the comment: 24081 invalidates half the patch, but the other half still applies. -- nosy: +rbcollins versions: +Python 3.4, Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue20769

[issue23888] Fixing fractional expiry time bug in cookiejar

2015-08-03 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- versions: +Python 3.4, Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23888

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread Robert Collins
Robert Collins added the comment: I can't find any reference to a discussion to deprecate tempdir outside of this issue. Nothing on python-dev/python-ideas/peps. I can see that there's an argument that it should be deprecated, but AFAICT the idea to do so originated here. I'd like to see

[issue23888] Fixing fractional expiry time bug in cookiejar

2015-08-03 Thread Robert Collins
Robert Collins added the comment: Thanks for the patch. -- nosy: +rbcollins resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23888

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread Robert Collins
Robert Collins added the comment: mktemp is clearly insecure. I'd just move the tmpdir up above the Deprecation section start -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23725

[issue24021] Add docstring to urllib.urlretrieve

2015-08-03 Thread Robert Collins
Robert Collins added the comment: Applied to 3.4 and up. Thanks for the patch. -- nosy: +rbcollins resolution: - fixed stage: needs patch - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue24021

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- versions: +Python 3.6 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23725 ___ ___ Python

[issue23725] update tempfile docs to say that TemporaryFile is secure

2015-08-03 Thread Robert Collins
Robert Collins added the comment: I'm not 100% sure that tempfile.tempdir should be deprecated. Its much less convenient to control global behaviour with that. I agree that mktemp should be. I've updated the patch though. -- nosy: +rbcollins Added file: http://bugs.python.org

[issue20180] Derby #11: Convert 50 sites to Argument Clinic across 9 files

2015-08-03 Thread Robert Collins
Robert Collins added the comment: So I'm confused. Is this applicable or not? Its in commit review, but there's discussion of politics here :(. -- nosy: +rbcollins status: open - pending ___ Python tracker rep...@bugs.python.org http

[issue22227] Simplify tarfile iterator

2015-08-02 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- stage: patch review - commit review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue7

[issue6631] Disallow relative files paths in urllib*.open()

2015-08-02 Thread Robert Collins
Robert Collins added the comment: test_relativelocalfile is still in place in the urllib tests, so its affecting urlopen to this point. So I think the bug is fixed at least to the extent of the original report. I'm going to close this. -- nosy: +rbcollins stage: commit review

[issue22397] test_socket failure on AIX

2015-08-02 Thread Robert Collins
Robert Collins added the comment: I've updated the ref in the patch to this bug per Victor's comments, and applied. I'm not sure of protocol here. Do we close this ticket, or keep it open to analyze the actual cause? -- nosy: +rbcollins ___ Python

[issue22397] test_socket not running all tests on AIX

2015-08-02 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- stage: commit review - needs patch title: test_socket failure on AIX - test_socket not running all tests on AIX ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22397

[issue23524] Use _set_thread_local_invalid_parameter_handler in posixmodule

2015-08-02 Thread Robert Collins
Robert Collins added the comment: Looks committed a way back to me. -- nosy: +rbcollins resolution: - fixed stage: commit review - resolved status: open - closed ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue23524

[issue22852] urllib.parse wrongly strips empty #fragment, ?query, //netloc

2015-08-02 Thread Robert Collins
Robert Collins added the comment: See also issue 6631 -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22852 ___ ___ Python-bugs

[issue22625] When cross-compiling, don’t try to execute binaries

2015-07-31 Thread Robert Collins
Changes by Robert Collins robe...@robertcollins.net: -- nosy: +rbcollins ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue22625 ___ ___ Python-bugs

<    1   2   3   4   5   6   7   8   9   10   >