[issue19696] Merge all (non-syntactic) import-related tests into test_importlib

2019-06-16 Thread Gil Forcada Codinachs


Gil Forcada Codinachs  added the comment:

At least test_namespace_pkgs is already moved, see 
https://bugs.python.org/issue21097

Should then this issue be closed?

I see that there are a few other tests that have import on its name and are 
outside either test_import or test_importlib:

- test_pkgimport.py
- test_threaded_import.py
- test_zipimport.py
- test_zipimport_support.py
- threaded_import_hangers.py

Should those be actually moved to test_importlib?

--
nosy: +gforcada

___
Python tracker 
<https://bugs.python.org/issue19696>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue9267] Update pickle opcode documentation in pickletools for 3.x

2019-06-16 Thread Gil Forcada Codinachs


Gil Forcada Codinachs  added the comment:

pickletools documentation is here:

https://docs.python.org/3/library/pickletools.html#module-pickletools

Sources are here:

https://github.com/python/cpython/blob/master/Doc/library/pickletools.rst

--
nosy: +gforcada

___
Python tracker 
<https://bugs.python.org/issue9267>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com



[issue33211] lineno and col_offset are wrong on function definitions with decorators

2018-04-02 Thread Gil Forcada

New submission from Gil Forcada <gil.gn...@gmail.com>:

Given the following code:

class MyClass(object):

@property
def my_function(self): pass

Parsing it with ast module, the lineno and col_offset of the ast.FunctionDef is 
reported to be where the decorator starts (i.e. line 3 column 4) rather than 
where the actual def statement is (i.e. line 4 column 4).

This is due to the decorator that is part of the ast.FunctionDef, but as  there 
can be multiple decorators (which they don't provide their own lineno and 
col_offset arguments) and they can span across multiple lines, there is no 
reliable way to actually know where the actual def statement starts physically.

See this bug report on flake8-builtins plugin (I'm the author) reported by 
@dhood user on github:

https://github.com/gforcada/flake8-builtins/issues/22#issuecomment-377961642

--
components: Library (Lib)
messages: 314861
nosy: gforcada
priority: normal
severity: normal
status: open
title: lineno and col_offset are wrong on function definitions with decorators
type: behavior
versions: Python 2.7, Python 3.4, Python 3.5, Python 3.6, Python 3.7, Python 3.8

___
Python tracker <rep...@bugs.python.org>
<https://bugs.python.org/issue33211>
___
___
Python-bugs-list mailing list
Unsubscribe: 
https://mail.python.org/mailman/options/python-bugs-list/archive%40mail-archive.com