[issue15305] Test harness unnecessarily disambiguating twice

Logan Jones added the comment: I'm working on this in the PyCon 2019 sprints. Near as I can tell, while this issue still seems relevant, I think it might actually be for the best that this multiple disambiguation is left in the test suite. I removed the pid reference in the TESTFN and the

[issue15305] Test harness unnecessarily disambiguating twice

Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue15305] Test harness unnecessarily disambiguating twice

Mark Lawrence added the comment: The patch is very short so can we have a formal review please. -- nosy: +BreamoreBoy ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15305 ___

[issue15305] Test harness unnecessarily disambiguating twice

Chris Jerdonek added the comment: The fix for issue 17283 has been committed now, which should make this slightly easier to fix (e.g. change one place instead of two). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15305

[issue15305] Test harness unnecessarily disambiguating twice

Chris Jerdonek added the comment: Here is a patch that updates Geoff's patch to the latest code, and addresses the directory creation issue. -- Added file: http://bugs.python.org/file29269/issue15305-3.patch ___ Python tracker rep...@bugs.python.org

[issue15305] Test harness unnecessarily disambiguating twice

Changes by Chris Jerdonek chris.jerdo...@gmail.com: -- stage: - patch review type: - enhancement versions: +Python 3.4 -Python 3.3 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue15305 ___

[issue15305] Test harness unnecessarily disambiguating twice

Geoff Wilson added the comment: Both are called at different points when running './python.exe -m test -j3': 1. In __main__.py, this is called once at the start of the test run. By putting TESTCWD as the first/name arg, the directory is created. 2. In regrtest.py, the main file is called per

[issue15305] Test harness unnecessarily disambiguating twice

Chris Jerdonek added the comment: I don't think support.temp_cwd() should be changed for this issue (or needs to be). Also, changing it in the proposed way could mask errors in the test suite since tests were written against the current behavior. regrtest.py and __main__.py should both

[issue15305] Test harness unnecessarily disambiguating twice

Geoff Wilson added the comment: Simplify to single build/test directory, and disambiguate by TEMPFN. Test suite run on Mac OS X (./python.exe -m test -j3) without error. Some files created by tests do not use TESTFN, so may have build bots identify issues. -- keywords: +patch nosy:

[issue15305] Test harness unnecessarily disambiguating twice

Petri Lehtinen added the comment: Looks good to me, and all tests also pass on my Ubuntu 12.10. Chris: Would you be willing to commit this and watch the buildbots do their job? Or do the buildbots even use the -j option? -- nosy: +petri.lehtinen

[issue15305] Test harness unnecessarily disambiguating twice

Chris Jerdonek added the comment: I would be happy to commit and watch the buildbots, once I have confidence in the patch though. Question: I noticed that the following was changed in Lib/test/regrtest.py: -with support.temp_cwd(TESTCWD, quiet=True): +with

[issue15305] Test harness unnecessarily disambiguating twice

Chris Jerdonek added the comment: Those two code chunks should really share code by the way I created issue 17283 for this (it's okay to fix the current issue before this one). -- ___ Python tracker rep...@bugs.python.org

[issue15305] Test harness unnecessarily disambiguating twice

New submission from Chris Jerdonek chris.jerdo...@gmail.com: It seems like our test harness is disambiguating more than it needs to for parallel testing. In Lib/test/regrtest.py, we do this-- # Define a writable temp dir that will be used as cwd while running # the tests. The name of the dir

[issue15305] Test harness unnecessarily disambiguating twice

Chris Jerdonek chris.jerdo...@gmail.com added the comment: The former option seems to make more sense to me (a single working directory for all parallel tests using a disambiguated TESTFN). -- ___ Python tracker rep...@bugs.python.org