[issue16379] SQLite error code not exposed to python

miss-islington added the comment: New changeset 8deb7afbd847656842375119f8dbef8aea54 by Erlend Egeberg Aasland in branch 'main': bpo-16379: Fix SQLite version checks in test_module_constants() (GH-28809) https://github.com/python/cpython/commit/8deb7afbd847656842375119f8dbef8aea54

[issue16379] SQLite error code not exposed to python

Change by Erlend E. Aasland : -- pull_requests: +27128 pull_request: https://github.com/python/cpython/pull/28809 ___ Python tracker ___

[issue16379] SQLite error code not exposed to python

Erlend E. Aasland added the comment: Thanks, Torsten for this nice suggestion, Daniel & Aviv for the initial patches, Gerhard & Ezio for helping improving the API, and Pablo, Asif, Hai Shi, & Michael for reviewing and merging! -- resolution: -> fixed stage: patch review -> resolved

[issue16379] SQLite error code not exposed to python

Pablo Galindo Salgado added the comment: New changeset 86d8b465231473f850cc5e906013ba8581ddb503 by Erlend Egeberg Aasland in branch 'main': bpo-16379: expose SQLite error codes and error names in `sqlite3` (GH-27786)

[issue16379] SQLite error code not exposed to python

Change by Erlend E. Aasland : -- pull_requests: +26255 pull_request: https://github.com/python/cpython/pull/27786 ___ Python tracker ___

[issue16379] SQLite error code not exposed to python

Erlend E. Aasland added the comment: >> What would it take to get this merged? > > I've rebased Aviv's PR (GH-1108) onto main and resolved the conflicts. > If I get his blessing, I'll open a PR try to land this. I asked Aviv on GH eight days ago, and I haven't heard anything yet, so I'm

[issue16379] SQLite error code not exposed to python

Erlend E. Aasland added the comment: > What would it take to get this merged? I've rebased Aviv's PR (GH-1108) onto main and resolved the conflicts. If I get his blessing, I'll open a PR try to land this. -- ___ Python tracker

[issue16379] SQLite error code not exposed to python

Change by Erlend Egeberg Aasland : -- nosy: +erlendaasland ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16379] SQLite error code not exposed to python

Change by Ned Batchelder : ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue16379] SQLite error code not exposed to python

Ned Batchelder added the comment: What would it take to get this merged? -- nosy: +nedbat ___ Python tracker ___ ___

[issue16379] SQLite error code not exposed to python

Changes by Mariatta Wijaya : -- versions: +Python 3.7 -Python 3.6 ___ Python tracker ___

[issue16379] SQLite error code not exposed to python

Changes by Aviv Palivoda : -- pull_requests: +1248 ___ Python tracker ___ ___

[issue16379] SQLite error code not exposed to python

Changes by Aviv Palivoda : Added file: http://bugs.python.org/file44331/16379-3.patch ___ Python tracker ___

[issue16379] SQLite error code not exposed to python

Aviv Palivoda added the comment: Attached is a new patch with the encoding problem fixed. -- Added file: http://bugs.python.org/file44306/16379-2.patch ___ Python tracker

[issue16379] SQLite error code not exposed to python

Aviv Palivoda added the comment: Attached is a patch based on Daniel last patch with the following changes: * There is no errorcode mapping. * The exception object has a error_name attribute. I think this two changes should solve the API problems raised by Ezio and Gerhard about the error

[issue16379] SQLite error code not exposed to python

Ezio Melotti added the comment: I think the error message should display both the numeric code and also the error name if available. Instead of using a mapping, perhaps an Enum could be used instead. -- stage: needs patch -> patch review versions: +Python 3.6 -Python 3.4

[issue16379] SQLite error code not exposed to python

Daniel Shahaf added the comment: What's the reasoning behind offering a error code to name mapping? Allowing code that runs into an error to print the error name rather than its numeric value. This saves whoever reads the error message having to look it up himself. his seem problematic to

[issue16379] SQLite error code not exposed to python

Gerhard Häring added the comment: I propose to also set the SQLite extended error code if this is implemented. What's the reasoning behind offering a error code to name mapping? This seem problematic to me. In case a newer SQLite version introduces a new error code, this error code cannot be

[issue16379] SQLite error code not exposed to python

Changes by Gerhard Häring g...@ghaering.de: -- assignee: - ghaering ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16379 ___ ___ Python-bugs-list

[issue16379] SQLite error code not exposed to python

Cal Leeming added the comment: Any update on this? Still seems to be a problem as of 3.4.0. -- nosy: +sleepycal ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16379 ___

[issue16379] SQLite error code not exposed to python

Changes by Ivan Levkivskyi levkivs...@gmail.com: -- nosy: +levkivskyi ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16379 ___ ___ Python-bugs-list

[issue16379] SQLite error code not exposed to python

Daniel Shahaf added the comment: New patch, with better docs and less error leaks, per Ezio's review. -- Added file: http://bugs.python.org/file28496/i16379-v2.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16379

[issue16379] SQLite error code not exposed to python

Daniel Shahaf added the comment: A couple of random eyebrow-raisers I noticed while working on v2: - sqlite3.Warning is a subclass of Exception, rather than sqlite3.Error or builtins.Warning. (Also, the docs say will raise a Warning, intending to refer to sqlite3.Warning, but the lack of

[issue16379] SQLite error code not exposed to python

Daniel Shahaf added the comment: New patch fixing indentation of versionadded markup. -- Added file: http://bugs.python.org/file28497/i16379-v3.diff ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16379

[issue16379] SQLite error code not exposed to python

Changes by Daniel Shahaf pyt...@danielsh.fastmail.net: -- nosy: +danielsh ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16379 ___ ___

[issue16379] SQLite error code not exposed to python

Daniel Shahaf added the comment: Attached patch that: - Adds sqlite3.SQLITE_OK constants - Adds sqlite3.errorcode dictionary - Adds sqlite_errcode attribute to sqlite.Error instances The patch does not add support for extended result codes (http://www.sqlite.org/c3ref/c_abort_rollback.html).

[issue16379] SQLite error code not exposed to python

Daniel Shahaf added the comment: I didn't compile-test the Doc/ part of the patch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16379 ___ ___

[issue16379] SQLite error code not exposed to python

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti, ghaering stage: - needs patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue16379 ___

[issue16379] SQLite error code not exposed to python

New submission from Torsten Landschoff: The sqlite3 module does not expose the sqlite3 error codes to python. This makes it impossible to detect specific error conditions directly. Case in point: If a user selects some random file as the database in our application, we can not detect that it