[issue17861] put opcode information in one place

Change by Ned Deily : -- resolution: -> fixed status: open -> closed ___ Python tracker ___

[issue17861] put opcode information in one place

Serhiy Storchaka added the comment: Currently an explicit `make regen-opcode` and `make regen-opcode-targets` (or just `make regen-all`) are needed for regenerating C files from opcode.py. Is anything left to do in this issue? -- nosy: +serhiy.storchaka

[issue17861] put opcode information in one place

Ned Deily added the comment: Martin, it could if make touch worked when building outside of the source directory (Issue21383). -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861 ___

[issue17861] put opcode information in one place

David Bolen added the comment: This generator script breaks the daily OSX DMG builds on my bolen-dmg buildslave for the 3.x branch. The issue is with the use of with as the slave uses Python 2.5 to build the installer. Now, that's old, and I'm not even sure how necessary the daily builds

[issue17861] put opcode information in one place

Ned Deily added the comment: Thanks, David. Ideally, the generator script shouldn't run during an installer build since presumably the generated file should be up-to-date in the repo. make touch could handle that but the installer build does use a separate build/object directory and doesn't

[issue17861] put opcode information in one place

Roundup Robot added the comment: New changeset 1fd9c3f6cf68 by Ned Deily in branch 'default': Issue #17861: Allow generate_opcode_h to run with a system Python 2.5. http://hg.python.org/cpython/rev/1fd9c3f6cf68 -- ___ Python tracker

[issue17861] put opcode information in one place

Martin v. Löwis added the comment: It would be possible to have the daily DMG builder run make touch. -- ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861 ___

[issue17861] put opcode information in one place

Thomas Wouters added the comment: FYI, this broke building in a separate object directory (again!) for multiple reasons: it's running the script without specifying $(srcdir), and it's writing to $(srcdir)/Include/opcode.h (where $(srcdir) may be unwritable), and it's picking up the wrong

[issue17861] put opcode information in one place

Thomas Wouters added the comment: Here's a minimal patch to at least make the current mechanism work when using a separate build directory. I still don't like the fact that this is importing opcode.py in a different Python than the target Python. Nor do I like that the script hardcodes

[issue17861] put opcode information in one place

Roundup Robot added the comment: New changeset 2b187c9e3e92 by Thomas Wouters in branch 'default': Fix Tools/scripts/generate_opcode_h.py from issue #17861 to work correctly http://hg.python.org/cpython/rev/2b187c9e3e92 -- ___ Python tracker

[issue17861] put opcode information in one place

Kushal Das added the comment: New patch from a clean repo, with changed opcode.h -- Added file: http://bugs.python.org/file34872/issue17861_v5.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861

[issue17861] put opcode information in one place

Kushal Das added the comment: New patch with changes as suggested by Brett. -- Added file: http://bugs.python.org/file34883/issue17861_v6.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861

[issue17861] put opcode information in one place

Roundup Robot added the comment: New changeset 56e7fa27f979 by Kushal Das in branch 'default': Closes Issue 17861: Autogenerate Include/opcode.h from opcode.py. http://hg.python.org/cpython/rev/56e7fa27f979 -- nosy: +python-dev resolution: - fixed stage: patch review -

[issue17861] put opcode information in one place

Kushal Das added the comment: New patch with .hgtouch file details. -- versions: +Python 3.4 -Python 3.5 Added file: http://bugs.python.org/file34842/issue17861_v3.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861

[issue17861] put opcode information in one place

Kushal Das added the comment: New patch with proper changesets. -- Added file: http://bugs.python.org/file34855/issue17861_v4.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861 ___

[issue17861] put opcode information in one place

Martin v. Löwis added the comment: Please add the file to .hgtouch as well, and verify that make touch works correctly. -- nosy: +loewis ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861

[issue17861] put opcode information in one place

Éric Araujo added the comment: Patch looks good to me. -- nosy: +eric.araujo versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861 ___

[issue17861] put opcode information in one place

Changes by STINNER Victor victor.stin...@gmail.com: -- nosy: +haypo ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861 ___ ___ Python-bugs-list

[issue17861] put opcode information in one place

Kushal Das added the comment: As we discussed on #python-dev channel this new patch includes the script in Tools/scripts/generate_opcode_h.py and it also contains the required Makefile.pre.in change so that it gets auto(re)generated at compile time if required. -- keywords: +patch

[issue17861] put opcode information in one place

Changes by Ezio Melotti ezio.melo...@gmail.com: -- nosy: +ezio.melotti stage: needs patch - patch review ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861 ___

[issue17861] put opcode information in one place

Kushal Das added the comment: Version 2 of the patchset edited as per review. -- Added file: http://bugs.python.org/file30066/issue17861_v2.patch ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861

[issue17861] put opcode information in one place

New submission from Benjamin Peterson: Right now, opcode information is duplicated in Include/opcode.h and Lib/opcode.py. I should only have to update one manually and have the other one generated automatically. opcode.h should probably be generated by a script from opcode.py. --

[issue17861] put opcode information in one place

Kushal Das added the comment: Here is a simple script which prints the opcode.h in console. We can redirect it as required. -- nosy: +kushaldas Added file: http://bugs.python.org/file30045/generate_opcode_h.py ___ Python tracker

[issue17861] put opcode information in one place

Kushal Das added the comment: Second version of the script with the fix for HAVE_ARGUMENT -- Added file: http://bugs.python.org/file30046/generate_opcode_h.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861

[issue17861] put opcode information in one place

Kushal Das added the comment: Third revision with fixed empty spaces at the end of the lines. -- Added file: http://bugs.python.org/file30048/generate_opcode_h.py ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue17861