[issue19468] Relax the type restriction on reloaded modules

2020-06-05 Thread Brett Cannon
Brett Cannon added the comment: Thanks for the PR, Furkan ! -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue19468] Relax the type restriction on reloaded modules

2020-06-05 Thread miss-islington
miss-islington added the comment: New changeset fef1fae9df3b03510f9defb25bd0388135b4c591 by Furkan Önder in branch 'master': bpo-19468: delete unnecessary instance check in importlib.reload() (GH-19424) https://github.com/python/cpython/commit/fef1fae9df3b03510f9defb25bd0388135b4c591

[issue19468] Relax the type restriction on reloaded modules

2020-04-11 Thread Furkan Onder
Furkan Onder added the comment: PR has been sent. -- ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19468] Relax the type restriction on reloaded modules

2020-04-07 Thread Furkan Onder
Change by Furkan Onder : -- keywords: +patch nosy: +furkanonder nosy_count: 3.0 -> 4.0 pull_requests: +18783 stage: needs patch -> patch review pull_request: https://github.com/python/cpython/pull/19424 ___ Python tracker

[issue19468] Relax the type restriction on reloaded modules

2019-04-26 Thread Mark Lawrence
Change by Mark Lawrence : -- nosy: -BreamoreBoy ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue19468] Relax the type restriction on reloaded modules

2014-10-03 Thread Brett Cannon
Brett Cannon added the comment: I think the check can be removed as long as an AttributeError is caught when trying to access module.__name__ and a message mentioning that the user probably meant to pass in a module is used, e.g.: try: name = module.__spec__.name except AttributeError:

[issue19468] Relax the type restriction on reloaded modules

2014-10-02 Thread Mark Lawrence
Mark Lawrence added the comment: Can we or can't we remove the check as Eric has proposed in msg201874? -- nosy: +BreamoreBoy versions: +Python 3.5 -Python 3.4 ___ Python tracker rep...@bugs.python.org http://bugs.python.org/issue19468

[issue19468] Relax the type restriction on reloaded modules

2013-10-31 Thread Eric Snow
New submission from Eric Snow: The first thing that importlib.reload() does is to verify that the passed module is an instance of types.ModuleType (Lib/importlib/__init__.py:107). This check seems unnecessary to me. We really don't have a functional need for the check (that I know of).