[issue31106] os.posix_fallocate() generate exception with errno 0

Ned Deily added the comment: P.S.: > Koobs, could you please open a new issue about the failing test? Unless > someone knows of a foolproof way to determine on all platforms that a file is > resident on ZFS, the fix is to skip the test on FreeBSD as well if ZFS is > likely

[issue31106] os.posix_fallocate() generate exception with errno 0

Ned Deily added the comment: Considering we have already shipped this fix in 3.6.5, I guess we can live without a NEWS entry at this point -> closing this issue. -- priority: deferred blocker -> stage: patch review -> resolved status: open -> closed

[issue31106] os.posix_fallocate() generate exception with errno 0

Ned Deily added the comment: I agree with Alexey's analysis. Koobs, could you please open a new issue about the failing test? Unless someone knows of a foolproof way to determine on all platforms that a file is resident on ZFS, the fix is to skip the test on FreeBSD as well

[issue31106] os.posix_fallocate() generate exception with errno 0

Alexey Izbyshev added the comment: The failed test is test_posix_fallocate, not test_posix_fallocate_errno. The former special-cases Solaris for EINVAL already, and the latter merely passes an invalid descriptor. It seems that this particular issue is still open only

[issue31106] os.posix_fallocate() generate exception with errno 0

Kubilay Kocak added the comment: I believe changeset d4b93e21c2664d6a78e0656e7a7be0807be1c352 may be the cause of buildbot failures on FreeBSD (at least koobs-freebsd-current, log attached), due to only the EBADF error being handled (not EINVAL, et al). Unfortunately

[issue31106] os.posix_fallocate() generate exception with errno 0

Andrew Svetlov added the comment: New changeset 3a04c52a9eb03e31c60037248b872f3662002a4d by Andrew Svetlov (Miss Islington (bot)) in branch '3.6': bpo-31106: Fix handling of erros in posix_fallocate() and posix_fadvise() (GH-3000) (GH-3000) (#4101)

[issue31106] os.posix_fallocate() generate exception with errno 0

Марк Коренберг added the comment: Yes, I can. Should I create new PR ? to which branch ? -- ___ Python tracker ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Serhiy Storchaka added the comment: Марк, do you mind to add a NEWS entry? -- ___ Python tracker ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Change by Roundup Robot : -- keywords: +patch pull_requests: +4071 ___ Python tracker ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Larry Hastings added the comment: You understand correctly. It won't be backported to Python 3.5. -- ___ Python tracker ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Марк Коренберг added the comment: If I understand right, Python 3.5 will not be fixed with this pathc. Right ? If yes, I will tell Debian maintainers to backport this patch to Python 3.5, which is shipped with latest stable Debian 9. -- ___ Python

[issue31106] os.posix_fallocate() generate exception with errno 0

Serhiy Storchaka added the comment: Needed a NEWS entry. -- nosy: +serhiy.storchaka versions: -Python 3.5 ___ Python tracker ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Changes by Larry Hastings : -- pull_requests: +3129 ___ Python tracker ___ ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Larry Hastings added the comment: New changeset d4b93e21c2664d6a78e0656e7a7be0807be1c352 by larryhastings (Коренберг Марк) in branch 'master': bpo-31106: Fix handling of erros in posix_fallocate() and posix_fadvise() (#3000) (#3000)

[issue31106] os.posix_fallocate() generate exception with errno 0

Changes by STINNER Victor : -- nosy: +haypo ___ Python tracker ___ ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Mariatta Wijaya added the comment: Adding Larry who is listed as posix expert. -- nosy: +Mariatta, larry stage: -> patch review ___ Python tracker ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Марк Коренберг added the comment: posix_fadvise() is also affected :( Fixed in this patch. -- ___ Python tracker ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Марк Коренберг added the comment: All checks passed. Please merge. -- ___ Python tracker ___ ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Марк Коренберг added the comment: https://github.com/python/cpython/pull/3000 -- ___ Python tracker ___ ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Changes by Марк Коренберг : -- pull_requests: +3036 ___ Python tracker ___ ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Марк Коренберг added the comment: Also, EINTR will not be caught too (!) -- ___ Python tracker ___ ___

[issue31106] os.posix_fallocate() generate exception with errno 0

Марк Коренберг added the comment: man posix_fallocate: RETURN VALUE posix_fallocate() returns zero on success, or an error number on failure. Note that errno is not set. -- ___ Python tracker

[issue31106] os.posix_fallocate() generate exception with errno 0

New submission from Марк Коренберг: === os.posix_fallocate(os.open('qwe.qwe', os.O_RDONLY|os.O_CREAT), 0, 1024*1024) === generates OSError with errno 0. Suppose this happen due to O_RDONLY flag. strace : open("qwe.qwe", O_RDONLY|O_CREAT|O_CLOEXEC, 0777) = 3 fallocate(3, 0, 0, 1048576)