[issue33169] importlib.invalidate_caches() doesn't clear all caches

Brett Cannon added the comment: All done in 3.7 and master. -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33169] importlib.invalidate_caches() doesn't clear all caches

Brett Cannon added the comment: New changeset a09bb87c1eebb07b01b8105cf536704893aec565 by Brett Cannon in branch '3.7': [3.7] bpo-33169: Remove values of `None` from sys.path_importer_cache when invalidating caches (GH-6402) (GH-6403)

[issue33169] importlib.invalidate_caches() doesn't clear all caches

Change by Brett Cannon : -- pull_requests: +6108 ___ Python tracker ___ ___

[issue33169] importlib.invalidate_caches() doesn't clear all caches

Brett Cannon added the comment: New changeset 9e2be60634914f23db2ae5624e4acc9335bf5fea by Brett Cannon in branch 'master': bpo-33169: Remove values of `None` from sys.path_importer_cache when invalidating caches (GH-6402)

[issue33169] importlib.invalidate_caches() doesn't clear all caches

Change by Brett Cannon : -- keywords: +patch pull_requests: +6107 stage: -> patch review ___ Python tracker ___

[issue33169] importlib.invalidate_caches() doesn't clear all caches

Brett Cannon added the comment: OK, I will update importlib.machinery.PathFinder.invalidate_caches() to also drop None from sys.path_importer_cache (objects that are not None and do not define invalidate_caches() will be left alone just like they are today). I should

[issue33169] importlib.invalidate_caches() doesn't clear all caches

Guido van Rossum added the comment: SGTM. On Fri, Mar 30, 2018, 06:41 Ned Deily wrote: > > Ned Deily added the comment: > > The current behavior is causing problems for at least some use cases so it > does seems to be closer to a

[issue33169] importlib.invalidate_caches() doesn't clear all caches

Ned Deily added the comment: The current behavior is causing problems for at least some use cases so it does seems to be closer to a bug than a feature. If there is agreement that it is desirable to make the change, I think it's better to do it now in 3.7 than later.

[issue33169] importlib.invalidate_caches() doesn't clear all caches

Nick Coghlan added the comment: I agree that we can't change 3.6 at this late stage, but the change is borderline enough on the "new feature"/"bug fix" scale that I think it's worth asking Ned if he's comfortable with us changing it for 3.7.0b4. Ned: the change we'd like

[issue33169] importlib.invalidate_caches() doesn't clear all caches

Brett Cannon added the comment: Correct because as documented it calls invalidate_caches() on meta-path finders and the one that handles sys.path calls invalidate_caches() on the finders found in sys.path_importer_cache() (as documented by

[issue33169] importlib.invalidate_caches() doesn't clear all caches

Change by Brett Cannon : -- nosy: +brett.cannon, eric.snow, ncoghlan ___ Python tracker ___

[issue33169] importlib.invalidate_caches() doesn't clear all caches

New submission from Guido van Rossum : See https://github.com/python/mypy/pull/4811. To summarize, importlib.invalidate_caches() doesn't clear the negative cache in sys.path_importer_cache. Could be related to https://bugs.python.org/issue30891? -- messages: 314595