[issue33189] pygettext doesn't work with f-strings

Change by Serhiy Storchaka : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue33189] pygettext doesn't work with f-strings

miss-islington added the comment: New changeset 6f870935c2e024cbd1cc379f85e6a66d7711dcc7 by Miss Islington (bot) in branch '3.6': bpo-33189: pygettext.py now accepts only literal strings (GH-6364)

[issue33189] pygettext doesn't work with f-strings

Change by miss-islington : -- pull_requests: +6229 ___ Python tracker ___

[issue33189] pygettext doesn't work with f-strings

miss-islington added the comment: New changeset a4fb580f701df5bf07ce569a4f43abfb05c92759 by Miss Islington (bot) in branch '3.7': bpo-33189: pygettext.py now accepts only literal strings (GH-6364)

[issue33189] pygettext doesn't work with f-strings

Change by miss-islington : -- pull_requests: +6227 ___ Python tracker ___

[issue33189] pygettext doesn't work with f-strings

Change by miss-islington : -- pull_requests: +6228 ___ Python tracker ___

[issue33189] pygettext doesn't work with f-strings

Serhiy Storchaka added the comment: New changeset 69524821a87251b7aee966f6e46b3810ff5aaa64 by Serhiy Storchaka in branch 'master': bpo-33189: pygettext.py now accepts only literal strings (GH-6364)

[issue33189] pygettext doesn't work with f-strings

Serhiy Storchaka added the comment: If there are no objections I'm going to merge PR 6364 in 24 hours. -- assignee: -> serhiy.storchaka nosy: +lemburg ___ Python tracker

[issue33189] pygettext doesn't work with f-strings

Change by Éric Araujo : -- nosy: +eric.araujo ___ Python tracker ___ ___ Python-bugs-list

[issue33189] pygettext doesn't work with f-strings

Change by Serhiy Storchaka : -- keywords: +patch pull_requests: +6074 stage: -> patch review ___ Python tracker ___

[issue33189] pygettext doesn't work with f-strings

Riccardo Polignieri added the comment: > the error should be better Yes, that's what I maeant - sorry I should have phrased better. I marked by mistake a couple of f-strings for translation and totally forgot about it for a while... it took me some time to

[issue33189] pygettext doesn't work with f-strings

Serhiy Storchaka added the comment: I agree that pygettext should not and can not support f-strings, but the error should be better. The problem is that an f-string expression is tokenized as literal strings, but eval() can't evaluate it out of context.

[issue33189] pygettext doesn't work with f-strings

Stefan Behnel added the comment: Is there really a use case for this? I would normally expect place holders to get replaced *after* translation, i.e. in the translated text, not before. -- nosy: +scoder ___ Python tracker

[issue33189] pygettext doesn't work with f-strings

New submission from Riccardo Polignieri : Tested (on windows) with python 3.6, but I guess it's the same in py3.7: # test.py def hello(x): print(_(f'hello {x}')) > py pygettext.py test.py Traceback (most recent call last): File "C:\Program