[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Éric Araujo added the comment: > it is useful to build old versions, sometimes 7 year old versions, to confirm > if/when the behaviour regressed. I think the sticking point is this: it is not expected that old versions should work as-is with the newest Python. Can you do your build and

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: Let's see how it goes. In the worst case, we have time before Python 3.11 final to revert it one more time. -- resolution: -> fixed status: open -> closed ___ Python tracker

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Łukasz Langa added the comment: New changeset 19ba2122ac7313ac29207360cfa864a275b9489e by Victor Stinner in branch 'main': bpo-37330: open() no longer accept 'U' in file mode (GH-28118) https://github.com/python/cpython/commit/19ba2122ac7313ac29207360cfa864a275b9489e -- nosy:

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: > docutils is already fixed in the development version. I requested a release: > https://sourceforge.net/p/docutils/bugs/364/ At 2019-07-22, Günter Milde wrote: "Docutils 0.15 is released" (with the fix). The latest docutils version is 0.17.1. --

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: > This breaks Samba's build: > https://bugzilla.samba.org/show_bug.cgi?id=14266 Samba has been updated in the meanwhile, buildtools/wafsamba/samba_utils.py: -function_code = node.read('rU', None) +function_code =

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: I reopen the issue. I created PR 28118 to try again to remove the "U" mode in Python 3.11. -- resolution: fixed -> status: closed -> open versions: +Python 3.11 -Python 3.9 ___ Python tracker

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Change by STINNER Victor : -- pull_requests: +26559 pull_request: https://github.com/python/cpython/pull/28118 ___ Python tracker ___

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: New changeset 942f7a2dea2e95a0fa848329565c0d0288d92e47 by Victor Stinner in branch 'master': bpo-39674: Revert "bpo-37330: open() no longer accept 'U' in file mode (GH-16959)" (GH-18767)

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: Le mer. 4 mars 2020 à 03:01, Andrew Bartlett a écrit : > (...) but that a valid build script that operates correctly on Python 3.8 > will no longer, without warning to us, (...) Displaying warnings by default or not is an old debate. I added the "Python

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Andrew Bartlett added the comment: ...Python 2.9 or at best 2.10. Of course I mean Python 3.9 or at best 3.10. Sorry for the confusion. -- ___ Python tracker ___

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Andrew Bartlett added the comment: I think we are speaking past each other. Yes, Python 2 is no longer being changed, which is awesome as we need for fear breakage of the older builds that use that for the build system. The issue isn't the particular language feature, or that there is no

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Change by STINNER Victor : -- pull_requests: +18125 pull_request: https://github.com/python/cpython/pull/18767 ___ Python tracker ___

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: > Thankfully we don't need universal newlines, but no matter if we need them, > old versions of Samba will fail to build without a fix-up patch. io.open() is available since Python 2.6 and handles different kinds of newlines transparently. Example: $

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Andrew Bartlett added the comment: Thanks for the reply. To clarify, it is best to understand where Samba thinks of itself in terms of Python. We use python, but we don't really think of ourselves as a python project, and while we have some developers with a depth of experience in the

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: > While we are of course able to patch new versions of Samba, this will make it > harder to bisect back though Samba history. I don't understand the bisect part. Would you mind to elaborate? What do you want to bisect? > It would be really great if this

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Andrew Bartlett added the comment: This breaks Samba's build: https://bugzilla.samba.org/show_bug.cgi?id=14266 While we are of course able to patch new versions of Samba, this will make it harder to bisect back though Samba history. It would be really great if this kind of change could be

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: > should we backport a documentation change for this? (the deprecatedremoved > says 4.0 currently) Done. Thanks for the reminder. -- ___ Python tracker

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

miss-islington added the comment: New changeset 4cb08b6c0ae6989d169dd48c2b24087941f6d0b0 by Miss Skeleton (bot) in branch '3.7': bpo-37330: open(): "U" mode is removed in Python 3.9 (GH-16972) https://github.com/python/cpython/commit/4cb08b6c0ae6989d169dd48c2b24087941f6d0b0 --

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Change by miss-islington : -- pull_requests: +16508 pull_request: https://github.com/python/cpython/pull/16982 ___ Python tracker ___

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: New changeset 1d2862a323ae1387e306942253b1e487018e2b7f by Victor Stinner in branch '3.8': bpo-37330: open(): "U" mode is removed in Python 3.9 (GH-16972) https://github.com/python/cpython/commit/1d2862a323ae1387e306942253b1e487018e2b7f --

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Change by STINNER Victor : -- pull_requests: +16499 pull_request: https://github.com/python/cpython/pull/16972 ___ Python tracker ___

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Anthony Sottile added the comment: should we backport a documentation change for this? (the deprecatedremoved says 4.0 currently) -- nosy: +Anthony Sottile ___ Python tracker

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: Thanks for the review Serhiy ;-) -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: New changeset e471e72977c83664f13d041c78549140c86c92de by Victor Stinner in branch 'master': bpo-37330: open() no longer accept 'U' in file mode (GH-16959) https://github.com/python/cpython/commit/e471e72977c83664f13d041c78549140c86c92de --

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: I cited this change in the PEP 608 "Coordinated Python release". -- ___ Python tracker ___ ___

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Change by STINNER Victor : -- pull_requests: +16487 pull_request: https://github.com/python/cpython/pull/16959 ___ Python tracker ___

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: docutils is already fixed in the development version. I requested a release: https://sourceforge.net/p/docutils/bugs/364/ -- ___ Python tracker

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: I reported the issue to docutils. In fact, docutils FileInput class was already fixed to prevent the deprecation warning, but there was no release yet: https://sourceforge.net/p/docutils/bugs/363/ -- ___ Python

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

STINNER Victor added the comment: I prefer to push backward incompatible changes at the beginning of a dev cycle (Python 3.9), so we have room to revert it later if it causes too much trouble. -- ___ Python tracker

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Change by STINNER Victor : -- nosy: +pitrou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

Change by STINNER Victor : -- keywords: +patch pull_requests: +14042 stage: -> patch review pull_request: https://github.com/python/cpython/pull/14204 ___ Python tracker ___

[issue37330] open(): remove 'U' mode, deprecated since Python 3.3

New submission from STINNER Victor : The builtin open() function accepts 'U' in the file mode, but it emits a DeprecationWarning since Python 3.4, change made in bpo-15204: commit 6787a3806ee6a85a6f21ede70c10e15a6df267c4 Author: Serhiy Storchaka Date: Sat Nov 23 22:12:06 2013 +0200