[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Eric Snow added the comment: Thanks for the updates, Eddie. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Eddie Elizondo added the comment: It seems that we are back on track with perf being back to neutral! I've created 4 new PRs. Each with an optimization applied on top of the baseline introduction of instance immortalization. The main PR 19474 currently stands at around 4%, after rebasing

[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Inada Naoki added the comment: All of these optimizations should be disabled by default. * It will cause leak when Python is embedded. * Even for python command, it will break __del__ and weakref callbacks. -- ___ Python tracker

[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Change by Eddie Elizondo : -- pull_requests: +29621 pull_request: https://github.com/python/cpython/pull/31491 ___ Python tracker ___

[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Change by Eddie Elizondo : -- pull_requests: +29620 pull_request: https://github.com/python/cpython/pull/31490 ___ Python tracker ___

[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Change by Eddie Elizondo : -- pull_requests: +29619 pull_request: https://github.com/python/cpython/pull/31489 ___ Python tracker ___

[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Change by Eddie Elizondo : -- pull_requests: +29618 pull_request: https://github.com/python/cpython/pull/31488 ___ Python tracker ___

[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Inada Naoki added the comment: I think making more objects immortal by default will reduce the gap, although I am not sure it can be 2%. (I guess 3% and I think it is acceptable gap.) * Code attributes (contents of co_consts, co_names, etc...) in deep frozen modules. * only if

[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Eddie Elizondo added the comment: @eric.snow great to hear about this update! I'll start looking at some of the techniques that we talked about to improve performance, I'm optimistic that we'll be able to close down the gap to 2%. -- ___ Python

[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Eric Snow added the comment: @Eddie, what can I do to push this forward? FYI, in addition to the python-dev thread a few weeks back, I've brought the matter up with the steering council. [1] Also, if we can get back to performance-neutral (currently at about 4% slower) then there would be

[issue40255] Fixing Copy on Writes from reference counting and immortal objects

Change by STINNER Victor : -- title: Fixing Copy on Writes from reference counting -> Fixing Copy on Writes from reference counting and immortal objects ___ Python tracker