[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: Yeah, this looks like something else. I am closing this issue then -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: Here is the stack trace - still during initialization: And in "ceval.c, but dbx does not like how the 'h files are being used: line 941 and 659 lines don't match :( (dbx) list "object.h" has only 659 lines Segmentation fault in _PyEval_EvalFrameDefault at line

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: Master has to be something else then -- ___ Python tracker ___ ___ Python-bugs-list

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: On 07/07/2020 11:12, Michael Felt wrote: > Michael Felt added the comment: > > I saw the mails last night and restarted my bot - it still fails. > Checking manually for master, 3.9, 3.8 and 3.7 branches. Will let you 3.7, 3.8 and 3.9 built, master does not.

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: I saw the mails last night and restarted my bot - it still fails. Checking manually for master, 3.9, 3.8 and 3.7 branches. Will let you know asap. Yes - expecting 3.8 and 3.7 to build, but want to be sure. On 06/07/2020 23:34, Pablo Galindo Salgado wrote: >

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

miss-islington added the comment: New changeset edeaf61b6827ab3a8673aff1fb7717917f08f003 by Miss Islington (bot) in branch '3.9': bpo-41215: Make assertion in the new parser more strict (GH-21364) https://github.com/python/cpython/commit/edeaf61b6827ab3a8673aff1fb7717917f08f003 --

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Lysandros Nikolaou added the comment: New changeset 782f44b8fb07ec33cee148b2b6b4cf53024fe0cd by Lysandros Nikolaou in branch 'master': bpo-41215: Make assertion in the new parser more strict (GH-21364) https://github.com/python/cpython/commit/782f44b8fb07ec33cee148b2b6b4cf53024fe0cd

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Change by miss-islington : -- pull_requests: +20512 pull_request: https://github.com/python/cpython/pull/21367 ___ Python tracker ___

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Lysandros Nikolaou added the comment: > Can you prepare a PR? Done. -- ___ Python tracker ___ ___ Python-bugs-list mailing list

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Change by Lysandros Nikolaou : -- pull_requests: +20509 pull_request: https://github.com/python/cpython/pull/21364 ___ Python tracker ___

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: > Pablo, on second thought, should we maybe change the assertion to > `assert(name_len > 0)`? Yup, although not sure how that can happen (but I agree that's the point of assertions *wink*) Can you prepare a PR? --

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Lysandros Nikolaou added the comment: Pablo, on second thought, should we maybe change the assertion to `assert(name_len > 0)`? -- ___ Python tracker ___

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: Michael, could you check the latest master and 3.9 HEAD? If you don;t see the problem anymore, we can close this issue :) -- ___ Python tracker

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: I also tested xlC v16, and then it just hung, for hours - while all of you were being more productive. I’ll kickoff my bot again, and see how it goes. Sent from my iPhone > On 6 Jul 2020, at 21:31, miss-islington wrote: > >  > miss-islington added the

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

miss-islington added the comment: New changeset 1ac0cbca369f16f9191833dd54536482fb141a98 by Pablo Galindo in branch 'master': bpo-41215: Don't use NULL by default in the PEG parser keyword list (GH-21355) https://github.com/python/cpython/commit/1ac0cbca369f16f9191833dd54536482fb141a98

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

miss-islington added the comment: New changeset 54f115dd533653c43b3c5541bf5936b22e484474 by Pablo Galindo in branch '3.9': [3.9] bpo-41215: Don't use NULL by default in the PEG parser keyword list (GH-21355) (GH-21356)

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Change by Pablo Galindo Salgado : -- pull_requests: +20502 pull_request: https://github.com/python/cpython/pull/21356 ___ Python tracker ___

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Change by Pablo Galindo Salgado : -- keywords: +patch pull_requests: +20501 stage: -> patch review pull_request: https://github.com/python/cpython/pull/21355 ___ Python tracker

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: > Pablo, I can do that as well, if you don't have the time. Thanks! I had the PR ready, just needed some time to push it :) -- ___ Python tracker

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Lysandros Nikolaou added the comment: Pablo, I can do that as well, if you don't have the time. -- ___ Python tracker ___ ___

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: Well, in any case, I will submit a patch today to the parser generator to substitute the NULL for single-element arrays which seems to work. Michael, could you confirm that this patch works for you: diff --git a/Parser/pegen/parse.c

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

David Edelsohn added the comment: Maybe XLC was being overly aggressive with speculation and it now is fixed. I can't tell if Michael's earlier comment meant that it no longer crashes with XLC v16. -- ___ Python tracker

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: Note: - two different systems, different HW, different OS levels. xlc-v11, master : commit deb016224cc506503fb05e821a60158c83918ed4 (HEAD -> master, upstream/master, upstream/HEAD) Segmentation fault in _PyEval_EvalFrameDefault at line 941 in file

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: > I don't believe that this is an XLC bug, but I suspect that it is undefined > behavior / implementation-defined behavior. I was looking at the C99 standard but could not find anything that makes this undefined. Do you know what this construct is

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: I tried check.c and check_bad.c using xlc-v11 (on my POWER6) - and the results were the same as in Pablo's entry. On the gcc119 host - using the v13 compiler, check_bad does not crash. Not gotten to testing xlc-v16 yet. I have seen lots of options today -

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

David Edelsohn added the comment: I don't believe that this is an XLC bug, but I suspect that it is undefined behavior / implementation-defined behavior. I suspect that this is tripping over AIX/XLC null behavior. AIX specifically and intentionally maps the first page of memory at address 0

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: On 06/07/2020 16:35, Pablo Galindo Salgado wrote: > Pablo Galindo Salgado added the comment: > >> Glad you figured it out! > Well, this is not over ;) > > We should confirm that this is either a bug in XLC or a violation of C99 probably a bug (that they might

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: > Glad you figured it out! Well, this is not over ;) We should confirm that this is either a bug in XLC or a violation of C99 -- ___ Python tracker

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: Glad you figured it out! I doubt I would have. Thx!! On 06/07/2020 14:37, Pablo Galindo Salgado wrote: > Pablo Galindo Salgado added the comment: > > This is enough to reproduce the problem: > > #include > > typedef struct { > char *str; > int type;

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: This is enough to reproduce the problem: #include typedef struct { char *str; int type; } KeywordToken; static KeywordToken *the_array[] = { NULL, NULL, (KeywordToken[]) { {"if", 510}, {"in", 518}, {"as",

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Change by Pablo Galindo Salgado : -- Removed message: https://bugs.python.org/msg373107 ___ Python tracker ___ ___ Python-bugs-list

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: This is enough to reproduce the problem: #include typedef struct { char *str; int type; } KeywordToken; static KeywordToken *the_array[] = { NULL, NULL, (KeywordToken[]) { {"if", 510}, {"in", 518}, {"as",

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: Ok, this is definitively something going on with XLC. This patch solves the segfault: diff --git a/Parser/pegen/parse.c b/Parser/pegen/parse.c index 9d3ac575df..e5511bf815 100644 --- a/Parser/pegen/parse.c +++ b/Parser/pegen/parse.c @@ -1,6 +1,6 @@

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: Ok, I have investigated more and it seems that XLC is miscompiling the keyword list. For instance, if you add: index 9d3ac575df..70d431e6be 100644 --- a/Parser/pegen/parse.c +++ b/Parser/pegen/parse.c @@ -1,6 +1,6 @@ -// @generated by pegen.py from

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: If I check out commit c5fc15685202cda73f7c3f5c6f299b0945f58508 I get a crash, but not on master or 3.9 HEAD. So whatever error happens with XLC in the PEG parser c5fc15685202cda73f7c3f5c6f299b0945f58508 seems that is already solved. Could you confirm

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: I tried compiling Python 3.10 with XLC on AIX and I get a crash in a different place that does not involve the parser: _PyEval_EvalFrameDefault(tstate = 0x200764e0, f = 0x300b5190, throwflag = 0), line 427 in "object.h" _PyEval_EvalCode(tstate =

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: My apologies for lack of context. On 05/07/2020 20:27, Pablo Galindo Salgado wrote: > Pablo Galindo Salgado added the comment: > > Unfortunately, I am having a hard time parsing your error description because > is not immediate to distinguish: > > - What is

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: Iirc, my debug shows that k is not NULL, as k++ is not going to suddenly become smaller. And my debug shows it grows by a constant. My gut says the pointer to the base of the tokens is wrong, because the key types are such different values. Or do you know

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: Michael, can you try with this patch: diff --git a/Parser/pegen.c b/Parser/pegen.c index 53e3d49138..7faeec26ad 100644 --- a/Parser/pegen.c +++ b/Parser/pegen.c @@ -528,7 +528,7 @@ _get_keyword_or_name_type(Parser *p, const char *name, int name_len)

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Pablo Galindo Salgado added the comment: Unfortunately, I am having a hard time parsing your error description because is not immediate to distinguish: - What is the error. - Where does the error happen. - How to reproduce the error. Could you kindly provide more scoped information about

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Change by Pablo Galindo Salgado : -- nosy: +lys.nikolaou ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: OK - merely added some fprintf statements. When it is working as expected, the k->type values seem to be between 500 and 535 - when it fails the k->type value is frequently 9 digits (e.g., 537120904) - and it seems to never become -1 -- which would end the

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Michael Felt added the comment: Well, the first step -s just showing where the segmentation fault occurs (in pegen.c). I am not really 'wiser' in what I should be looking at. I'll try adding a fprintf(stderr, ) to see if I can figure out a bit more. For the experts: (dbx) where

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

Change by Stefan Krah : -- nosy: +skrah ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue41215] AIX: build fails for xlc/xlC since new PEG parser

New submission from Michael Felt : As the bots were both running - based on gcc - this was not noticed immediately. issue40334 implements PEP 617, the new PEG parser for CPython. Using bisect I located: commit c5fc15685202cda73f7c3f5c6f299b0945f58508 (HEAD, refs/bisect/bad) Author: Pablo