[issue44616] Incorrect tracing for "except" with variable

2021-07-15 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Thanks Ned. Seems you might be right. I thought I'd done a clean test, but in any event, I just pulled 3.10 head and verified that it's producing 100% coverage. Thanks all for the fix! -- resolution: -> fixed status: open -> closed

[issue44616] Incorrect tracing for "except" with variable

2021-07-15 Thread Ned Batchelder
Ned Batchelder added the comment: Barry, is it possible you accidentally used the beta 4? I ran the test suite with a freshly built 3.10, but by mistake was still using the beta, and was surprised. Once I really got the latest build in place (Python 3.10.0b4+ (heads/3.10:47695e3c88, Jul

[issue44616] Incorrect tracing for "except" with variable

2021-07-14 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: I just retested my test case (see the coveragepy link below) with Python 3.10 git head and coveragepy git head, and I'm still seeing the misses only in Python 3.10: -- coverage: platform darwin, python 3.10.0-beta-4 --- Name

[issue44616] Incorrect tracing for "except" with variable

2021-07-14 Thread Pablo Galindo Salgado
Change by Pablo Galindo Salgado : -- resolution: -> fixed stage: patch review -> resolved status: open -> closed ___ Python tracker ___

[issue44616] Incorrect tracing for "except" with variable

2021-07-14 Thread Mark Shannon
Mark Shannon added the comment: New changeset 794ff7d505f852dc4e0f94901dc7387afaead3bb by Mark Shannon in branch '3.10': bpo-44616: Mark all clean up instructions at end of named exception block as artificial (GH-27109) (GH-27135)

[issue44616] Incorrect tracing for "except" with variable

2021-07-14 Thread Mark Shannon
Change by Mark Shannon : -- pull_requests: +25678 pull_request: https://github.com/python/cpython/pull/27135 ___ Python tracker ___

[issue44616] Incorrect tracing for "except" with variable

2021-07-14 Thread Mark Shannon
Mark Shannon added the comment: New changeset e5862f79c16e28f1ec51d179698739a9b2d8c1d2 by Mark Shannon in branch 'main': bpo-44616: Mark all clean up instructions at end of named exception block as artificial (GH-27109)

[issue44616] Incorrect tracing for "except" with variable

2021-07-13 Thread Mark Shannon
Change by Mark Shannon : -- keywords: +patch pull_requests: +25655 stage: -> patch review pull_request: https://github.com/python/cpython/pull/27109 ___ Python tracker ___

[issue44616] Incorrect tracing for "except" with variable

2021-07-13 Thread Mark Shannon
Mark Shannon added the comment: Thanks Ned, you're doing a fantastic job of finding these issues. Sorry for keeping you so busy with this. This one was a latent bug, exposed by fixing https://bugs.python.org/issue44570. -- ___ Python tracker

[issue44616] Incorrect tracing for "except" with variable

2021-07-12 Thread Barry A. Warsaw
Barry A. Warsaw added the comment: Pablo, this is triggered by my bug report here: https://github.com/nedbat/coveragepy/issues/1187 I tested this again today with the 3.10 git head and still got the coverage misses. Happy to try any other combinations. --

[issue44616] Incorrect tracing for "except" with variable

2021-07-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: I assume this is due to some artificial bytecode for cleaning the variable in the exception -- ___ Python tracker ___

[issue44616] Incorrect tracing for "except" with variable

2021-07-12 Thread Pablo Galindo Salgado
Pablo Galindo Salgado added the comment: Marking as release blocker for the first release candidate. Ned, I assume this comes from some recent bug report in coverage, but it would be great if you could ask your users to test the latest beta and report any issue before we release the first

[issue44616] Incorrect tracing for "except" with variable

2021-07-12 Thread Barry A. Warsaw
Change by Barry A. Warsaw : -- nosy: +barry ___ Python tracker ___ ___ Python-bugs-list mailing list Unsubscribe:

[issue44616] Incorrect tracing for "except" with variable

2021-07-12 Thread Ned Batchelder
Ned Batchelder added the comment: Based on https://github.com/nedbat/coveragepy/issues/1187, btw -- ___ Python tracker ___ ___

[issue44616] Incorrect tracing for "except" with variable

2021-07-12 Thread Ned Batchelder
New submission from Ned Batchelder : This construct isn't traced properly: except ExceptionName as var: if something: raise Here's a reproducer: -- 8< - import linecache, sys def trace(frame, event, arg): # The weird globals here