[issue47196] Function pointer cast in test_imp

Change by Christian Heimes : -- components: +Tests resolution: -> fixed stage: patch review -> resolved status: open -> closed type: -> enhancement versions: +Python 3.11 ___ Python tracker

[issue47196] Function pointer cast in test_imp

miss-islington added the comment: New changeset 3faa9f78d4b9a8c0fd4657b434bdb08ae1f28800 by Hood Chatham in branch 'main': bpo-47196: Fix one more PyInit function signature (GH-32280) https://github.com/python/cpython/commit/3faa9f78d4b9a8c0fd4657b434bdb08ae1f28800 --

[issue47196] Function pointer cast in test_imp

Change by Hood Chatham : -- pull_requests: +30341 pull_request: https://github.com/python/cpython/pull/32280 ___ Python tracker ___

[issue47196] Function pointer cast in test_imp

miss-islington added the comment: New changeset 7000cd70164707e28ba045b5c036ca7ed73f5dc4 by Hood Chatham in branch 'main': bpo-47196: Fix function pointer cast in test_imp (GH-32244) https://github.com/python/cpython/commit/7000cd70164707e28ba045b5c036ca7ed73f5dc4 -- nosy:

[issue47196] Function pointer cast in test_imp

Hood Chatham added the comment: Every other `PyInit` function in that module also needs the spec argument to be removed in order for test_importlib to pass. -- ___ Python tracker

[issue47196] Function pointer cast in test_imp

Change by Hood Chatham : -- keywords: +patch nosy: +hoodmane nosy_count: 2.0 -> 3.0 pull_requests: +30315 stage: -> patch review pull_request: https://github.com/python/cpython/pull/32244 ___ Python tracker

[issue47196] Function pointer cast in test_imp

New submission from Hood Chatham : The function PyInit_imp_dummy is declared as void f(PyObject* spec) and ignores the argument. In the test, it is called via imp.load_dynamic as void f(void). On wasm targets without the call trampolines added in https://bugs.python.org/issue47162 this