[Pywikipedia-bugs] [Maniphest] [Updated] T100610: -limit argument conflict

2023-03-31 Thread Pppery
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T100610 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pppery Cc: Kizule, Xqt, gerritbot, StudiesWorld, Ricordisamoa,

[Pywikipedia-bugs] [Maniphest] [Updated] T78452: Use pagegenerators consistently in scripts

2023-03-31 Thread Pppery
Pppery removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T78452 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pppery Cc: Dvorapa, gerritbot, Ricordisamoa, jayvdb, Aklapper, pywikibot-bugs-list, Mpaa, PotsdamLamb,

[Pywikipedia-bugs] [Maniphest] [Updated] T269635: OSM Wiki actually has item_namespace

2023-03-31 Thread Pppery
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T269635 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pppery Cc: Legoktm, matej_suchanek, Xqt, Aklapper,

[Pywikipedia-bugs] [Maniphest] [Updated] T216592: solve_disamiguation doesn't care about 'r' command

2023-03-31 Thread Pppery
Pppery removed a project: Patch-For-Review. Pppery added a comment. Patch was merged. Can this be closed as resolved? TASK DETAIL https://phabricator.wikimedia.org/T216592 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Pppery Cc: Pppery,

[pywikibot] Re: Place for Wikipedia in the framework

2023-03-31 Thread Bináris
Roy Smith ezt írta (időpont: 2023. márc. 31., P, 17:25): > For example, as I noted on the phab ticket, I've got my own code which > determines if an article is a biography. It uses an entirely different > method than your code does. For what I was doing, my method is the right > way. For what

[pywikibot] Re: Place for Wikipedia in the framework

2023-03-31 Thread שלום אורי דנינו
What about the suggestion to add derived class WikipediaPage (and module _wikipdia_page) I don't see any problem with this solution. We have the _wikibase module and all its class are imported to the main module __init__. I don't think it's a problem to open another specific module. And I say

[Pywikibot-commits] [Gerrit] ...core[master]: [IMPR] Speedup archivebot.py

2023-03-31 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/904606 ) Change subject: [IMPR] Speedup archivebot.py .. [IMPR] Speedup archivebot.py - Lazy load discussion page if archives, header

[Pywikipedia-bugs] [Maniphest] [Updated] T332657: KeyError: 'comment' in /pywikibot/site/_generators.py:1877

2023-03-31 Thread Maintenance_bot
Maintenance_bot removed a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T332657 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, Maintenance_bot Cc: Aklapper, Air7538, pywikibot-bugs-list, PotsdamLamb, Jyoo1011,

[Pywikipedia-bugs] [Maniphest] [Commented On] T332657: KeyError: 'comment' in /pywikibot/site/_generators.py:1877

2023-03-31 Thread gerritbot
gerritbot added a comment. Change 904769 **merged** by Xqt: [pywikibot/core@master] [bugfix] newpages should not fail for hidden comments https://gerrit.wikimedia.org/r/904769 TASK DETAIL https://phabricator.wikimedia.org/T332657 EMAIL PREFERENCES

[Pywikibot-commits] [Gerrit] ...core[master]: [bugfix] newpages should not fail for hidden comments

2023-03-31 Thread Xqt (Code Review)
Xqt has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/904769 ) Change subject: [bugfix] newpages should not fail for hidden comments .. [bugfix] newpages should not fail for hidden comments Use

[pywikibot] Re: Place for Wikipedia in the framework

2023-03-31 Thread Roy Smith
I'm relatively new to pywikibot, so I'm not really familiar with the culture of the project, i.e. which new features are accepted and which are rejected. But, yes, I did comment on the phab ticket that I thought this didn't belong as a part of the Page class. Let me give some of my more

[Pywikipedia-bugs] [Maniphest] [Closed] T332657: KeyError: 'comment' in /pywikibot/site/_generators.py:1877

2023-03-31 Thread Xqt
Xqt closed this task as "Resolved". TASK DETAIL https://phabricator.wikimedia.org/T332657 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper, Air7538, pywikibot-bugs-list, Themindcoder, Adamm71, Jersione, Hellket777, LisafBia6531, 786,

[Pywikipedia-bugs] [Maniphest] [Raised Priority] T240107: redirect.py should ignore broken redirects on non-empty pages

2023-03-31 Thread Xqt
Xqt raised the priority of this task from "Low" to "High". TASK DETAIL https://phabricator.wikimedia.org/T240107 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Xqt, MarcoAurelio, Aklapper, pywikibot-bugs-list, Amitie_10g, PotsdamLamb,

[Pywikipedia-bugs] [Maniphest] [Unassigned] T331422: Resolve conflict between code and docs in BasePage.getDeletedRevision

2023-03-31 Thread Xqt
Xqt removed Xqt as the assignee of this task. TASK DETAIL https://phabricator.wikimedia.org/T331422 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Xqt, Aklapper, pywikibot-bugs-list, binbot, PotsdamLamb, Jyoo1011, JohnsonLee01, SHEKH,

[Pywikipedia-bugs] [Maniphest] [Commented On] T332341: getSitelink() method reports incorrect page when a page is not linked to Data repo.

2023-03-31 Thread Xqt
Xqt added a comment. I think a new exception class should be used which derives from PageLoadRelatedError e.g. NoSiteLinkError. For backward compatibility it should also derive from NoPageError during a deprecation period (maybe until Pywikibot 9 or 10) TASK DETAIL

[Pywikipedia-bugs] [Maniphest] [Triaged] T332341: getSitelink() method reports incorrect page when a page is not linked to Data repo.

2023-03-31 Thread Xqt
Xqt triaged this task as "Medium" priority. Xqt added a comment. @Bleakprestiger are you working on it? TASK DETAIL https://phabricator.wikimedia.org/T332341 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Bleakprestiger, Xqt Cc: Xqt,

[Pywikipedia-bugs] [Maniphest] [Updated] T332657: KeyError: 'comment' in /pywikibot/site/_generators.py:1877

2023-03-31 Thread gerritbot
gerritbot added a project: Patch-For-Review. TASK DETAIL https://phabricator.wikimedia.org/T332657 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt, gerritbot Cc: Aklapper, Air7538, pywikibot-bugs-list, Themindcoder, Adamm71, Jersione,

[Pywikipedia-bugs] [Maniphest] [Commented On] T332657: KeyError: 'comment' in /pywikibot/site/_generators.py:1877

2023-03-31 Thread gerritbot
gerritbot added a comment. Change 904769 had a related patch set uploaded (by Xqt; author: Xqt): [pywikibot/core@master] [bugfix] newpages should not fail for hidden comments https://gerrit.wikimedia.org/r/904769 TASK DETAIL https://phabricator.wikimedia.org/T332657 EMAIL

[Pywikibot-commits] [Gerrit] ...core[master]: [test] stdnum 1.18+ is required, force it for tests

2023-03-31 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/904767 ) Change subject: [test] stdnum 1.18+ is required, force it for tests .. [test] stdnum 1.18+ is required, force it for tests

[Pywikipedia-bugs] [Maniphest] [Started] T332657: KeyError: 'comment' in /pywikibot/site/_generators.py:1877

2023-03-31 Thread Xqt
Xqt changed the task status from "Open" to "In Progress". Xqt triaged this task as "Medium" priority. Xqt claimed this task. TASK DETAIL https://phabricator.wikimedia.org/T332657 EMAIL PREFERENCES https://phabricator.wikimedia.org/settings/panel/emailpreferences/ To: Xqt Cc: Aklapper,

[Pywikibot-commits] [Gerrit] ...core[master]: [IMPR] Avoid too many return statements in _apisite.py

2023-03-31 Thread jenkins-bot (Code Review)
jenkins-bot has submitted this change. ( https://gerrit.wikimedia.org/r/c/pywikibot/core/+/904742 ) Change subject: [IMPR] Avoid too many return statements in _apisite.py .. [IMPR] Avoid too many return statements in

[pywikibot] Place for Wikipedia in the framework

2023-03-31 Thread Bináris
Tl;dr: is there a place for Wikipedia-related code? What do we do for code reusability? I proposed a Page method in https://phabricator.wikimedia.org/T328769. This would have shown if an article is a biography (it is about a person). My idea was opposed because the codebase of BasePage and