gerritbot added a comment.
Change 323549 abandoned by Xqt:
Increase default request timeout
Reason:
Already fixed with https://gerrit.wikimedia.org/r/335403
https://gerrit.wikimedia.org/r/323549TASK DETAILhttps://phabricator.wikimedia.org/T134640EMAIL
gerritbot added a comment.
Change 335403 merged by jenkins-bot:
TestUserContribsWithoutUser: Avoid too short prefixes
https://gerrit.wikimedia.org/r/335403TASK DETAILhttps://phabricator.wikimedia.org/T134640EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
Dalba added a comment.
@Magul Well, I think it would be better if we increased the timeouts as low as necessary. Especially that in multi-threaded environments these timeouts make the application completely unresponsive. When there is actually a problem with the connection somewhere an early
Magul added a comment.
I have just pushed update to my patch that will change default timeout to 1 minute instead of 5 (and fixing commit message typo).
@Dalba I'm not certain what kind of advantage we will get, if we will distinguish read timeout and connect timeout.
@Xqt I get Your hesitation
Xqt added a comment.
config.py setting is a default setting for all bot users. I guess most bot task does not exceed that given limit. For these problems while testing I think it would be better to use a changed value in the private user-config.py or set that config.py value for our tests. inside
Magul added a comment.
@MtDu CI == Continuous integration. In this situation we are talking about Travis CI, AppVeyor CI and after implementation Wikimedia CI.
@Xqt maybe we should found some number in beetween 30 and 300 that will make sense? Almost all requests take few seconds top to be
MtDu added a comment.
@Xqt What does CI stand for?TASK DETAILhttps://phabricator.wikimedia.org/T134640EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To: Magul, MtDuCc: MtDu, Lokal_Profil, Dalba, gerritbot, valhallasw, XZise, Aklapper, jayvdb, Zppix, Xqt,
Xqt added a comment.
I think a timeout of 5 minutes for a single request is to high. This could be misinterpreted a hanging script. Skipping the test would be appropriate. Or increasing it for CI tests only.TASK DETAILhttps://phabricator.wikimedia.org/T134640EMAIL
gerritbot added a comment.
Change 323549 had a related patch set uploaded (by Magul):
Increase defualt request timeout
https://gerrit.wikimedia.org/r/323549TASK DETAILhttps://phabricator.wikimedia.org/T134640EMAIL PREFERENCEShttps://phabricator.wikimedia.org/settings/panel/emailpreferences/To:
gerritbot added a comment.
Change 287403 merged by jenkins-bot:
[TEST] Test solution for https://phabricator.wikimedia.org/T134640
https://gerrit.wikimedia.org/r/287403
TASK DETAIL
https://phabricator.wikimedia.org/T134640
EMAIL PREFERENCES
gerritbot added a comment.
Change 287403 had a related patch set uploaded (by Xqt):
[TEST] Test solution for https://phabricator.wikimedia.org/T134640
https://gerrit.wikimedia.org/r/287403
TASK DETAIL
https://phabricator.wikimedia.org/T134640
EMAIL PREFERENCES
11 matches
Mail list logo